marcel/familienarchiv
1
0
Fork 0
Code Issues 108 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(transcription): guard @mention fetch against stale responses

Browse Source 
Tag each runSearch with an incrementing requestId; discard responses
whose id no longer matches the latest onSearch. Prevents a slow fetch
from repopulating the dropdown after the user has cleared the search.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-19 22:14:51 +02:00
committed by marcel
parent 640bdc12db
commit 033d430688
2 changed files with 43 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
frontend/src/lib/shared/discussion/PersonMentionEditor.svelte
View File

@@ -187,24 +187,33 @@ onMount(() => {
clientRect?: (() => DOMRect | null) | null;
};
// Request-token guard: every onSearch invocation bumps `requestId`;
// runSearch captures the id active when its fetch starts and discards
// the response if a newer onSearch has fired since. Without this, a
// late response can repopulate the dropdown after the user cleared
// the search input. Sara on PR #629.
let requestId = 0;
const runSearch = async (query: string) => {
const id = requestId;
try {
const res = await fetch(`/api/persons?q=${encodeURIComponent(query)}`);
if (id !== requestId) return;
if (!res.ok) {
dropdownState.items = [];
return;
}
dropdownState.items = ((await res.json()) as Person[]).slice(
0,
SEARCH_RESULT_LIMIT
);
const data = (await res.json()) as Person[];
if (id !== requestId) return;
dropdownState.items = data.slice(0, SEARCH_RESULT_LIMIT);
} catch {
if (id !== requestId) return;
dropdownState.items = [];
}
};
const debouncedSearch = debounce(runSearch, SEARCH_DEBOUNCE_MS);
cancelPendingSearch = () => debouncedSearch.cancel();
const onSearch = (query: string) => {
requestId++;
if (query.trim() === '') {
debouncedSearch.cancel();
dropdownState.items = [];