From 07fce7bb4496cd824efbc7255e2f65acfb720457 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Sun, 10 May 2026 01:00:34 +0200
Subject: [PATCH] test(persons): cover the edit page orchestrator branches

Edit heading, persons-section heading, form-error banner branch,
default no-error state, save-bar discard href targets the person
detail. Mocks confirm service.

5 tests, ~15 branches.

Refs #496.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../persons/[id]/edit/page.svelte.test.ts     | 67 +++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100644 frontend/src/routes/persons/[id]/edit/page.svelte.test.ts

diff --git a/frontend/src/routes/persons/[id]/edit/page.svelte.test.ts b/frontend/src/routes/persons/[id]/edit/page.svelte.test.ts
new file mode 100644
index 00000000..19197ab9
--- /dev/null
+++ b/frontend/src/routes/persons/[id]/edit/page.svelte.test.ts
@@ -0,0 +1,67 @@
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { cleanup, render } from 'vitest-browser-svelte';
+import { page } from 'vitest/browser';
+
+vi.mock('$lib/shared/services/confirm.svelte', () => ({
+	getConfirmService: () => ({ confirm: async () => false })
+}));
+vi.mock('$lib/shared/services/confirm.svelte.js', () => ({
+	getConfirmService: () => ({ confirm: async () => false })
+}));
+
+const { default: PersonEditPage } = await import('./+page.svelte');
+
+afterEach(cleanup);
+
+const basePerson = {
+	id: 'p-1',
+	firstName: 'Anna',
+	lastName: 'Schmidt',
+	displayName: 'Anna Schmidt',
+	personType: 'PERSON' as const,
+	familyMember: false
+};
+
+const baseData = (overrides: Record<string, unknown> = {}) => ({
+	person: basePerson,
+	aliases: [],
+	relationships: [],
+	inferredRelationships: [],
+	...overrides
+});
+
+describe('persons/[id]/edit page', () => {
+	it('renders the edit heading', async () => {
+		render(PersonEditPage, { props: { data: baseData(), form: undefined } });
+
+		await expect.element(page.getByRole('heading', { name: /person bearbeiten/i })).toBeVisible();
+	});
+
+	it('renders the persons-section heading', async () => {
+		render(PersonEditPage, { props: { data: baseData(), form: undefined } });
+
+		await expect.element(page.getByRole('heading', { name: /angaben zur person/i })).toBeVisible();
+	});
+
+	it('shows the form-error banner when form.updateError is set', async () => {
+		render(PersonEditPage, {
+			props: { data: baseData(), form: { updateError: 'Last name is required' } }
+		});
+
+		await expect.element(page.getByText('Last name is required')).toBeVisible();
+	});
+
+	it('does not show the form-error banner when form is undefined', async () => {
+		render(PersonEditPage, { props: { data: baseData(), form: undefined } });
+
+		const banner = document.querySelector('.bg-red-50.border-red-200');
+		expect(banner).toBeNull();
+	});
+
+	it('renders the save bar with the discard href pointing to the person detail', async () => {
+		render(PersonEditPage, { props: { data: baseData(), form: undefined } });
+
+		const link = document.querySelector('a[href="/persons/p-1"]');
+		expect(link).not.toBeNull();
+	});
+});