marcel/familienarchiv
1
0
Fork 0
Code Issues 103 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

test(archunit): fix foreignJpaRepositoryFor exact-segment matching

Browse Source 
Replace substring contains() with a regex exact-segment match so a
domain whose name is a substring of another (e.g. "tag" in "tagging")
cannot silently escape the predicate and produce a false negative.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-05 17:57:47 +02:00
parent 22ec808b2d
commit 0dd58556a7
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/test/java/org/raddatz/familienarchiv/shared/ArchitectureTest.java
View File

@@ -118,11 +118,15 @@ class ArchitectureTest {
// Tracked in: http://heim-nas:3005/marcel/familienarchiv/issues/427 // Tracked in: http://heim-nas:3005/marcel/familienarchiv/issues/427
private static DescribedPredicate<JavaClass> foreignJpaRepositoryFor(String ownDomain) { private static DescribedPredicate<JavaClass> foreignJpaRepositoryFor(String ownDomain) {
// Exact-segment match: prevents a domain name that is a substring of another
// (e.g. "tag" inside "tagging") from silently escaping the predicate.
// The pattern matches the domain as a complete path segment, with an optional sub-package.
String ownPackagePattern = ".*\\.familienarchiv\\." + ownDomain + "(\\..+)?$";
return new DescribedPredicate<JavaClass>("be a JPA repository from a domain other than " + ownDomain) { return new DescribedPredicate<JavaClass>("be a JPA repository from a domain other than " + ownDomain) {
@Override @Override
public boolean test(JavaClass clazz) { public boolean test(JavaClass clazz) {
return clazz.isAssignableTo(JpaRepository.class) return clazz.isAssignableTo(JpaRepository.class)
&& !clazz.getPackageName().contains("." + ownDomain); && !clazz.getPackageName().matches(ownPackagePattern);
} }
}; };
} }