marcel/familienarchiv
1
0
Fork 0
Code Issues 114 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(documents): bump timeline control buttons to 44x44 (#385)

Browse Source 
WCAG 2.5.8 (target size, AA) requires 44×44 minimum, and the
project's senior persona makes that a hard floor on desktop too.
Reset-zoom: h-6 → h-11 + min-w-[44px] + px-3.
Clear-selection: h-6 w-6 → h-11 w-11.

Two regression tests on the TimelineDensityFilter spec assert the
sized classes so a future shrink can't slip through silently.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-08 10:58:59 +02:00
parent 3b6b117c75
commit 153752a901
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/lib/document/TimelineControls.svelte
View File

@@ -22,7 +22,7 @@ let {
aria-label={m.timeline_zoom_reset()} aria-label={m.timeline_zoom_reset()}
title={m.timeline_zoom_reset()} title={m.timeline_zoom_reset()}
onclick={onresetzoom} onclick={onresetzoom}
class="hover:text-ink-1 inline-flex h-6 items-center justify-center gap-1 rounded-sm px-2 text-xs text-ink-3 hover:bg-canvas" class="hover:text-ink-1 inline-flex h-11 min-w-[44px] items-center justify-center gap-1 rounded-sm px-3 text-xs text-ink-3 hover:bg-canvas"
> >
↩ ↩
</button> </button>
@@ -33,7 +33,7 @@ let {
data-testid="timeline-clear" data-testid="timeline-clear"
aria-label={m.timeline_clear_selection()} aria-label={m.timeline_clear_selection()}
onclick={onclearselection} onclick={onclearselection}
class="hover:text-ink-1 inline-flex h-6 w-6 items-center justify-center rounded-full text-ink-3 hover:bg-canvas" class="hover:text-ink-1 inline-flex h-11 w-11 items-center justify-center rounded-full text-ink-3 hover:bg-canvas"
> >
× ×
</button> </button>

18
frontend/src/lib/document/TimelineDensityFilter.svelte.spec.ts
View File

@@ -308,6 +308,24 @@ describe('TimelineDensityFilter — zoom', () => {
}); });
}); });
describe('TimelineDensityFilter — touch targets', () => {
it('reset-zoom button is at least 44×44 (WCAG 2.5.8)', async () => {
render(TimelineDensityFilter, makeProps({ zoomFrom: '1915-08-01', zoomTo: '1915-09-30' }));
const resetBtn = document.querySelector('[data-testid="timeline-zoom-reset"]') as HTMLElement;
expect(resetBtn.classList.contains('h-11')).toBe(true);
expect(resetBtn.className).toMatch(/min-w-\[44px\]/);
expect(resetBtn.className).not.toMatch(/(?:^|\s)h-6(?:$|\s)/);
});
it('clear-selection button is at least 44×44 (WCAG 2.5.8)', async () => {
render(TimelineDensityFilter, makeProps({ from: '1915-08-01', to: '1915-09-30' }));
const clearBtn = document.querySelector('[data-testid="timeline-clear"]') as HTMLElement;
expect(clearBtn.classList.contains('h-11')).toBe(true);
expect(clearBtn.classList.contains('w-11')).toBe(true);
expect(clearBtn.className).not.toMatch(/(?:^|\s)h-6(?:$|\s)/);
});
});
describe('TimelineDensityFilter — accessibility', () => { describe('TimelineDensityFilter — accessibility', () => {
it('Y-axis labels meet the 12px minimum font floor (Tailwind text-xs)', async () => { it('Y-axis labels meet the 12px minimum font floor (Tailwind text-xs)', async () => {
render(TimelineDensityFilter, makeProps()); render(TimelineDensityFilter, makeProps());