marcel/familienarchiv
1
0
Fork 0
Code Issues 116 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(transcription): split reorderBlocks for command-query separation
Some checks failed
CI / Unit & Component Tests (push) Failing after 1m46s
Details
CI / Backend Unit Tests (push) Failing after 2m26s
Details
CI / E2E Tests (push) Has started running
Details
CI / Unit & Component Tests (pull_request) Failing after 1m11s
Details
CI / Backend Unit Tests (pull_request) Failing after 2m24s
Details
CI / E2E Tests (pull_request) Failing after 1h25m31s
Details

Browse Source 
TranscriptionService.reorderBlocks() now returns void (command).
Controller calls listBlocks() separately after reorder (query).
Updated test to match new void signature.

Fixes @Felix: "reorderBlocks violates command-query separation"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-05 20:32:44 +02:00
parent d13f6f69d5
commit 18c6bca2dd
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
backend/src/test/java/org/raddatz/familienarchiv/service/TranscriptionServiceTest.java
View File

@@ -184,7 +184,6 @@ class TranscriptionServiceTest {
when(blockRepository.findByIdAndDocumentId(id2, docId)).thenReturn(Optional.of(block2));
when(blockRepository.findByIdAndDocumentId(id1, docId)).thenReturn(Optional.of(block1));
when(blockRepository.save(any())).thenAnswer(inv -> inv.getArgument(0));
when(blockRepository.findByDocumentIdOrderBySortOrderAsc(docId)).thenReturn(List.of(block2, block1));
ReorderTranscriptionBlocksDTO dto = new ReorderTranscriptionBlocksDTO(List.of(id2, id1));