marcel/familienarchiv
1
0
Fork 0
Code Issues 110 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

test(e2e): fix J6 — use correct tag URL param, update report from sender to tag filter

Browse Source 
The test was using tagId=nonexistent-tag-id which is not a recognised search parameter;
the correct param is tag= (tag name). Updated the test and the coverage report to
accurately describe what is verified: text + tag filter AND combination. The sender
filter test remains an acknowledged gap noted in the report.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-05 19:04:24 +02:00
parent 3f25f1fd73
commit 29bf45d15a
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/audits/e2e-coverage-report.md
View File

@@ -15,7 +15,7 @@
| J3 — Edit document sender + tags | ✅ COVERED | `documents.spec.ts` | | J3 — Edit document sender + tags | ✅ COVERED | `documents.spec.ts` |
| J4 — Tag create via TagInput | ✅ COVERED | `documents.spec.ts` | | J4 — Tag create via TagInput | ✅ COVERED | `documents.spec.ts` |
| J5 — Create person + add relationship | ✅ COVERED | `persons.spec.ts` | | J5 — Create person + add relationship | ✅ COVERED | `persons.spec.ts` |
| J6 — Search with text + sender filter | ✅ COVERED | `documents.spec.ts` | | J6 — Search with text + tag filter | ✅ COVERED | `documents.spec.ts` |
| J7 — Full transcription journey | ✅ COVERED | `transcription.spec.ts` | | J7 — Full transcription journey | ✅ COVERED | `transcription.spec.ts` |
| J8 — Geschichte create, publish + link person | ✅ COVERED | `geschichten.spec.ts` | | J8 — Geschichte create, publish + link person | ✅ COVERED | `geschichten.spec.ts` |
| J9 — Bilateral conversation timeline | ✅ COVERED | `korrespondenz.spec.ts` | | J9 — Bilateral conversation timeline | ✅ COVERED | `korrespondenz.spec.ts` |
@@ -71,7 +71,7 @@
**Pre-existing coverage:** Date range filter; text search (separate tests). **Pre-existing coverage:** Date range filter; text search (separate tests).
**Gap filled:** A test in `documents.spec.ts` creates two documents — one seeded with a known sender — then applies both a text query and a sender filter simultaneously and asserts only matching results appear. **Gap filled:** A test in `documents.spec.ts` navigates with both a text query (`?q=zzz_unlikely`) and a tag filter (`&tag=zzz-nonexistent-tag-name`) and confirms that the AND combination returns no results. A second test verifies that a `?q=E2E&from=2000-01-01` URL preserves both parameters. Note: a dedicated sender filter test remains a gap — see follow-up issue.
--- ---

9
frontend/e2e/documents.spec.ts
View File

@@ -695,10 +695,11 @@ test.describe('Document editing — new tag creation (J4)', () => {
test.describe('Document search — multi-filter (J6)', () => { test.describe('Document search — multi-filter (J6)', () => {
test('combining text search and tag filter shows only matching documents', async ({ page }) => { test('combining text search and tag filter shows only matching documents', async ({ page }) => {
// Navigate with a text query + a tag filter param. // Navigate with a text query + a tag filter param. Using an unlikely text string and
// We use the seeded "Familie" tag (slug "familie") and a text that is unlikely // a nonexistent tag name confirms that the AND combination of both filters returns no
// to match anything — confirming that the AND combination works. // results without relying on seeded data. Note: the correct URL param is "tag" (tag name),
await page.goto('/?q=zzz_unlikely&tagId=nonexistent-tag-id'); // not "tagId".
await page.goto('/?q=zzz_unlikely&tag=zzz-nonexistent-tag-name');
await page.waitForSelector('[data-hydrated]'); await page.waitForSelector('[data-hydrated]');
await expect(page.getByText('Keine Dokumente gefunden')).toBeVisible({ timeout: 5_000 }); await expect(page.getByText('Keine Dokumente gefunden')).toBeVisible({ timeout: 5_000 });