marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(themen): show the subtree rollup count on reader surfaces (#698)

Browse Source 
The /themen page (box header, child rows, aria-labels) and the dashboard
ThemenWidget now display subtreeDocumentCount instead of the direct
documentCount, so a topic's number reflects its whole sub-topic tree and
matches what /documents?tag=X actually returns. A parent with 0 direct
documents but documents under its children now shows a non-zero total.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-31 12:25:52 +02:00
committed by marcel
parent 16f1fe7616
commit 29ea27319a
4 changed files with 30 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/lib/shared/dashboard/ThemenWidget.svelte
View File

@@ -41,8 +41,8 @@ const shownTags = $derived(visibleTags.slice(0, MAX_VISIBLE_TAGS));
{#each shownTags as tag (tag.id)}
<a
href="/documents?tag={encodeURIComponent(tag.name)}"
aria-label="{tag.name}{tag.documentCount > 0
? ', ' + m.themen_dokumente({ count: tag.documentCount })
aria-label="{tag.name}{tag.subtreeDocumentCount > 0
? ', ' + m.themen_dokumente({ count: tag.subtreeDocumentCount })
: ''}"
class="flex cursor-pointer items-stretch overflow-hidden rounded-sm border border-line bg-canvas hover:bg-surface focus-visible:ring-2 focus-visible:ring-brand-navy focus-visible:outline-none"
style="min-height: 56px"
@@ -54,9 +54,9 @@ const shownTags = $derived(visibleTags.slice(0, MAX_VISIBLE_TAGS));
></span>
<span class="flex min-w-0 flex-1 flex-col justify-center gap-0.5 px-3 py-3">
<span class="truncate font-serif text-sm font-semibold text-ink">{tag.name}</span>
{#if tag.documentCount > 0}
{#if tag.subtreeDocumentCount > 0}
<span class="font-sans text-xs text-ink-3 tabular-nums">
{m.themen_dokumente({ count: tag.documentCount })}
{m.themen_dokumente({ count: tag.subtreeDocumentCount })}
</span>
{/if}
</span>

13
frontend/src/lib/shared/dashboard/ThemenWidget.svelte.spec.ts
View File

@@ -12,9 +12,10 @@ type TagTreeNodeDTO = components['schemas']['TagTreeNodeDTO'];
function makeTag(
name: string,
documentCount: number,
children: TagTreeNodeDTO[] = []
children: TagTreeNodeDTO[] = [],
subtreeDocumentCount: number = documentCount
): TagTreeNodeDTO {
return { id: 'id-' + name, name, documentCount, children };
return { id: 'id-' + name, name, documentCount, subtreeDocumentCount, children };
}
describe('ThemenWidget', () => {
@@ -32,6 +33,14 @@ describe('ThemenWidget', () => {
expect(document.body.textContent).not.toContain('Leer');
});
it('displays the subtree rollup count for a tag with 0 direct documents', async () => {
// 0 direct documents, but the subtree rolls up to 8 — the widget shows the rollup.
const tags = [makeTag('Reisen', 0, [], 8)];
render(ThemenWidget, { tags });
expect(document.body.textContent).toContain('Reisen');
expect(document.body.textContent).toContain('8');
});
it('shows the empty state text when all tags are filtered out', async () => {
render(ThemenWidget, { tags: [makeTag('Leer', 0)] });
expect(document.body.textContent).toMatch(/Noch keine Themen/);