fix(nav): restore DocumentTopBar back button sizing and add right padding
- BackButton gains showLabel prop: showLabel=false renders icon-only with aria-label, no mr-2 on svg (was causing 0px button width in topbar) - DocumentTopBar: BackButton restored to h-11 w-11 circular touch target with showLabel=false matching the original 44×44px <a> it replaced - Topbar row gets pr-4 (16px right padding per spec); action buttons div no longer needs its own pr-3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,15 +1,16 @@
|
|||||||
<script lang="ts">
|
<script lang="ts">
|
||||||
import { m } from '$lib/paraglide/messages.js';
|
import { m } from '$lib/paraglide/messages.js';
|
||||||
let { class: cls = 'mb-4' }: { class?: string } = $props();
|
let { class: cls = 'mb-4', showLabel = true }: { class?: string; showLabel?: boolean } = $props();
|
||||||
</script>
|
</script>
|
||||||
|
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onclick={() => history.back()}
|
onclick={() => history.back()}
|
||||||
|
aria-label={!showLabel ? m.btn_back() : undefined}
|
||||||
class="group {cls} inline-flex min-h-[44px] items-center text-xs font-bold tracking-widest text-ink-2 uppercase transition-colors outline-none hover:text-ink focus-visible:ring-2 focus-visible:ring-focus-ring"
|
class="group {cls} inline-flex min-h-[44px] items-center text-xs font-bold tracking-widest text-ink-2 uppercase transition-colors outline-none hover:text-ink focus-visible:ring-2 focus-visible:ring-focus-ring"
|
||||||
>
|
>
|
||||||
<svg
|
<svg
|
||||||
class="mr-2 h-4 w-4 transform transition-transform group-hover:-translate-x-1"
|
class="{showLabel ? 'mr-2' : ''} h-4 w-4 transform transition-transform group-hover:-translate-x-1"
|
||||||
fill="none"
|
fill="none"
|
||||||
stroke="currentColor"
|
stroke="currentColor"
|
||||||
viewBox="0 0 24 24"
|
viewBox="0 0 24 24"
|
||||||
@@ -22,5 +23,5 @@ let { class: cls = 'mb-4' }: { class?: string } = $props();
|
|||||||
d="M10 19l-7-7m0 0l7-7m-7 7h18"
|
d="M10 19l-7-7m0 0l7-7m-7 7h18"
|
||||||
/>
|
/>
|
||||||
</svg>
|
</svg>
|
||||||
{m.btn_back()}
|
{#if showLabel}{m.btn_back()}{/if}
|
||||||
</button>
|
</button>
|
||||||
|
|||||||
@@ -33,4 +33,11 @@ describe('BackButton', () => {
|
|||||||
expect(btn?.className).toContain('mr-3');
|
expect(btn?.className).toContain('mr-3');
|
||||||
expect(btn?.className).not.toContain('mb-4');
|
expect(btn?.className).not.toContain('mb-4');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('hides label text and sets aria-label when showLabel is false', async () => {
|
||||||
|
render(BackButton, { props: { showLabel: false } });
|
||||||
|
const btn = document.querySelector('button');
|
||||||
|
expect(btn?.textContent?.trim()).toBe('');
|
||||||
|
expect(btn?.getAttribute('aria-label')).toMatch(/zurück/i);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -129,12 +129,15 @@ let mobileMenuOpen = $state(false);
|
|||||||
|
|
||||||
<div data-topbar class="relative z-10 border-b border-line bg-surface shadow-sm">
|
<div data-topbar class="relative z-10 border-b border-line bg-surface shadow-sm">
|
||||||
<!-- Main row -->
|
<!-- Main row -->
|
||||||
<div class="flex h-[75px] shrink-0 items-center xs:h-[88px]">
|
<div class="flex h-[75px] shrink-0 items-center pr-4 xs:h-[88px]">
|
||||||
<!-- Accent bar -->
|
<!-- Accent bar -->
|
||||||
<div class="h-full w-[3px] shrink-0 bg-primary"></div>
|
<div class="h-full w-[3px] shrink-0 bg-primary"></div>
|
||||||
|
|
||||||
<!-- Back button -->
|
<!-- Back button -->
|
||||||
<BackButton class="-ml-0.5 shrink-0" />
|
<BackButton
|
||||||
|
class="-ml-0.5 h-11 w-11 shrink-0 justify-center rounded-full hover:bg-muted"
|
||||||
|
showLabel={false}
|
||||||
|
/>
|
||||||
|
|
||||||
<!-- Divider -->
|
<!-- Divider -->
|
||||||
<div class="mx-2 h-6 w-px shrink-0 bg-line"></div>
|
<div class="mx-2 h-6 w-px shrink-0 bg-line"></div>
|
||||||
@@ -190,7 +193,7 @@ let mobileMenuOpen = $state(false);
|
|||||||
<div class="mx-3 hidden h-6 w-px shrink-0 bg-line md:block"></div>
|
<div class="mx-3 hidden h-6 w-px shrink-0 bg-line md:block"></div>
|
||||||
|
|
||||||
<!-- Action buttons -->
|
<!-- Action buttons -->
|
||||||
<div class="flex shrink-0 items-center gap-1.5 pr-3 font-sans">
|
<div class="flex shrink-0 items-center gap-1.5 font-sans">
|
||||||
{#if canWrite && isPdf && !transcribeMode}
|
{#if canWrite && isPdf && !transcribeMode}
|
||||||
{@render transcribeBtn(false)}
|
{@render transcribeBtn(false)}
|
||||||
{/if}
|
{/if}
|
||||||
|
|||||||
Reference in New Issue
Block a user