marcel/familienarchiv
1
0
Fork 0
Code Issues 111 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(training): strengthen TrainingBlockQueryTest assertions
Some checks failed
CI / OCR Service Tests (push) Has been cancelled
Details
CI / Backend Unit Tests (push) Has been cancelled
Details
CI / Unit & Component Tests (push) Has been cancelled
Details

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit was merged in pull request #378.
This commit is contained in:
Marcel
2026-05-04 15:12:38 +02:00
committed by marcel
parent dd9c4d57ee
commit 32e4e30e40
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
backend/src/test/java/org/raddatz/familienarchiv/repository/TrainingBlockQueryTest.java
View File

@@ -11,6 +11,7 @@ import org.springframework.boot.jdbc.test.autoconfigure.AutoConfigureTestDatabas
import org.springframework.boot.data.jpa.test.autoconfigure.DataJpaTest; import org.springframework.boot.data.jpa.test.autoconfigure.DataJpaTest;
import org.springframework.context.annotation.Import; import org.springframework.context.annotation.Import;
import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.UUID; import java.util.UUID;
@@ -37,7 +38,7 @@ class TrainingBlockQueryTest {
.title("Kurrent Brief") .title("Kurrent Brief")
.originalFilename("kurrent.pdf") .originalFilename("kurrent.pdf")
.status(DocumentStatus.UPLOADED) .status(DocumentStatus.UPLOADED)
.trainingLabels(new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))) .trainingLabels(new HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION)))
.build()); .build());
kurrentDocId = kurrentDoc.getId(); kurrentDocId = kurrentDoc.getId();
@@ -122,7 +123,7 @@ class TrainingBlockQueryTest {
.originalFilename("karl.pdf") .originalFilename("karl.pdf")
.status(DocumentStatus.UPLOADED) .status(DocumentStatus.UPLOADED)
.sender(sender) .sender(sender)
.trainingLabels(new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))) .trainingLabels(new HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION)))
.build()); .build());
UUID annId = annotationRepository.save(annotation(doc.getId())).getId(); UUID annId = annotationRepository.save(annotation(doc.getId())).getId();
blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false)); blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false));
@@ -157,7 +158,7 @@ class TrainingBlockQueryTest {
.originalFilename("karl.pdf") .originalFilename("karl.pdf")
.status(DocumentStatus.UPLOADED) .status(DocumentStatus.UPLOADED)
.sender(sender) .sender(sender)
.trainingLabels(new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))) .trainingLabels(new HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION)))
.build()); .build());
UUID annId = annotationRepository.save(annotation(doc.getId())).getId(); UUID annId = annotationRepository.save(annotation(doc.getId())).getId();
blockRepository.save(block(doc.getId(), annId, BlockSource.OCR, false)); blockRepository.save(block(doc.getId(), annId, BlockSource.OCR, false));
@@ -176,7 +177,7 @@ class TrainingBlockQueryTest {
.originalFilename("karl.pdf") .originalFilename("karl.pdf")
.status(DocumentStatus.UPLOADED) .status(DocumentStatus.UPLOADED)
.sender(karl) .sender(karl)
.trainingLabels(new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))) .trainingLabels(new HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION)))
.build()); .build());
UUID annId = annotationRepository.save(annotation(doc.getId())).getId(); UUID annId = annotationRepository.save(annotation(doc.getId())).getId();
blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false)); blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false));
@@ -194,15 +195,25 @@ class TrainingBlockQueryTest {
.originalFilename("karl.pdf") .originalFilename("karl.pdf")
.status(DocumentStatus.UPLOADED) .status(DocumentStatus.UPLOADED)
.sender(sender) .sender(sender)
.trainingLabels(new java.util.HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION))) .trainingLabels(new HashSet<>(Set.of(TrainingLabel.KURRENT_RECOGNITION)))
.build()); .build());
UUID annId = annotationRepository.save(annotation(doc.getId())).getId(); UUID annId = annotationRepository.save(annotation(doc.getId())).getId();
blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false)); blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, false));
blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, true)); blockRepository.save(block(doc.getId(), annId, BlockSource.MANUAL, true));
long count = blockRepository.countManualKurrentBlocksByPerson(sender.getId()); long count = blockRepository.countManualKurrentBlocksByPerson(sender.getId());
List<TranscriptionBlock> found = blockRepository.findManualKurrentBlocksByPerson(sender.getId());
assertThat(count).isEqualTo(2); assertThat(count).isEqualTo(found.size());
}
@Test
void countManualKurrentBlocksByPerson_returnsZeroWhenNoBlocksMatch() {
Person sender = personRepository.save(Person.builder().firstName("Karl").lastName("Test").build());
long count = blockRepository.countManualKurrentBlocksByPerson(sender.getId());
assertThat(count).isZero();
} }
// ─── helpers ───────────────────────────────────────────────────────────── // ─── helpers ─────────────────────────────────────────────────────────────