marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

test(mention): lock deleted-person graceful-degradation contract (#684)

Browse Source 
Strengthen one renderTranscriptionBody case into the AC-6 contract: a
@DisplayName with an empty mentionedPersons array (the deleted-person case
V71 produces) must render as plain readable text with no <a>, person-mention
class, data-person-id, or href. Guards against a future renderer refactor
silently reintroducing the dead-link-on-deleted-person degradation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-06-06 11:49:48 +02:00
committed by marcel
parent 6d267f2269
commit 378da60ae8
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
frontend/src/lib/shared/discussion/mention.spec.ts
View File

@@ -307,9 +307,21 @@ describe('renderTranscriptionBody', () => {
expect(result).not.toMatch(/>O"Brien<\/a>/);
});
it('renders nothing when mentionedPersons is undefined-empty and no @ triggers', () => {
const result = renderTranscriptionBody('Plain old transcription text.', []);
expect(result).toBe('Plain old transcription text.');
it('renders a deleted-person @mention as plain text with no dead link (graceful degradation)', () => {
// AC-6 (#684): when a mentioned person is deleted, V71's ON DELETE CASCADE removes the
// sidecar row, so the displayName reaches the renderer with an empty mentionedPersons
// array. The reader must still see the name as plain text — never a dead <a>, a
// person-mention class, a data-person-id, or an href. This locks the degradation
// contract so a future renderer refactor cannot silently reintroduce a dead link.
const result = renderTranscriptionBody('Brief an @Auguste Raddatz vom Mai', []);
// (a) the reader still sees the readable name and the surrounding sentence verbatim
expect(result).toContain('Auguste Raddatz');
expect(result).toBe('Brief an @Auguste Raddatz vom Mai');
// (b) none of the anchor artifacts leak through
expect(result).not.toContain('<a');
expect(result).not.toContain('person-mention');
expect(result).not.toContain('data-person-id');
expect(result).not.toContain('href');
});
it('skips substitution when personId is not a UUID (defense in depth)', () => {