marcel/familienarchiv
1
0
Fork 0
Code Issues 126 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(e2e): use dedicated reset user instead of admin in password-reset test
Some checks failed
CI / Unit & Component Tests (push) Failing after 3m34s
Details
CI / OCR Service Tests (push) Successful in 37s
Details
CI / Backend Unit Tests (push) Failing after 3m13s
Details

Browse Source 
Introduces a separate reset@familyarchive.local / reset123 seed account
(e2e profile only) so the password-reset flow test never touches the
shared admin credentials.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-05 21:17:00 +02:00
parent f14c8b9eea
commit 39e7ee2c71
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
backend/src/main/java/org/raddatz/familienarchiv/user/UserDataInitializer.java
View File

@@ -102,6 +102,21 @@ public class UserDataInitializer {
log.info("E2E seed: 'reader'-Testbenutzer erstellt."); log.info("E2E seed: 'reader'-Testbenutzer erstellt.");
} }
if (userRepository.findByEmail("reset@familyarchive.local").isEmpty()) {
log.info("E2E seed: Erstelle 'reset'-Testbenutzer...");
UserGroup leserGroup = groupRepository.findByName("Leser").orElseGet(() ->
groupRepository.save(UserGroup.builder()
.name("Leser")
.permissions(Set.of("READ_ALL"))
.build()));
userRepository.save(AppUser.builder()
.email("reset@familyarchive.local")
.password(passwordEncoder.encode("reset123"))
.groups(Set.of(leserGroup))
.build());
log.info("E2E seed: 'reset'-Testbenutzer erstellt.");
}
if (personRepo.count() > 0) { if (personRepo.count() > 0) {
log.info("E2E seed: Personendaten bereits vorhanden, überspringe Dokument-Seed."); log.info("E2E seed: Personendaten bereits vorhanden, überspringe Dokument-Seed.");
return; return;

9
frontend/e2e/password-reset.spec.ts
View File

@@ -42,8 +42,9 @@ test.describe('Password reset', () => {
}); });
test('full password reset flow', async ({ page }) => { test('full password reset flow', async ({ page }) => {
const testEmail = process.env.E2E_EMAIL ?? 'admin@familyarchive.local'; // Uses a dedicated low-privilege test account so the admin account is never touched.
const originalPassword = process.env.E2E_PASSWORD ?? 'admin123'; const testEmail = 'reset@familyarchive.local';
const originalPassword = 'reset123';
const newPassword = 'NewP@ssw0rd_E2E!'; const newPassword = 'NewP@ssw0rd_E2E!';
// 1. Request reset // 1. Request reset
@@ -70,7 +71,7 @@ test.describe('Password reset', () => {
// 5. Log in with new password // 5. Log in with new password
await expect(page).toHaveURL(/\/login/); await expect(page).toHaveURL(/\/login/);
await page.getByLabel('Benutzername').fill(process.env.E2E_USERNAME ?? 'admin'); await page.getByLabel('Benutzername').fill(testEmail);
await page.getByLabel('Passwort').fill(newPassword); await page.getByLabel('Passwort').fill(newPassword);
await page.getByRole('button', { name: 'Anmelden' }).click(); await page.getByRole('button', { name: 'Anmelden' }).click();
await expect(page).toHaveURL('/'); await expect(page).toHaveURL('/');
@@ -85,7 +86,7 @@ test.describe('Password reset', () => {
await expect(page).toHaveURL(/\/login/); await expect(page).toHaveURL(/\/login/);
// 7. Log back in with original password to confirm restore worked // 7. Log back in with original password to confirm restore worked
await page.getByLabel('Benutzername').fill(process.env.E2E_USERNAME ?? 'admin'); await page.getByLabel('Benutzername').fill(testEmail);
await page.getByLabel('Passwort').fill(originalPassword); await page.getByLabel('Passwort').fill(originalPassword);
await page.getByRole('button', { name: 'Anmelden' }).click(); await page.getByRole('button', { name: 'Anmelden' }).click();
await expect(page).toHaveURL('/'); await expect(page).toHaveURL('/');