fix(transcription): auto-capture quote on text selection, smart comment button
Some checks failed
CI / Unit & Component Tests (push) Has been cancelled
CI / Backend Unit Tests (push) Has been cancelled
CI / E2E Tests (push) Has been cancelled
CI / Unit & Component Tests (pull_request) Has been cancelled
CI / Backend Unit Tests (pull_request) Has been cancelled
CI / E2E Tests (pull_request) Has been cancelled

- Quote captured automatically on mouseup in textarea (no button needed)
  Selection is held in state and pre-fills the comment input
- "Kommentieren" button only shown when zero comments exist
  When comments are present, the input is already visible — button is noise
- Chat bubble icon added to Kommentieren button for visual consistency

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-05 22:30:13 +02:00
parent e384c87eef
commit 3d086bd1fb
2 changed files with 36 additions and 34 deletions

View File

@@ -36,9 +36,12 @@ let {
let localText = $state(text); let localText = $state(text);
let commentOpen = $state(false); let commentOpen = $state(false);
let commentCount = $state(0);
let selectedQuote = $state<string | null>(null); let selectedQuote = $state<string | null>(null);
let textareaEl = $state<HTMLTextAreaElement | null>(null); let textareaEl = $state<HTMLTextAreaElement | null>(null);
const hasComments = $derived(commentCount > 0);
// Sync from prop only when switching to a different block (not on save responses) // Sync from prop only when switching to a different block (not on save responses)
let prevBlockId = $state(blockId); let prevBlockId = $state(blockId);
$effect(() => { $effect(() => {
@@ -83,17 +86,15 @@ function handleDelete() {
} }
} }
function captureSelectionAndOpenComments() { function handleTextareaMouseUp() {
if (textareaEl) { if (!textareaEl) return;
const start = textareaEl.selectionStart; const start = textareaEl.selectionStart;
const end = textareaEl.selectionEnd; const end = textareaEl.selectionEnd;
if (start !== end) { if (start !== end) {
selectedQuote = localText.substring(start, end); selectedQuote = localText.substring(start, end);
} else { } else {
selectedQuote = null; selectedQuote = null;
}
} }
commentOpen = true;
} }
</script> </script>
@@ -126,22 +127,33 @@ function captureSelectionAndOpenComments() {
value={localText} value={localText}
oninput={handleInput} oninput={handleInput}
onfocus={onFocus} onfocus={onFocus}
onmouseup={handleTextareaMouseUp}
></textarea> ></textarea>
<!-- Footer --> <!-- Footer -->
<div class="flex items-center justify-between border-t border-line pt-2"> <div class="flex items-center justify-between border-t border-line pt-2">
<div class="flex flex-col gap-1"> <div>
<button {#if !hasComments}
type="button" <button
class="text-xs font-medium text-ink-2 transition-colors hover:text-ink" type="button"
onclick={captureSelectionAndOpenComments} class="flex items-center gap-1 text-xs font-medium text-ink-2 transition-colors hover:text-ink"
> onclick={() => (commentOpen = true)}
{m.transcription_block_comment_btn()} >
</button> <svg
{#if active} class="h-3 w-3"
<span class="text-xs text-ink-3"> viewBox="0 0 24 24"
{m.transcription_block_quote_hint()} fill="none"
</span> stroke="currentColor"
stroke-width="2"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
d="M2.25 12.76c0 1.6 1.123 2.994 2.707 3.227 1.087.16 2.185.283 3.293.369V21l4.076-4.076a1.526 1.526 0 011.037-.443 48.282 48.282 0 005.68-.494c1.584-.233 2.707-1.626 2.707-3.228V6.741c0-1.602-1.123-2.995-2.707-3.228A48.394 48.394 0 0012 3c-2.392 0-4.744.175-7.043.513C3.373 3.746 2.25 5.14 2.25 6.741v6.018z"
/>
</svg>
{m.transcription_block_comment_btn()}
</button>
{/if} {/if}
</div> </div>
@@ -204,6 +216,7 @@ function captureSelectionAndOpenComments() {
canComment={canComment} canComment={canComment}
quotedText={selectedQuote} quotedText={selectedQuote}
showCompose={commentOpen} showCompose={commentOpen}
onCountChange={(count) => (commentCount = count)}
/> />
</div> </div>
</div> </div>

View File

@@ -114,20 +114,9 @@ describe('TranscriptionBlock — interactions', () => {
expect(onFocus).toHaveBeenCalled(); expect(onFocus).toHaveBeenCalled();
}); });
it('shows Kommentieren button that opens comment thread', async () => { it('shows Kommentieren button when no comments exist', async () => {
renderBlock(); renderBlock();
const btn = page.getByText('Kommentieren'); const btn = page.getByText('Kommentieren');
await expect.element(btn).toBeInTheDocument(); await expect.element(btn).toBeInTheDocument();
}); });
it('shows quote hint when block is active', async () => {
renderBlock({ active: true });
await expect.element(page.getByText('Text markieren für Zitat')).toBeInTheDocument();
});
it('hides quote hint when block is not active', async () => {
renderBlock({ active: false });
const hint = page.getByText('Text markieren für Zitat');
await expect.element(hint).not.toBeInTheDocument();
});
}); });