marcel/familienarchiv
1
0
Fork 0
Code Issues 102 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(persons): redesign /persons/[id] detail page (Concept A layout)

Browse Source 
PersonCard: remove edit toggle, add Edit→/edit link; 2-column layout on lg;
CoCorrespondentsList: add chat icon + title tooltip; remove update/merge actions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-03-29 19:55:31 +02:00
parent 7141ae1e1f
commit 44e8891ca9
5 changed files with 137 additions and 295 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
frontend/src/routes/persons/[id]/page.server.spec.ts
View File

@@ -6,6 +6,8 @@ vi.mock('$lib/api.server', () => ({ createApiClient: vi.fn() }));
import { createApiClient } from '$lib/api.server';
const mockFetch = vi.fn() as unknown as typeof fetch;
const mockLocals = { user: { groups: [{ permissions: ['READ_ALL'] }] } };
const mockLocalsWriter = { user: { groups: [{ permissions: ['WRITE_ALL'] }] } };
beforeEach(() => vi.clearAllMocks());
@@ -24,13 +26,30 @@ describe('person detail load — happy path', () => {
.mockResolvedValueOnce({ response: { ok: true }, data: [] })
} as ReturnType<typeof createApiClient>);
const result = await load({ params: { id: 'p1' }, fetch: mockFetch });
const result = await load({ params: { id: 'p1' }, fetch: mockFetch, locals: mockLocals });
expect(result.person.firstName).toBe('Hans');
expect(result.sentDocuments).toHaveLength(1);
expect(result.receivedDocuments).toEqual([]);
});
it('returns canWrite=true when user has WRITE_ALL', async () => {
vi.mocked(createApiClient).mockReturnValue({
GET: vi
.fn()
.mockResolvedValueOnce({
response: { ok: true, status: 200 },
data: { id: 'p1', firstName: 'Anna', lastName: 'Schmidt' }
})
.mockResolvedValueOnce({ response: { ok: true }, data: [] })
.mockResolvedValueOnce({ response: { ok: true }, data: [] })
} as ReturnType<typeof createApiClient>);
const result = await load({ params: { id: 'p1' }, fetch: mockFetch, locals: mockLocalsWriter });
expect(result.canWrite).toBe(true);
});
it('returns empty arrays when sent/received document APIs fail', async () => {
vi.mocked(createApiClient).mockReturnValue({
GET: vi
@@ -43,7 +62,7 @@ describe('person detail load — happy path', () => {
.mockResolvedValueOnce({ response: { ok: false }, data: null })
} as ReturnType<typeof createApiClient>);
const result = await load({ params: { id: 'p1' }, fetch: mockFetch });
const result = await load({ params: { id: 'p1' }, fetch: mockFetch, locals: mockLocals });
expect(result.sentDocuments).toEqual([]);
expect(result.receivedDocuments).toEqual([]);
@@ -62,7 +81,9 @@ describe('person detail load — error paths', () => {
.mockResolvedValueOnce({ response: { ok: true }, data: [] })
} as ReturnType<typeof createApiClient>);
await expect(load({ params: { id: 'missing' }, fetch: mockFetch })).rejects.toMatchObject({
await expect(
load({ params: { id: 'missing' }, fetch: mockFetch, locals: mockLocals })
).rejects.toMatchObject({
status: 404
});
});
@@ -76,7 +97,9 @@ describe('person detail load — error paths', () => {
.mockResolvedValueOnce({ response: { ok: true }, data: [] })
} as ReturnType<typeof createApiClient>);
await expect(load({ params: { id: 'forbidden' }, fetch: mockFetch })).rejects.toMatchObject({
await expect(
load({ params: { id: 'forbidden' }, fetch: mockFetch, locals: mockLocals })
).rejects.toMatchObject({
status: 403
});
});