From 4944918692976f33cbfe0376815755ca0e86c210 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Mon, 1 Jun 2026 20:06:12 +0200
Subject: [PATCH] feat(document): remove the visible Originaltext line from
 DocumentDate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

DocumentDate rendered an "Originaltext: <raw>" secondary line for
UNKNOWN/SEASON/APPROX dates, gated by a showRaw prop. Drop the visible
line, the showRaw prop, the showRawLine derived, and the now-unused
date_original_label message import. The raw prop stays — it still feeds
the SEASON word in formatDocumentDate, which only ever maps a fixed
German season token (never emits raw text), so no XSS surface remains.

Update both DocumentRow call sites to drop the now-gone showRaw={false}
and the comment that justified it. Remove the two DocumentDate tests
that asserted on the deleted DOM sink (the UNKNOWN secondary line and
its XSS-escaping); the DAY/MONTH coverage stays.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 frontend/src/lib/document/DocumentDate.svelte | 20 ++-----------------
 .../lib/document/DocumentDate.svelte.test.ts  | 15 --------------
 frontend/src/lib/document/DocumentRow.svelte  |  6 ------
 3 files changed, 2 insertions(+), 39 deletions(-)

diff --git a/frontend/src/lib/document/DocumentDate.svelte b/frontend/src/lib/document/DocumentDate.svelte
index 5b959881..8b06dbd4 100644
--- a/frontend/src/lib/document/DocumentDate.svelte
+++ b/frontend/src/lib/document/DocumentDate.svelte
@@ -1,30 +1,20 @@
 <script lang="ts">
 import { formatDocumentDate, type DatePrecision } from '$lib/shared/utils/documentDate';
 import { getLocale } from '$lib/paraglide/runtime.js';
-import { m } from '$lib/paraglide/messages.js';
 
 type Props = {
 	iso?: string | null;
 	precision?: DatePrecision | null;
 	end?: string | null;
+	/** Verbatim import cell — used only to derive the SEASON word, never displayed. */
 	raw?: string | null;
-	/** Show the verbatim "Originaltext: …" secondary line when raw is present. */
-	showRaw?: boolean;
 };
 
-let { iso = null, precision = null, end = null, raw = null, showRaw = true }: Props = $props();
+let { iso = null, precision = null, end = null, raw = null }: Props = $props();
 
 const effectivePrecision = $derived<DatePrecision>(precision ?? (iso ? 'DAY' : 'UNKNOWN'));
 const label = $derived(formatDocumentDate(iso, effectivePrecision, end, raw, getLocale()));
 const isUnknown = $derived(effectivePrecision === 'UNKNOWN' || !iso);
-// Only show the verbatim raw line where it adds information the label can't: the
-// season word's source, or the original cell behind an "unknown"/approx date.
-const showRawLine = $derived(
-	showRaw &&
-		!!raw &&
-		raw.trim().length > 0 &&
-		(isUnknown || effectivePrecision === 'SEASON' || effectivePrecision === 'APPROX')
-);
 </script>
 
 <span class="inline-flex flex-col">
@@ -61,10 +51,4 @@ const showRawLine = $derived(
 	{:else}
 		<span>{label}</span>
 	{/if}
-	{#if showRawLine}
-		<!-- Visible secondary line (WCAG 1.4.13 — not tooltip-only). raw is untrusted
-		     verbatim spreadsheet text; rendered via default Svelte interpolation, which
-		     HTML-escapes it (never {@html}; CWE-79). -->
-		<span class="font-sans text-xs text-ink-2">{m.date_original_label()} {raw}</span>
-	{/if}
 </span>
diff --git a/frontend/src/lib/document/DocumentDate.svelte.test.ts b/frontend/src/lib/document/DocumentDate.svelte.test.ts
index fa842b7b..af0b8842 100644
--- a/frontend/src/lib/document/DocumentDate.svelte.test.ts
+++ b/frontend/src/lib/document/DocumentDate.svelte.test.ts
@@ -17,19 +17,4 @@ describe('DocumentDate', () => {
 		render(DocumentDate, { props: { iso: '1916-06-01', precision: 'MONTH', raw: 'Juni 1916' } });
 		await expect.element(page.getByText('Juni 1916')).toBeInTheDocument();
 	});
-
-	it('shows the verbatim raw cell as a visible secondary line for UNKNOWN (not tooltip-only)', async () => {
-		render(DocumentDate, { props: { iso: null, precision: 'UNKNOWN', raw: 'Sommer?' } });
-		// Real, visible text — not hidden behind a title attribute.
-		await expect.element(page.getByText('Datum unbekannt')).toBeInTheDocument();
-		await expect.element(page.getByText(/Sommer\?/)).toBeVisible();
-	});
-
-	it('renders a malicious raw value as inert escaped text (no element injected)', async () => {
-		const malicious = '<img src=x onerror="alert(1)">';
-		render(DocumentDate, { props: { iso: null, precision: 'UNKNOWN', raw: malicious } });
-		// The payload appears as literal text, and no <img> is created in the DOM.
-		await expect.element(page.getByText(/<img/)).toBeInTheDocument();
-		expect(document.querySelector('img')).toBeNull();
-	});
 });
diff --git a/frontend/src/lib/document/DocumentRow.svelte b/frontend/src/lib/document/DocumentRow.svelte
index 44fcbd16..9eadd5ff 100644
--- a/frontend/src/lib/document/DocumentRow.svelte
+++ b/frontend/src/lib/document/DocumentRow.svelte
@@ -164,15 +164,10 @@ function safeTagColor(color: string | null | undefined): string {
 				<!-- Mobile-only metadata -->
 				<div class="mt-3 grid grid-cols-2 gap-x-4 gap-y-1 font-sans text-xs text-ink-2 sm:hidden">
 					<div>
-						<!-- Product decision (#666): raw provenance (meta_date_raw) is shown on the
-						     document DETAIL page, never in list/search rows — list rows surface only the
-						     honest label to keep scan-rows compact. showRaw={false} enforces this; the
-						     DocumentListItem payload also intentionally omits metaDateRaw. -->
 						<DocumentDate
 							iso={doc.documentDate}
 							precision={doc.metaDatePrecision}
 							end={doc.metaDateEnd}
-							showRaw={false}
 						/>
 					</div>
 					<div class="flex items-start gap-2">
@@ -194,7 +189,6 @@ function safeTagColor(color: string | null | undefined): string {
 						iso={doc.documentDate}
 						precision={doc.metaDatePrecision}
 						end={doc.metaDateEnd}
-						showRaw={false}
 					/>
 				</div>
 				<div>