From 507fa088fd6a8118853b152b0eaa259ae435a561 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Tue, 5 May 2026 17:35:56 +0200
Subject: [PATCH] refactor(document): move statusDotClass and statusLabel to
 document domain
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

These functions describe DocumentStatus display logic (dot colours, readable
labels) and belong in the document domain. They were incorrectly placed in
personFormat.ts. Moving them to documentStatusLabel.ts removes the
person → document dependency and prepares the codebase for the
boundaries/dependencies ESLint rule.

Refs #410
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../lib/document/DocumentStatusChip.svelte    |  8 ++-
 .../lib/document/documentStatusLabel.spec.ts  | 46 ++++++++++++++-
 .../src/lib/document/documentStatusLabel.ts   | 25 ++++++--
 frontend/src/lib/person/personFormat.spec.ts  | 57 +------------------
 frontend/src/lib/person/personFormat.ts       | 21 -------
 5 files changed, 72 insertions(+), 85 deletions(-)

diff --git a/frontend/src/lib/document/DocumentStatusChip.svelte b/frontend/src/lib/document/DocumentStatusChip.svelte
index ce4fa919..e0cc1ec7 100644
--- a/frontend/src/lib/document/DocumentStatusChip.svelte
+++ b/frontend/src/lib/document/DocumentStatusChip.svelte
@@ -1,7 +1,9 @@
 <script lang="ts">
-import { statusDotClass, statusLabel } from '$lib/person/personFormat';
-
-type DocumentStatus = 'PLACEHOLDER' | 'UPLOADED' | 'TRANSCRIBED' | 'REVIEWED' | 'ARCHIVED';
+import {
+	statusDotClass,
+	statusLabel,
+	type DocumentStatus
+} from '$lib/document/documentStatusLabel';
 
 type Props = {
 	status: DocumentStatus;
diff --git a/frontend/src/lib/document/documentStatusLabel.spec.ts b/frontend/src/lib/document/documentStatusLabel.spec.ts
index 46c5d4f6..229260d2 100644
--- a/frontend/src/lib/document/documentStatusLabel.spec.ts
+++ b/frontend/src/lib/document/documentStatusLabel.spec.ts
@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { formatDocumentStatus } from './documentStatusLabel';
+import { formatDocumentStatus, statusDotClass, statusLabel } from './documentStatusLabel';
 
 describe('formatDocumentStatus', () => {
 	it('maps PLACEHOLDER to correct label', () => {
@@ -26,3 +26,47 @@ describe('formatDocumentStatus', () => {
 		expect(formatDocumentStatus('SOMETHING_NEW')).toBe('Unbekannt');
 	});
 });
+
+describe('statusDotClass', () => {
+	it('PLACEHOLDER → bg-gray-400', () => {
+		expect(statusDotClass('PLACEHOLDER')).toBe('bg-gray-400');
+	});
+
+	it('UPLOADED → bg-emerald-500', () => {
+		expect(statusDotClass('UPLOADED')).toBe('bg-emerald-500');
+	});
+
+	it('TRANSCRIBED → bg-blue-400', () => {
+		expect(statusDotClass('TRANSCRIBED')).toBe('bg-blue-400');
+	});
+
+	it('REVIEWED → bg-amber-400', () => {
+		expect(statusDotClass('REVIEWED')).toBe('bg-amber-400');
+	});
+
+	it('ARCHIVED → bg-emerald-600', () => {
+		expect(statusDotClass('ARCHIVED')).toBe('bg-emerald-600');
+	});
+});
+
+describe('statusLabel', () => {
+	it('PLACEHOLDER → "Platzhalter"', () => {
+		expect(statusLabel('PLACEHOLDER')).toBe('Platzhalter');
+	});
+
+	it('UPLOADED → "Hochgeladen"', () => {
+		expect(statusLabel('UPLOADED')).toBe('Hochgeladen');
+	});
+
+	it('TRANSCRIBED → "Transkribiert"', () => {
+		expect(statusLabel('TRANSCRIBED')).toBe('Transkribiert');
+	});
+
+	it('REVIEWED → "Geprüft"', () => {
+		expect(statusLabel('REVIEWED')).toBe('Geprüft');
+	});
+
+	it('ARCHIVED → "Archiviert"', () => {
+		expect(statusLabel('ARCHIVED')).toBe('Archiviert');
+	});
+});
diff --git a/frontend/src/lib/document/documentStatusLabel.ts b/frontend/src/lib/document/documentStatusLabel.ts
index 715fae30..d84e4b48 100644
--- a/frontend/src/lib/document/documentStatusLabel.ts
+++ b/frontend/src/lib/document/documentStatusLabel.ts
@@ -1,9 +1,7 @@
 import { m } from '$lib/paraglide/messages.js';
 
-/**
- * Maps a document status string to a localised human-readable label.
- * Falls back to "Unknown" for unrecognised values.
- */
+export type DocumentStatus = 'PLACEHOLDER' | 'UPLOADED' | 'TRANSCRIBED' | 'REVIEWED' | 'ARCHIVED';
+
 export function formatDocumentStatus(status: string): string {
 	switch (status) {
 		case 'PLACEHOLDER':
@@ -20,3 +18,22 @@ export function formatDocumentStatus(status: string): string {
 			return m.doc_status_unknown();
 	}
 }
+
+export function statusDotClass(status: DocumentStatus): string {
+	switch (status) {
+		case 'PLACEHOLDER':
+			return 'bg-gray-400';
+		case 'UPLOADED':
+			return 'bg-emerald-500';
+		case 'TRANSCRIBED':
+			return 'bg-blue-400';
+		case 'REVIEWED':
+			return 'bg-amber-400';
+		case 'ARCHIVED':
+			return 'bg-emerald-600';
+	}
+}
+
+export function statusLabel(status: string): string {
+	return formatDocumentStatus(status);
+}
diff --git a/frontend/src/lib/person/personFormat.spec.ts b/frontend/src/lib/person/personFormat.spec.ts
index 5e727ae3..a4968b1a 100644
--- a/frontend/src/lib/person/personFormat.spec.ts
+++ b/frontend/src/lib/person/personFormat.spec.ts
@@ -1,12 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import {
-	getInitials,
-	abbreviateName,
-	formatXsMeta,
-	personAvatarColor,
-	statusDotClass,
-	statusLabel
-} from './personFormat';
+import { getInitials, abbreviateName, formatXsMeta, personAvatarColor } from './personFormat';
 import { formatDate } from '$lib/shared/utils/date';
 
 // ─── getInitials ─────────────────────────────────────────────────────────────
@@ -146,51 +139,3 @@ describe('formatDate', () => {
 		expect(formatDate('1944-01-01', 'short')).toBe('01.01.1944');
 	});
 });
-
-// ─── statusDotClass ──────────────────────────────────────────────────────────
-
-describe('statusDotClass', () => {
-	it('PLACEHOLDER → bg-gray-400', () => {
-		expect(statusDotClass('PLACEHOLDER')).toBe('bg-gray-400');
-	});
-
-	it('UPLOADED → bg-emerald-500', () => {
-		expect(statusDotClass('UPLOADED')).toBe('bg-emerald-500');
-	});
-
-	it('TRANSCRIBED → bg-blue-400', () => {
-		expect(statusDotClass('TRANSCRIBED')).toBe('bg-blue-400');
-	});
-
-	it('REVIEWED → bg-amber-400', () => {
-		expect(statusDotClass('REVIEWED')).toBe('bg-amber-400');
-	});
-
-	it('ARCHIVED → bg-emerald-600', () => {
-		expect(statusDotClass('ARCHIVED')).toBe('bg-emerald-600');
-	});
-});
-
-// ─── statusLabel ─────────────────────────────────────────────────────────────
-
-describe('statusLabel', () => {
-	it('PLACEHOLDER → "Platzhalter"', () => {
-		expect(statusLabel('PLACEHOLDER')).toBe('Platzhalter');
-	});
-
-	it('UPLOADED → "Hochgeladen"', () => {
-		expect(statusLabel('UPLOADED')).toBe('Hochgeladen');
-	});
-
-	it('TRANSCRIBED → "Transkribiert"', () => {
-		expect(statusLabel('TRANSCRIBED')).toBe('Transkribiert');
-	});
-
-	it('REVIEWED → "Geprüft"', () => {
-		expect(statusLabel('REVIEWED')).toBe('Geprüft');
-	});
-
-	it('ARCHIVED → "Archiviert"', () => {
-		expect(statusLabel('ARCHIVED')).toBe('Archiviert');
-	});
-});
diff --git a/frontend/src/lib/person/personFormat.ts b/frontend/src/lib/person/personFormat.ts
index 9a538d26..1ce32e71 100644
--- a/frontend/src/lib/person/personFormat.ts
+++ b/frontend/src/lib/person/personFormat.ts
@@ -1,8 +1,6 @@
-import { formatDocumentStatus } from '$lib/document/documentStatusLabel';
 import { formatDate } from '$lib/shared/utils/date';
 
 type Person = { firstName?: string | null; lastName: string; displayName: string };
-type DocumentStatus = 'PLACEHOLDER' | 'UPLOADED' | 'TRANSCRIBED' | 'REVIEWED' | 'ARCHIVED';
 type DocForMeta = {
 	sender?: Person | null;
 	receivers?: Person[];
@@ -75,22 +73,3 @@ export function formatXsMeta(doc: DocForMeta): string {
 export function personAvatarColor(personId: string): string {
 	return AVATAR_PALETTE[djb2(personId) % AVATAR_PALETTE.length];
 }
-
-export function statusDotClass(status: DocumentStatus): string {
-	switch (status) {
-		case 'PLACEHOLDER':
-			return 'bg-gray-400';
-		case 'UPLOADED':
-			return 'bg-emerald-500';
-		case 'TRANSCRIBED':
-			return 'bg-blue-400';
-		case 'REVIEWED':
-			return 'bg-amber-400';
-		case 'ARCHIVED':
-			return 'bg-emerald-600';
-	}
-}
-
-export function statusLabel(status: string): string {
-	return formatDocumentStatus(status);
-}