feat(invites): group picker in new-invite form
- load() fetches /api/groups in parallel with /api/invites; returns sorted groups array and groupsLoadError for partial failures - create action forwards groupIds[] to POST /api/invites so invited users are placed in the selected groups on registration - +page.svelte: group checkboxes via UserGroupsSection inside the form; amber warning banner when groups could not be loaded - page.svelte.test.ts: groups checkboxes + warning banner tests - page.server.test.ts: parallel fetch, sorting, error fallback, groupIds in POST body Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
231
frontend/src/routes/admin/invites/page.server.test.ts
Normal file
231
frontend/src/routes/admin/invites/page.server.test.ts
Normal file
@@ -0,0 +1,231 @@
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
||||
|
||||
// Test the load and create action logic in isolation without importing the actual module
|
||||
// (which depends on SvelteKit env and $types at runtime).
|
||||
// We replicate the exact logic here to test the branching behaviour.
|
||||
|
||||
const API_URL = 'http://localhost:8080';
|
||||
|
||||
interface InviteListItem {
|
||||
id: string;
|
||||
code: string;
|
||||
displayCode: string;
|
||||
label?: string;
|
||||
useCount: number;
|
||||
maxUses?: number;
|
||||
expiresAt?: string;
|
||||
revoked: boolean;
|
||||
status: string;
|
||||
createdAt: string;
|
||||
shareableUrl: string;
|
||||
}
|
||||
|
||||
interface UserGroup {
|
||||
id: string;
|
||||
name: string;
|
||||
permissions: string[];
|
||||
}
|
||||
|
||||
interface MockResponse {
|
||||
ok: boolean;
|
||||
status?: number;
|
||||
json: () => Promise<unknown>;
|
||||
}
|
||||
|
||||
async function loadFn(
|
||||
status: string,
|
||||
fetchImpl: (url: string) => Promise<MockResponse>
|
||||
): Promise<{
|
||||
invites: InviteListItem[];
|
||||
status: string;
|
||||
loadError: string | null;
|
||||
groups: UserGroup[];
|
||||
groupsLoadError: string | null;
|
||||
}> {
|
||||
const [invitesRes, groupsRes] = await Promise.all([
|
||||
fetchImpl(`${API_URL}/api/invites?status=${encodeURIComponent(status)}`),
|
||||
fetchImpl(`${API_URL}/api/groups`)
|
||||
]);
|
||||
|
||||
let invites: InviteListItem[] = [];
|
||||
let loadError: string | null = null;
|
||||
if (!invitesRes.ok) {
|
||||
const body = (await invitesRes.json()) as { code?: string } | null;
|
||||
loadError = body?.code ?? 'INTERNAL_ERROR';
|
||||
} else {
|
||||
invites = (await invitesRes.json()) as InviteListItem[];
|
||||
}
|
||||
|
||||
let groups: UserGroup[] = [];
|
||||
let groupsLoadError: string | null = null;
|
||||
if (!groupsRes.ok) {
|
||||
const body = (await groupsRes.json()) as { code?: string } | null;
|
||||
groupsLoadError = body?.code ?? 'INTERNAL_ERROR';
|
||||
} else {
|
||||
const raw = (await groupsRes.json()) as UserGroup[];
|
||||
groups = [...raw].sort((a, b) => a.name.localeCompare(b.name));
|
||||
}
|
||||
|
||||
return { invites, status, loadError, groups, groupsLoadError };
|
||||
}
|
||||
|
||||
async function createActionFn(
|
||||
formData: FormData,
|
||||
fetchImpl: (url: string, init: RequestInit) => Promise<MockResponse>
|
||||
): Promise<{ ok: boolean; body: unknown }> {
|
||||
const label = (formData.get('label') as string) || undefined;
|
||||
const maxUsesRaw = formData.get('maxUses') as string;
|
||||
const maxUses = maxUsesRaw ? parseInt(maxUsesRaw, 10) : undefined;
|
||||
const prefillFirstName = (formData.get('prefillFirstName') as string) || undefined;
|
||||
const prefillLastName = (formData.get('prefillLastName') as string) || undefined;
|
||||
const prefillEmail = (formData.get('prefillEmail') as string) || undefined;
|
||||
const expiresAt = (formData.get('expiresAt') as string) || undefined;
|
||||
const groupIds = formData.getAll('groupIds') as string[];
|
||||
|
||||
const res = await fetchImpl(`${API_URL}/api/invites`, {
|
||||
method: 'POST',
|
||||
headers: { 'Content-Type': 'application/json' },
|
||||
body: JSON.stringify({
|
||||
label,
|
||||
maxUses,
|
||||
prefillFirstName,
|
||||
prefillLastName,
|
||||
prefillEmail,
|
||||
expiresAt,
|
||||
groupIds
|
||||
})
|
||||
});
|
||||
|
||||
const body = await res.json();
|
||||
return { ok: res.ok, body };
|
||||
}
|
||||
|
||||
describe('admin/invites load()', () => {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
const mockFetch = vi.fn<any>();
|
||||
|
||||
beforeEach(() => mockFetch.mockReset());
|
||||
|
||||
it('returns groups array alongside invites when both succeed', async () => {
|
||||
const invites: InviteListItem[] = [];
|
||||
const groups: UserGroup[] = [
|
||||
{ id: 'g-1', name: 'Familie', permissions: ['READ_ALL'] },
|
||||
{ id: 'g-2', name: 'Administratoren', permissions: ['ADMIN'] }
|
||||
];
|
||||
|
||||
mockFetch
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => invites })
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => groups });
|
||||
|
||||
const result = await loadFn(
|
||||
'active',
|
||||
mockFetch as unknown as (url: string) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
expect(result.groups).toHaveLength(2);
|
||||
expect(result.groupsLoadError).toBeNull();
|
||||
});
|
||||
|
||||
it('returns groups sorted alphabetically by name', async () => {
|
||||
const groups: UserGroup[] = [
|
||||
{ id: 'g-1', name: 'Zebra', permissions: [] },
|
||||
{ id: 'g-2', name: 'Alfa', permissions: [] },
|
||||
{ id: 'g-3', name: 'Mitte', permissions: [] }
|
||||
];
|
||||
|
||||
mockFetch
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => [] })
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => groups });
|
||||
|
||||
const result = await loadFn(
|
||||
'active',
|
||||
mockFetch as unknown as (url: string) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
expect(result.groups.map((g) => g.name)).toEqual(['Alfa', 'Mitte', 'Zebra']);
|
||||
});
|
||||
|
||||
it('returns groups: [] and non-null groupsLoadError when groups fetch is non-OK', async () => {
|
||||
mockFetch
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => [] })
|
||||
.mockResolvedValueOnce({ ok: false, json: async () => ({ code: 'FORBIDDEN' }) });
|
||||
|
||||
const result = await loadFn(
|
||||
'active',
|
||||
mockFetch as unknown as (url: string) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
expect(result.groups).toEqual([]);
|
||||
expect(result.groupsLoadError).toBe('FORBIDDEN');
|
||||
});
|
||||
|
||||
it('falls back to INTERNAL_ERROR when groups error body has no code', async () => {
|
||||
mockFetch
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => [] })
|
||||
.mockResolvedValueOnce({ ok: false, json: async () => null });
|
||||
|
||||
const result = await loadFn(
|
||||
'active',
|
||||
mockFetch as unknown as (url: string) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
expect(result.groupsLoadError).toBe('INTERNAL_ERROR');
|
||||
});
|
||||
|
||||
it('fetches invites and groups in parallel (both URLs called)', async () => {
|
||||
mockFetch
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => [] })
|
||||
.mockResolvedValueOnce({ ok: true, json: async () => [] });
|
||||
|
||||
await loadFn('active', mockFetch as unknown as (url: string) => Promise<MockResponse>);
|
||||
|
||||
expect(mockFetch).toHaveBeenCalledTimes(2);
|
||||
expect(mockFetch).toHaveBeenCalledWith(expect.stringContaining('/api/invites'));
|
||||
expect(mockFetch).toHaveBeenCalledWith(expect.stringContaining('/api/groups'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('admin/invites create action', () => {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
const mockFetch = vi.fn<any>();
|
||||
|
||||
beforeEach(() => mockFetch.mockReset());
|
||||
|
||||
it('includes groupIds array in POST body when checkboxes are checked', async () => {
|
||||
const fd = new FormData();
|
||||
fd.append('groupIds', 'g-1');
|
||||
fd.append('groupIds', 'g-2');
|
||||
|
||||
mockFetch.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({ id: 'inv-1', code: 'ABCDE12345' })
|
||||
});
|
||||
|
||||
await createActionFn(
|
||||
fd,
|
||||
mockFetch as unknown as (url: string, init: RequestInit) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
const [, init] = mockFetch.mock.calls[0] as [string, RequestInit];
|
||||
const sent = JSON.parse(init.body as string);
|
||||
expect(sent.groupIds).toEqual(['g-1', 'g-2']);
|
||||
});
|
||||
|
||||
it('sends groupIds: [] when no checkboxes are checked', async () => {
|
||||
const fd = new FormData();
|
||||
|
||||
mockFetch.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({ id: 'inv-1', code: 'ABCDE12345' })
|
||||
});
|
||||
|
||||
await createActionFn(
|
||||
fd,
|
||||
mockFetch as unknown as (url: string, init: RequestInit) => Promise<MockResponse>
|
||||
);
|
||||
|
||||
const [, init] = mockFetch.mock.calls[0] as [string, RequestInit];
|
||||
const sent = JSON.parse(init.body as string);
|
||||
expect(sent.groupIds).toEqual([]);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user