fix(#145): address PR review — full-table scan, a11y, grid, tests

- DocumentService.getRecentActivity: replace findAll(Sort)+stream().limit()
  with findAll(PageRequest) so LIMIT is pushed to the database
- +page.svelte: collapse two-column grid to single column when mentions is empty
- DashboardNeedsMetadata: raise "show all" link from text-xs (12px) to text-sm
  (14px) and add hover:underline for WCAG 1.4.1
- DashboardRecentDocuments: add comment explaining why T12:00:00 noon-anchor
  is absent (updatedAt is a full ISO datetime, not a date-only string)
- DocumentServiceTest: update getRecentActivity tests to assert PageRequest
  usage instead of findAll(Sort)
- DocumentRepositoryTest: add @DataJpaTest verifying findAll(PageRequest)
  returns only size rows, not the full table
- DocumentControllerTest: add test for default size=5 when param is omitted
- NotificationServiceTest: add test documenting that type+read=true falls
  through to the type-only query (intentional)
- page.server.spec.ts: replace stale tests with full dashboard-mode coverage
- DashboardMentions.svelte.spec.ts: add tests for REPLY type and absent documentId
- DashboardResumeStrip.svelte.spec.ts: add corrupt localStorage test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

frontend/src/lib/components/DashboardMentions.svelte.spec.ts

@@ -65,4 +65,21 @@ describe('DashboardMentions', () => {
 		render(DashboardMentions, { mentions: [makeMention({ actorName: 'Maria Müller' })] });
 		await expect.element(page.getByText('Maria Müller')).toBeInTheDocument();
 	});
+
+	it('shows "replied" label for REPLY type', async () => {
+		render(DashboardMentions, { mentions: [makeMention({ type: 'REPLY' })] });
+		const widget = page.getByTestId('dashboard-mentions');
+		await expect.element(widget).toBeInTheDocument();
+		const link = page.getByRole('link');
+		await expect.element(link).toBeInTheDocument();
+	});
+
+	it('renders a span instead of a link when documentId is absent', async () => {
+		render(DashboardMentions, {
+			mentions: [makeMention({ documentId: undefined, actorName: 'Lena Bauer' })]
+		});
+		await expect.element(page.getByText('Lena Bauer')).toBeInTheDocument();
+		const links = page.getByRole('link');
+		await expect.element(links).not.toBeInTheDocument();
+	});
 });

frontend/src/lib/components/DashboardNeedsMetadata.svelte

@@ -29,7 +29,7 @@ let { incompleteDocs }: Props = $props();
 			</div>
 		{/each}
 		<div class="mt-4">
-			<a href="/enrich" class="font-sans text-xs text-ink-2 hover:text-ink"
+			<a href="/enrich" class="font-sans text-sm text-ink-2 hover:text-ink hover:underline"
 				>{m.dashboard_needs_metadata_show_all()}</a
 			>
 		</div>

frontend/src/lib/components/DashboardRecentDocuments.svelte

@@ -16,6 +16,7 @@ interface Props {
 let { recentDocs }: Props = $props();
 
 function formatDate(dateStr: string): string {
+	// updatedAt is a full ISO datetime — no T12:00:00 noon-anchor needed here
 	return new Intl.DateTimeFormat(getLocale(), {
 		day: 'numeric',
 		month: 'long',

frontend/src/lib/components/DashboardResumeStrip.svelte.spec.ts

@@ -40,4 +40,11 @@ describe('DashboardResumeStrip', () => {
 		const link = page.getByRole('link');
 		await expect.element(link).toHaveAttribute('href', '/documents/doc-456');
 	});
+
+	it('renders nothing when localStorage contains malformed JSON', async () => {
+		localStorage.setItem('familienarchiv.lastVisited', '{not valid json');
+		render(DashboardResumeStrip, {});
+		const strip = page.getByTestId('resume-strip');
+		await expect.element(strip).not.toBeInTheDocument();
+	});
 });

frontend/src/routes/+page.svelte

@@ -100,7 +100,7 @@ $effect(() => {
 			</div>
 		{/if}
 
-		<div class="mt-6 grid gap-4 lg:grid-cols-2">
+		<div class="mt-6 grid gap-4 {(data.mentions?.length ?? 0) > 0 ? 'lg:grid-cols-2' : ''}">
 			<DashboardMentions mentions={data.mentions ?? []} />
 			<DashboardNeedsMetadata incompleteDocs={data.incompleteDocs ?? []} />
 		</div>

frontend/src/routes/page.server.spec.ts

@@ -19,40 +19,115 @@ function makeUrl(params: Record<string, string | string[]> = {}) {
 	return url;
 }
 
-// ─── happy path ───────────────────────────────────────────────────────────────
+// ─── dashboard mode (no search filters) ──────────────────────────────────────
 
-describe('home page load — happy path', () => {
-	it('returns documents and persons on success', async () => {
-		vi.mocked(createApiClient).mockReturnValue({
-			GET: vi
-				.fn()
-				.mockResolvedValueOnce({
-					response: { ok: true, status: 200 },
-					data: [{ id: 'd1', title: 'Brief' }]
-				})
-				.mockResolvedValueOnce({
-					response: { ok: true, status: 200 },
-					data: [{ id: 'p1', firstName: 'Hans', lastName: 'Müller' }]
-				})
-				.mockResolvedValueOnce({ response: { ok: true }, data: { count: 3 } })
-		} as ReturnType<typeof createApiClient>);
+describe('home page load — dashboard mode', () => {
+	it('sets isDashboard true and fetches all three widget APIs', async () => {
+		const mockGet = vi
+			.fn()
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) // persons
+			.mockResolvedValueOnce({
+				response: { ok: true },
+				data: { content: [{ id: 'n1' }] }
+			}) // notifications
+			.mockResolvedValueOnce({ response: { ok: true }, data: [{ id: 'd1' }] }) // incomplete
+			.mockResolvedValueOnce({ response: { ok: true }, data: [{ id: 'd2' }] }); // recent
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
 
 		const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch });
 
-		expect(result.documents).toHaveLength(1);
-		expect(result.incompleteCount).toBe(3);
-		expect(result.error).toBeNull();
+		expect(result.isDashboard).toBe(true);
+		expect(result.mentions).toHaveLength(1);
+		expect(result.incompleteDocs).toHaveLength(1);
+		expect(result.recentDocs).toHaveLength(1);
+		expect(result.documents).toEqual([]);
 	});
 
-	it('passes search params from the URL to the API', async () => {
+	it('defaults mentions to [] when notifications API rejects', async () => {
+		const mockGet = vi
+			.fn()
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) // persons
+			.mockRejectedValueOnce(new Error('network')) // notifications
+			.mockResolvedValueOnce({ response: { ok: true }, data: [] }) // incomplete
+			.mockResolvedValueOnce({ response: { ok: true }, data: [] }); // recent
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
+
+		const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch });
+
+		expect(result.mentions).toEqual([]);
+	});
+
+	it('defaults incompleteDocs to [] when incomplete API rejects', async () => {
+		const mockGet = vi
+			.fn()
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) // persons
+			.mockResolvedValueOnce({ response: { ok: true }, data: { content: [] } }) // notifications
+			.mockRejectedValueOnce(new Error('network')) // incomplete
+			.mockResolvedValueOnce({ response: { ok: true }, data: [] }); // recent
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
+
+		const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch });
+
+		expect(result.incompleteDocs).toEqual([]);
+	});
+
+	it('defaults recentDocs to [] when recent-activity API rejects', async () => {
+		const mockGet = vi
+			.fn()
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }) // persons
+			.mockResolvedValueOnce({ response: { ok: true }, data: { content: [] } }) // notifications
+			.mockResolvedValueOnce({ response: { ok: true }, data: [] }) // incomplete
+			.mockRejectedValueOnce(new Error('network')); // recent
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
+
+		const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch });
+
+		expect(result.recentDocs).toEqual([]);
+	});
+});
+
+// ─── search mode (any filter active) ─────────────────────────────────────────
+
+describe('home page load — search mode', () => {
+	it('sets isDashboard false and skips widget APIs when q is set', async () => {
+		const mockGet = vi
+			.fn()
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [{ id: 'd1' }] }) // search docs
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] }); // persons
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
+
+		const result = await load({
+			url: makeUrl({ q: 'Urlaub' }),
+			fetch: vi.fn() as unknown as typeof fetch
+		});
+
+		expect(result.isDashboard).toBe(false);
+		expect(result.documents).toHaveLength(1);
+		expect(result.mentions).toEqual([]);
+		expect(result.incompleteDocs).toEqual([]);
+		expect(result.recentDocs).toEqual([]);
+		// Only two API calls — no widget calls
+		expect(mockGet).toHaveBeenCalledTimes(2);
+	});
+
+	it('passes search params from the URL to the documents API', async () => {
 		const mockGet = vi
 			.fn()
 			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-			.mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } });
-		vi.mocked(createApiClient).mockReturnValue({
-			GET: mockGet
-		} as ReturnType<typeof createApiClient>);
+			.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] });
+		vi.mocked(createApiClient).mockReturnValue({ GET: mockGet } as ReturnType<
+			typeof createApiClient
+		>);
 
 		await load({
 			url: makeUrl({ q: 'Urlaub', from: '2020-01-01' }),
@@ -63,46 +138,14 @@ describe('home page load — happy path', () => {
 		expect(firstCall[1].params.query.q).toBe('Urlaub');
 		expect(firstCall[1].params.query.from).toBe('2020-01-01');
 	});
-
-	it('returns incompleteCount 0 when the incomplete-count API fails', async () => {
-		vi.mocked(createApiClient).mockReturnValue({
-			GET: vi
-				.fn()
-				.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-				.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-				.mockResolvedValueOnce({ response: { ok: false }, data: null })
-		} as ReturnType<typeof createApiClient>);
-
-		const result = await load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch });
-
-		expect(result.incompleteCount).toBe(0);
-	});
 });
 
 // ─── 401 redirect ─────────────────────────────────────────────────────────────
 
 describe('home page load — auth redirect', () => {
-	it('redirects to /login when documents API returns 401', async () => {
-		vi.mocked(createApiClient).mockReturnValue({
-			GET: vi
-				.fn()
-				.mockResolvedValueOnce({ response: { ok: false, status: 401 }, data: null })
-				.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-				.mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } })
-		} as ReturnType<typeof createApiClient>);
-
-		await expect(
-			load({ url: makeUrl(), fetch: vi.fn() as unknown as typeof fetch })
-		).rejects.toMatchObject({ location: '/login' });
-	});
-
 	it('redirects to /login when persons API returns 401', async () => {
 		vi.mocked(createApiClient).mockReturnValue({
-			GET: vi
-				.fn()
-				.mockResolvedValueOnce({ response: { ok: true, status: 200 }, data: [] })
-				.mockResolvedValueOnce({ response: { ok: false, status: 401 }, data: null })
-				.mockResolvedValueOnce({ response: { ok: true }, data: { count: 0 } })
+			GET: vi.fn().mockResolvedValueOnce({ response: { ok: false, status: 401 }, data: null })
 		} as ReturnType<typeof createApiClient>);
 
 		await expect(
@@ -123,6 +166,5 @@ describe('home page load — network error fallback', () => {
 
 		expect(result.error).toBe('Daten konnten nicht geladen werden.');
 		expect(result.documents).toEqual([]);
-		expect(result.incompleteCount).toBe(0);
 	});
 });