marcel/familienarchiv
1
0
Fork 0
Code Issues 114 Pull Requests 3 Actions 3 Packages Projects Releases Wiki Activity

feat(#248): enrich TagTreeNodeDTO with parentId and populate documentCount via single aggregate query

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-16 22:24:50 +02:00
parent c03c391879
commit 609d242f5d
4 changed files with 61 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backend/src/test/java/org/raddatz/familienarchiv/controller/TagControllerTest.java
View File

@@ -96,8 +96,8 @@ class TagControllerTest {
void getTagTree_returns200_withTreeStructure() throws Exception {
UUID parentId = UUID.randomUUID();
UUID childId = UUID.randomUUID();
TagTreeNodeDTO child = new TagTreeNodeDTO(childId, "Haus", null, 0, List.of());
TagTreeNodeDTO parent = new TagTreeNodeDTO(parentId, "Immobilie", "teal", 0, List.of(child));
TagTreeNodeDTO child = new TagTreeNodeDTO(childId, "Haus", null, 0, List.of(), parentId);
TagTreeNodeDTO parent = new TagTreeNodeDTO(parentId, "Immobilie", "teal", 0, List.of(child), null);
when(tagService.getTagTree()).thenReturn(List.of(parent));
mockMvc.perform(get("/api/tags/tree"))

41
backend/src/test/java/org/raddatz/familienarchiv/service/TagServiceTest.java
View File

@@ -197,6 +197,7 @@ class TagServiceTest {
@Test
void getTagTree_returnsEmptyList_whenNoTags() {
when(tagRepository.findAll()).thenReturn(List.of());
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
assertThat(tagService.getTagTree()).isEmpty();
}
@@ -210,6 +211,7 @@ class TagServiceTest {
Tag.builder().id(idB).name("Beta").build()
);
when(tagRepository.findAll()).thenReturn(tags);
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
var tree = tagService.getTagTree();
@@ -224,6 +226,7 @@ class TagServiceTest {
Tag parent = Tag.builder().id(parentId).name("Parent").build();
Tag child = Tag.builder().id(childId).name("Child").parentId(parentId).build();
when(tagRepository.findAll()).thenReturn(List.of(parent, child));
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
var tree = tagService.getTagTree();
@@ -233,6 +236,44 @@ class TagServiceTest {
assertThat(tree.get(0).children().get(0).id()).isEqualTo(childId);
}
// ─── getTagTree (enriched) ────────────────────────────────────────────────
@Test
void getTagTree_populatesParentId_onChildNode() {
UUID parentId = UUID.randomUUID();
UUID childId = UUID.randomUUID();
Tag parent = Tag.builder().id(parentId).name("Parent").build();
Tag child = Tag.builder().id(childId).name("Child").parentId(parentId).build();
when(tagRepository.findAll()).thenReturn(List.of(parent, child));
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
var tree = tagService.getTagTree();
assertThat(tree.get(0).children().get(0).parentId()).isEqualTo(parentId);
}
@Test
void getTagTree_populatesDocumentCount_fromAggregateQuery() {
UUID tagId = UUID.randomUUID();
Tag tag = Tag.builder().id(tagId).name("Tag").build();
when(tagRepository.findAll()).thenReturn(List.of(tag));
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.<Object[]>of(new Object[]{tagId, 5L}));
var tree = tagService.getTagTree();
assertThat(tree.get(0).documentCount()).isEqualTo(5);
}
@Test
void getTagTree_callsFindDocumentCountsPerTag_exactlyOnce() {
when(tagRepository.findAll()).thenReturn(List.of());
when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
tagService.getTagTree();
verify(tagRepository, times(1)).findDocumentCountsPerTag();
}
// ─── resolveEffectiveColors ───────────────────────────────────────────────
@Test