marcel/familienarchiv
1
0
Fork 0
Code Issues 121 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

refactor(journey-editor): fix fragile ordering assertion with compareDocumentPosition

Browse Source 
The previous check used document.body.textContent which includes ARIA labels
and hidden elements — a match in those could misfire the indexOf comparison.
compareDocumentPosition(DOCUMENT_POSITION_FOLLOWING) checks DOM tree position
directly and is not affected by non-visible text.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-06-09 16:46:06 +02:00
parent afe7e5586a
commit 65e196292e
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/lib/geschichte/JourneyEditor.svelte.spec.ts
View File

@@ -70,11 +70,10 @@ describe('JourneyEditor — items in position order', () => {
]; ];
render(JourneyEditor, defaultProps({ geschichte: makeGeschichte({ items }) })); render(JourneyEditor, defaultProps({ geschichte: makeGeschichte({ items }) }));
const titles = await page.getByText(/Brief [AB]/).all(); // Brief A (position 0) must appear before Brief B (position 1) in DOM order
expect(titles.length).toBeGreaterThanOrEqual(2); const briefA = page.getByText('Brief A').element();
// Brief A should appear before Brief B (position 0 first) const briefB = page.getByText('Brief B').element();
const textContent = document.body.textContent ?? ''; expect(briefA.compareDocumentPosition(briefB) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
expect(textContent.indexOf('Brief A')).toBeLessThan(textContent.indexOf('Brief B'));
}); });
}); });