From 6ac3f6b1764c57de726387b32e93735869c7fe11 Mon Sep 17 00:00:00 2001 From: Marcel Date: Mon, 6 Apr 2026 16:31:39 +0200 Subject: [PATCH] refactor(search): remove dead SENDER case from resolveSort switch SENDER and RECEIVER are handled by in-memory sort before resolveSort is called, making those switch cases unreachable. Removed and added a comment making the invariant explicit. Co-Authored-By: Claude Sonnet 4.6 --- .../org/raddatz/familienarchiv/service/DocumentService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java b/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java index e0fde44b..4146f4a9 100644 --- a/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java +++ b/backend/src/main/java/org/raddatz/familienarchiv/service/DocumentService.java @@ -308,9 +308,9 @@ public class DocumentService { if (sort == null || sort == DocumentSort.DATE) { return Sort.by(direction, "documentDate"); } + // SENDER and RECEIVER are sorted in-memory before this method is called return switch (sort) { case TITLE -> Sort.by(direction, "title"); - case SENDER -> Sort.by(direction, "sender.lastName").and(Sort.by(direction, "sender.firstName")); case UPLOAD_DATE -> Sort.by(direction, "createdAt"); default -> Sort.by(direction, "documentDate"); };