From 6c2da648dbb563132a28066d715e25db7932e7f3 Mon Sep 17 00:00:00 2001 From: Marcel Date: Thu, 16 Apr 2026 13:12:46 +0200 Subject: [PATCH] fix(#240): remove weekly pulse badge from ReadyColumn MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The weekly count in Lesefertig counted any document with a reviewed block in the past 7 days, not documents that crossed the ≥90% ready threshold — a misleading stat given the column shows a different set. Co-Authored-By: Claude Sonnet 4.6 --- frontend/src/lib/components/MissionControlStrip.svelte | 2 +- frontend/src/lib/components/ReadyColumn.svelte | 10 ++-------- frontend/src/lib/components/ReadyColumn.svelte.spec.ts | 8 ++++---- 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/frontend/src/lib/components/MissionControlStrip.svelte b/frontend/src/lib/components/MissionControlStrip.svelte index 0601faf5..2a026877 100644 --- a/frontend/src/lib/components/MissionControlStrip.svelte +++ b/frontend/src/lib/components/MissionControlStrip.svelte @@ -28,6 +28,6 @@ let { segmentationDocs, transcriptionDocs, readyDocs, weeklyStats }: Props = $pr docs={transcriptionDocs} weeklyCount={weeklyStats?.transcriptionCount ?? 0} /> - + diff --git a/frontend/src/lib/components/ReadyColumn.svelte b/frontend/src/lib/components/ReadyColumn.svelte index 217e3ca9..20fc91d4 100644 --- a/frontend/src/lib/components/ReadyColumn.svelte +++ b/frontend/src/lib/components/ReadyColumn.svelte @@ -8,10 +8,9 @@ type TranscriptionQueueItemDTO = components['schemas']['TranscriptionQueueItemDT interface Props { docs: TranscriptionQueueItemDTO[]; - weeklyCount: number; } -let { docs, weeklyCount }: Props = $props(); +let { docs }: Props = $props(); function reviewedPct(doc: TranscriptionQueueItemDTO): number { if (doc.annotationCount === 0) return 0; @@ -24,15 +23,10 @@ function reviewedPct(doc: TranscriptionQueueItemDTO): number { class="flex flex-col gap-3 rounded-sm border border-brand-mint bg-brand-mint/10 p-4 transition-shadow hover:shadow-sm" >
-
+

{m.mission_control_ready_heading()}

- {#if weeklyCount > 0} - - {m.mission_control_weekly_pulse({ count: weeklyCount })} - - {/if}

{m.mission_control_ready_subtitle({ count: docs.length })} diff --git a/frontend/src/lib/components/ReadyColumn.svelte.spec.ts b/frontend/src/lib/components/ReadyColumn.svelte.spec.ts index 02d456a9..1674e44a 100644 --- a/frontend/src/lib/components/ReadyColumn.svelte.spec.ts +++ b/frontend/src/lib/components/ReadyColumn.svelte.spec.ts @@ -24,7 +24,7 @@ describe('ReadyColumn', () => { const doc1 = makeDoc({ id: 'doc-1', title: 'Leseферtig Brief' }); const doc2 = makeDoc({ id: 'doc-2', title: 'Archiv Dokument' }); - render(ReadyColumn, { props: { docs: [doc1, doc2], weeklyCount: 0 } }); + render(ReadyColumn, { props: { docs: [doc1, doc2] } }); await expect.element(page.getByText('Leseферtig Brief')).toBeInTheDocument(); await expect.element(page.getByText('Archiv Dokument')).toBeInTheDocument(); @@ -35,7 +35,7 @@ describe('ReadyColumn', () => { }); it('renders dashed empty state with CTA link when docs array is empty', async () => { - render(ReadyColumn, { props: { docs: [], weeklyCount: 0 } }); + render(ReadyColumn, { props: { docs: [] } }); await expect .element(page.getByText('Noch keine Dokumente vollständig transkribiert.')) @@ -59,7 +59,7 @@ describe('ReadyColumn', () => { textedBlockCount: 2 }); - render(ReadyColumn, { props: { docs: [doc], weeklyCount: 0 } }); + render(ReadyColumn, { props: { docs: [doc] } }); // Should show 100% (using annotationCount=4 as denominator) await expect.element(page.getByText('100% geprüft')).toBeInTheDocument(); @@ -68,7 +68,7 @@ describe('ReadyColumn', () => { it('links to /documents/{id}', async () => { const doc = makeDoc({ id: 'ready-789', title: 'Fertiges Dokument' }); - render(ReadyColumn, { props: { docs: [doc], weeklyCount: 0 } }); + render(ReadyColumn, { props: { docs: [doc] } }); const link = page.getByRole('link', { name: /Fertiges Dokument/ }); await expect.element(link).toHaveAttribute('href', '/documents/ready-789');