marcel/familienarchiv
1
0
Fork 0
Code Issues 120 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(persons): key the unconfirmed badge off provisional only

Browse Source 
Align PersonCard's "unbestätigt" badge with the authoritative provisional
flag so the badge, the "Zu prüfen (N)" count and the /persons/review triage
list can never disagree. Empty/"?" name handling is now a separate
crash-safety concern: it still routes to the neutral placeholder glyph
(never a "?" initial) but no longer implies a badge on its own.

Refs #667

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-27 14:10:16 +02:00
parent 300b236d7d
commit 79e9cc5a2b
2 changed files with 43 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
frontend/src/lib/person/PersonCard.svelte
View File

@@ -8,27 +8,26 @@ type Person = components['schemas']['PersonSummaryDTO'];
let { person }: { person: Person } = $props();
// A card is "unconfirmed" when the importer could not identify the person: the explicit
// provisional flag, the placeholder UNKNOWN type, or a literal "?" name from the spreadsheet.
const isUnconfirmed = $derived(
person.provisional === true ||
person.personType === 'UNKNOWN' ||
person.lastName === '?' ||
(person.lastName ?? '').trim() === ''
);
// "Unconfirmed" is exactly the `provisional` flag — the authoritative signal the importer
// sets and the triage flow clears. The badge, the "Zu prüfen (N)" count and the
// /persons/review list all key off this same flag, so badge ⇔ count ⇔ triage can never drift.
const isUnconfirmed = $derived(person.provisional === true);
// A non-PERSON type (institution/group) gets a glyph; everything that is a real, confirmed
// person gets initials. Unconfirmed persons never get a "?" initial — they get the neutral
// placeholder glyph instead. Reading lastName[0] on a null/empty name would throw, so the
// initials branch is gated on a non-empty name.
// An empty / "?" last name is a separate, purely defensive concern: it must not crash the
// initials branch (reading lastName[0] on null throws) and must never render a "?" initial.
// It implies the placeholder glyph but — on its own — no "unbestätigt" badge.
const hasNoName = $derived(person.lastName == null || person.lastName.trim() === '' || person.lastName === '?');
// A non-PERSON type (institution/group) gets a typed glyph; a confirmed, named person gets
// initials. Provisional entries and nameless entries fall back to the neutral placeholder glyph.
const showGlyph = $derived(
isUnconfirmed || (person.personType != null && person.personType !== 'PERSON')
isUnconfirmed || hasNoName || (person.personType != null && person.personType !== 'PERSON')
);
const initials = $derived.by(() => {
const first = person.firstName?.[0] ?? '';
const last = person.lastName?.[0] ?? '';
return (first || last) + last;
return first ? first + last : last;
});
const documentCount = $derived(person.documentCount ?? 0);
@@ -43,7 +42,7 @@ const documentCount = $derived(person.documentCount ?? 0);
<div
class={[
'flex h-12 w-12 flex-shrink-0 items-center justify-center rounded-full font-serif text-base font-bold transition-colors',
isUnconfirmed ? 'bg-muted text-ink-2' : 'bg-primary text-primary-fg'
isUnconfirmed || hasNoName ? 'bg-muted text-ink-2' : 'bg-primary text-primary-fg'
]}
>
{#if showGlyph}
@@ -98,7 +97,6 @@ const documentCount = $derived(person.documentCount ?? 0);
<!-- State conveyed by text + the muted placeholder shape, never colour alone (WCAG 1.4.1). -->
<span
class="inline-flex items-center gap-1 rounded-full border border-line bg-muted px-2.5 py-0.5 font-sans text-xs font-semibold text-ink-2"
aria-label={m.person_badge_unconfirmed()}
>
<svg
class="h-3 w-3"