From 7ccd541d403749d1dd515d17dab294859f736c48 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Wed, 29 Apr 2026 19:22:37 +0200
Subject: [PATCH] fix(hover-card): use orientation-aware relationship labels;
 allow spaces in mention
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PersonHoverCard was showing the hovered person as their own parent when stored
as the object side of a PARENT_OF row — now uses chipLabel/otherName from
relationshipLabels (same helpers the person detail page uses) to resolve the
correct name and label from the caller's perspective.

PersonMentionEditor: add allowSpaces:true so typing a last name after a space
no longer exits mention mode mid-query.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../src/lib/components/PersonHoverCard.svelte | 18 +++----------
 .../components/PersonHoverCard.svelte.spec.ts | 25 +++++++++++++++++++
 .../lib/components/PersonMentionEditor.svelte |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)

diff --git a/frontend/src/lib/components/PersonHoverCard.svelte b/frontend/src/lib/components/PersonHoverCard.svelte
index 41dcc428..f828702e 100644
--- a/frontend/src/lib/components/PersonHoverCard.svelte
+++ b/frontend/src/lib/components/PersonHoverCard.svelte
@@ -1,6 +1,7 @@
 <script lang="ts">
 import { m } from '$lib/paraglide/messages.js';
 import { formatLifeDateRange } from '$lib/utils/personLifeDates';
+import { chipLabel, otherName } from '$lib/relationshipLabels';
 import type { components } from '$lib/generated/api';
 import type { LoadState } from '$lib/types/personHoverCard';
 
@@ -22,19 +23,6 @@ const FAMILY_REL_TYPES: ReadonlySet<RelationshipDTO['relationType']> = new Set([
 	'SPOUSE_OF',
 	'SIBLING_OF'
 ]);
-
-function relationLabel(type: RelationshipDTO['relationType']): string {
-	switch (type) {
-		case 'PARENT_OF':
-			return m.relation_parent_of();
-		case 'SPOUSE_OF':
-			return m.relation_spouse_of();
-		case 'SIBLING_OF':
-			return m.relation_sibling_of();
-		default:
-			return m.relation_other();
-	}
-}
 const NOTES_MAX = 120;
 
 const familyChips = $derived(
@@ -136,8 +124,8 @@ const ariaBusy = $derived(state.status === 'loading');
 				<div class="chips" data-testid="person-hover-card-chips">
 					{#each familyChips as chip (chip.id)}
 						<span class="chip">
-							<span class="chip-type">{relationLabel(chip.relationType)}</span>
-							{chip.relatedPersonDisplayName}
+							<span class="chip-type">{chipLabel(chip, personId)}</span>
+							{otherName(chip, personId)}
 						</span>
 					{/each}
 				</div>
diff --git a/frontend/src/lib/components/PersonHoverCard.svelte.spec.ts b/frontend/src/lib/components/PersonHoverCard.svelte.spec.ts
index f68bfdfc..a5a942a3 100644
--- a/frontend/src/lib/components/PersonHoverCard.svelte.spec.ts
+++ b/frontend/src/lib/components/PersonHoverCard.svelte.spec.ts
@@ -165,6 +165,31 @@ describe('PersonHoverCard — loaded state', () => {
 		await expect.element(friendChip).not.toBeInTheDocument();
 	});
 
+	it('shows the other person name when hovered person is the object (relatedPersonId) in a PARENT_OF row', async () => {
+		// Storage: Heinrich PARENT_OF Auguste. When viewing Auguste's card,
+		// the chip must show "Heinrich" (the parent), not "Auguste" (herself).
+		const relationships: RelationshipDTO[] = [
+			{
+				id: 'r-parent',
+				personId: 'p-heinrich',
+				relatedPersonId: 'p-aug',
+				personDisplayName: 'Heinrich Raddatz',
+				relatedPersonDisplayName: 'Auguste Raddatz',
+				relationType: 'PARENT_OF'
+			}
+		];
+		render(PersonHoverCard, {
+			personId: 'p-aug',
+			cardId: 'card-1',
+			position: POSITION,
+			state: { status: 'loaded', person: AUGUSTE, relationships }
+		});
+		await expect.element(page.getByText('Heinrich Raddatz')).toBeInTheDocument();
+		// Auguste must NOT appear as her own parent chip name
+		const chips = document.querySelector('[data-testid="person-hover-card-chips"]');
+		expect(chips?.textContent).not.toContain('Auguste Raddatz');
+	});
+
 	it('omits the chips section entirely when no family relationships', async () => {
 		const onlyFriend: RelationshipDTO[] = [
 			{
diff --git a/frontend/src/lib/components/PersonMentionEditor.svelte b/frontend/src/lib/components/PersonMentionEditor.svelte
index 52bd9b98..58a2e9c6 100644
--- a/frontend/src/lib/components/PersonMentionEditor.svelte
+++ b/frontend/src/lib/components/PersonMentionEditor.svelte
@@ -123,6 +123,7 @@ onMount(() => {
 				},
 				suggestion: {
 					char: '@',
+					allowSpaces: true,
 					// ─────────────────────────────────────────────────────────────
 					// EXCEPTION to frontend/CLAUDE.md "no client-side API fetch":
 					// Tiptap's suggestion plugin lives entirely on the client and