From 8be876492cd71983b2c83bedf21c25a72c369285 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Wed, 15 Apr 2026 13:10:44 +0200
Subject: [PATCH] refactor(date): consolidate formatDate in date.ts with
 optional format param

Add format?: 'short'|'long' (default 'long') to date.ts formatDate and
remove the duplicate from personFormat.ts. Update DocumentTopBar to
import from date.ts directly. Move the formatDate tests from
personFormat.spec to date.spec.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../src/lib/components/DocumentTopBar.svelte  |  2 +-
 frontend/src/lib/utils/date.spec.ts           | 22 ++++++++++++++++++-
 frontend/src/lib/utils/date.ts                | 13 +++++++++--
 frontend/src/lib/utils/personFormat.spec.ts   |  2 +-
 frontend/src/lib/utils/personFormat.ts        | 17 +-------------
 5 files changed, 35 insertions(+), 21 deletions(-)

diff --git a/frontend/src/lib/components/DocumentTopBar.svelte b/frontend/src/lib/components/DocumentTopBar.svelte
index c7604e7c..995077a4 100644
--- a/frontend/src/lib/components/DocumentTopBar.svelte
+++ b/frontend/src/lib/components/DocumentTopBar.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
 import { m } from '$lib/paraglide/messages.js';
 import { slide } from 'svelte/transition';
-import { formatDate } from '$lib/utils/personFormat';
+import { formatDate } from '$lib/utils/date';
 import { clickOutside } from '$lib/actions/clickOutside';
 import PersonChipRow from './PersonChipRow.svelte';
 import OverflowPillButton from './OverflowPillButton.svelte';
diff --git a/frontend/src/lib/utils/date.spec.ts b/frontend/src/lib/utils/date.spec.ts
index 27344f96..04d6b151 100644
--- a/frontend/src/lib/utils/date.spec.ts
+++ b/frontend/src/lib/utils/date.spec.ts
@@ -1,5 +1,25 @@
 import { describe, expect, it } from 'vitest';
-import { formatGermanDateInput, isoToGerman, germanToIso } from './date';
+import { formatDate, formatGermanDateInput, isoToGerman, germanToIso } from './date';
+
+// ─── formatDate ──────────────────────────────────────────────────────────────
+
+describe('formatDate', () => {
+	it('defaults to long format when no format arg is passed', () => {
+		expect(formatDate('1943-12-24')).toBe('24. Dezember 1943');
+	});
+
+	it('formats long date with German month name', () => {
+		expect(formatDate('1943-12-24', 'long')).toBe('24. Dezember 1943');
+	});
+
+	it('formats short date as dd.mm.yyyy', () => {
+		expect(formatDate('1943-12-24', 'short')).toBe('24.12.1943');
+	});
+
+	it('does not shift Dec 31 to Jan 1 (T12:00:00 UTC guard)', () => {
+		expect(formatDate('1943-12-31', 'short')).toBe('31.12.1943');
+	});
+});
 
 // ─── isoToGerman ─────────────────────────────────────────────────────────────
 
diff --git a/frontend/src/lib/utils/date.ts b/frontend/src/lib/utils/date.ts
index a7122392..5a469f39 100644
--- a/frontend/src/lib/utils/date.ts
+++ b/frontend/src/lib/utils/date.ts
@@ -1,13 +1,22 @@
 /**
  * Format an ISO date string (YYYY-MM-DD) for display.
  * Uses T12:00:00 to avoid UTC timezone off-by-one when converting to local time.
+ * Defaults to 'long' (e.g. "24. Dezember 1943"); pass 'short' for DD.MM.YYYY.
  */
-export function formatDate(isoDate: string): string {
+export function formatDate(isoDate: string, format: 'short' | 'long' = 'long'): string {
+	const date = new Date(isoDate + 'T12:00:00');
+	if (format === 'short') {
+		return new Intl.DateTimeFormat('de-DE', {
+			day: '2-digit',
+			month: '2-digit',
+			year: 'numeric'
+		}).format(date);
+	}
 	return new Intl.DateTimeFormat('de-DE', {
 		day: 'numeric',
 		month: 'long',
 		year: 'numeric'
-	}).format(new Date(isoDate + 'T12:00:00'));
+	}).format(date);
 }
 
 /**
diff --git a/frontend/src/lib/utils/personFormat.spec.ts b/frontend/src/lib/utils/personFormat.spec.ts
index a53367dc..6a398c96 100644
--- a/frontend/src/lib/utils/personFormat.spec.ts
+++ b/frontend/src/lib/utils/personFormat.spec.ts
@@ -4,10 +4,10 @@ import {
 	abbreviateName,
 	formatXsMeta,
 	personAvatarColor,
-	formatDate,
 	statusDotClass,
 	statusLabel
 } from './personFormat';
+import { formatDate } from './date';
 
 // ─── getInitials ─────────────────────────────────────────────────────────────
 
diff --git a/frontend/src/lib/utils/personFormat.ts b/frontend/src/lib/utils/personFormat.ts
index d60023e0..86fd7ad7 100644
--- a/frontend/src/lib/utils/personFormat.ts
+++ b/frontend/src/lib/utils/personFormat.ts
@@ -1,4 +1,5 @@
 import { formatDocumentStatus } from './documentStatusLabel';
+import { formatDate } from './date';
 
 type Person = { firstName?: string | null; lastName: string; displayName: string };
 type DocumentStatus = 'PLACEHOLDER' | 'UPLOADED' | 'TRANSCRIBED' | 'REVIEWED' | 'ARCHIVED';
@@ -75,22 +76,6 @@ export function personAvatarColor(personId: string): string {
 	return AVATAR_PALETTE[djb2(personId) % AVATAR_PALETTE.length];
 }
 
-export function formatDate(isoDate: string, format: 'short' | 'long'): string {
-	const date = new Date(isoDate + 'T12:00:00');
-	if (format === 'short') {
-		return new Intl.DateTimeFormat('de-DE', {
-			day: '2-digit',
-			month: '2-digit',
-			year: 'numeric'
-		}).format(date);
-	}
-	return new Intl.DateTimeFormat('de-DE', {
-		day: 'numeric',
-		month: 'long',
-		year: 'numeric'
-	}).format(date);
-}
-
 export function statusDotClass(status: DocumentStatus): string {
 	switch (status) {
 		case 'PLACEHOLDER':