marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(auth): hooks.server.ts re-throws redirects via isRedirect()

Browse Source 
Replace the duck-typed `status in error && location in error` check with the
official SvelteKit guard. Fragile against minor-version error-shape changes
becomes a one-liner against a typed helper. Addresses PR #612 / Felix F1.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-17 22:45:46 +02:00
parent dd99c5dd74
commit 9f1e2c9ff5
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/hooks.server.ts
View File

@@ -1,5 +1,5 @@
import * as Sentry from '@sentry/sveltekit'; import * as Sentry from '@sentry/sveltekit';
import { redirect, type Handle, type HandleFetch } from '@sveltejs/kit'; import { isRedirect, redirect, type Handle, type HandleFetch } from '@sveltejs/kit';
import { paraglideMiddleware } from '$lib/paraglide/server'; import { paraglideMiddleware } from '$lib/paraglide/server';
import { sequence } from '@sveltejs/kit/hooks'; import { sequence } from '@sveltejs/kit/hooks';
import { env } from 'process'; import { env } from 'process';
@@ -87,10 +87,9 @@ const userGroup: Handle = async ({ event, resolve }) => {
} }
} }
} catch (error) { } catch (error) {
// Don't swallow SvelteKit redirects — they're thrown as objects with a `status` field. // Re-throw SvelteKit redirects (e.g. the /login?reason=expired throw above)
if (error instanceof Object && 'status' in error && 'location' in error) { // using the official guard rather than duck-typing on the error shape.
throw error; if (isRedirect(error)) throw error;
}
console.error('Error fetching user in hook:', error); console.error('Error fetching user in hook:', error);
} }