marcel/familienarchiv
1
0
Fork 0
Code Issues 114 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(service): create MAIDEN_NAME alias in findOrCreateByAlias

Browse Source 
When split() returns a non-null maidenName, PersonService now
creates a PersonNameAlias with type MAIDEN_NAME. The maiden name
is stored as lastName on the alias (no firstName).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-08 12:55:50 +02:00
parent 8421d45c71
commit 9f90cc1a5f
2 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
backend/src/test/java/org/raddatz/familienarchiv/service/PersonServiceTest.java
View File

@@ -201,6 +201,34 @@ class PersonServiceTest {
verify(personRepository).save(any());
}
@Test
void findOrCreateByAlias_createsMaidenNameAlias_whenGebPresent() {
String alias = "Clara Cram geb. de Gruyter";
Person saved = Person.builder().id(UUID.randomUUID()).alias(alias).firstName("Clara").lastName("Cram").build();
when(personRepository.findByAliasIgnoreCase(alias)).thenReturn(Optional.empty());
when(personRepository.save(any())).thenReturn(saved);
when(aliasRepository.findMaxSortOrder(saved.getId())).thenReturn(0);
when(aliasRepository.save(any())).thenAnswer(inv -> inv.getArgument(0));
personService.findOrCreateByAlias(alias);
verify(aliasRepository).save(argThat(a ->
a.getLastName().equals("de Gruyter") &&
a.getType() == PersonNameAliasType.MAIDEN_NAME));
}
@Test
void findOrCreateByAlias_noAlias_whenNoGeb() {
String alias = "Clara Cram";
Person saved = Person.builder().id(UUID.randomUUID()).alias(alias).firstName("Clara").lastName("Cram").build();
when(personRepository.findByAliasIgnoreCase(alias)).thenReturn(Optional.empty());
when(personRepository.save(any())).thenReturn(saved);
personService.findOrCreateByAlias(alias);
verify(aliasRepository, never()).save(any());
}
@Test
void findOrCreateByAlias_trimsInput() {
String alias = " Clara Cram ";