From a76999c3d4a2050ba417a0723d44a7210414e7de Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Sun, 31 May 2026 12:40:54 +0200
Subject: [PATCH] test(tag): explicitly stub the subtree rollup query in
 getTagTree tests (#698)

Address review nit: the older getTagTree tests relied on Mockito's default
empty-list return for findSubtreeDocumentCountsPerTag. Stub it explicitly so
the two-query contract is self-documenting.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../java/org/raddatz/familienarchiv/tag/TagServiceTest.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/backend/src/test/java/org/raddatz/familienarchiv/tag/TagServiceTest.java b/backend/src/test/java/org/raddatz/familienarchiv/tag/TagServiceTest.java
index e9e06a70..3cb2762f 100644
--- a/backend/src/test/java/org/raddatz/familienarchiv/tag/TagServiceTest.java
+++ b/backend/src/test/java/org/raddatz/familienarchiv/tag/TagServiceTest.java
@@ -199,6 +199,7 @@ class TagServiceTest {
     void getTagTree_returnsEmptyList_whenNoTags() {
         when(tagRepository.findAll()).thenReturn(List.of());
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         assertThat(tagService.getTagTree()).isEmpty();
     }
@@ -213,6 +214,7 @@ class TagServiceTest {
         );
         when(tagRepository.findAll()).thenReturn(tags);
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         var tree = tagService.getTagTree();
 
@@ -228,6 +230,7 @@ class TagServiceTest {
         Tag child = Tag.builder().id(childId).name("Child").parentId(parentId).build();
         when(tagRepository.findAll()).thenReturn(List.of(parent, child));
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         var tree = tagService.getTagTree();
 
@@ -247,6 +250,7 @@ class TagServiceTest {
         Tag child = Tag.builder().id(childId).name("Child").parentId(parentId).build();
         when(tagRepository.findAll()).thenReturn(List.of(parent, child));
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         var tree = tagService.getTagTree();
 
@@ -262,6 +266,7 @@ class TagServiceTest {
         when(countEntry.getCount()).thenReturn(5L);
         when(tagRepository.findAll()).thenReturn(List.of(tag));
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of(countEntry));
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         var tree = tagService.getTagTree();
 
@@ -272,6 +277,7 @@ class TagServiceTest {
     void getTagTree_callsFindDocumentCountsPerTag_exactlyOnce() {
         when(tagRepository.findAll()).thenReturn(List.of());
         when(tagRepository.findDocumentCountsPerTag()).thenReturn(List.of());
+        when(tagRepository.findSubtreeDocumentCountsPerTag()).thenReturn(List.of());
 
         tagService.getTagTree();