marcel/familienarchiv
1
0
Fork 0
Code Issues 102 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(stammbaum): JOIN FETCH persons in relationship queries

Browse Source 
Both /api/network and /api/persons/{id}/relationships threw
LazyInitializationException when toDTO read Person.getDisplayName():
the read-side service methods aren't @Transactional, so the session
closed before the proxy could initialize.

Eagerly fetch r.person and r.relatedPerson in the two queries used
by these endpoints, keeping the no-@Transactional convention for
read methods.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-27 19:47:19 +02:00
committed by marcel
parent f382bd9974
commit a7b1dcb5e1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backend/src/main/java/org/raddatz/familienarchiv/relationship/PersonRelationshipRepository.java
View File

@@ -16,7 +16,11 @@ public interface PersonRelationshipRepository extends JpaRepository<PersonRelati
* Bulk fetch for the network endpoint — pulls only edges of the given types. * Bulk fetch for the network endpoint — pulls only edges of the given types.
* The service filters by family_member afterwards. * The service filters by family_member afterwards.
*/ */
List<PersonRelationship> findAllByRelationTypeIn(Collection<RelationType> types); @Query("SELECT r FROM PersonRelationship r " +
"JOIN FETCH r.person " +
"JOIN FETCH r.relatedPerson " +
"WHERE r.relationType IN :types")
List<PersonRelationship> findAllByRelationTypeIn(@Param("types") Collection<RelationType> types);
/** Used for the circular-PARENT_OF check in {@code addRelationship}. */ /** Used for the circular-PARENT_OF check in {@code addRelationship}. */
boolean existsByPersonIdAndRelatedPersonIdAndRelationType( boolean existsByPersonIdAndRelatedPersonIdAndRelationType(
@@ -38,6 +42,8 @@ public interface PersonRelationshipRepository extends JpaRepository<PersonRelati
* Used by the "direct relationships" listings (person edit, side panel). * Used by the "direct relationships" listings (person edit, side panel).
*/ */
@Query("SELECT r FROM PersonRelationship r " + @Query("SELECT r FROM PersonRelationship r " +
"JOIN FETCH r.person " +
"JOIN FETCH r.relatedPerson " +
"WHERE r.person.id = :personId OR r.relatedPerson.id = :personId") "WHERE r.person.id = :personId OR r.relatedPerson.id = :personId")
List<PersonRelationship> findAllByPersonIdOrRelatedPersonId(@Param("personId") UUID personId); List<PersonRelationship> findAllByPersonIdOrRelatedPersonId(@Param("personId") UUID personId);
} }