refactor: address PR review concerns

- Remove Architekt from WORD_PREFIXES (classifier handles it)
- Use Objects.equals for null-safe firstName/lastName comparison
- Remove unused trimmed variable in PersonTypeClassifier
- Fix containsWord to loop through all occurrences (finds
  "Eltern" in "Nachbareltern Eltern")
- Extract DisplayNameFormatter utility shared by Person and
  PersonSummaryDTO to eliminate display logic duplication

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-08 13:25:06 +02:00
parent c0cf8d7952
commit ac545ecdaa
6 changed files with 34 additions and 20 deletions

View File

@@ -86,4 +86,9 @@ class PersonTypeClassifierTest {
void classify_caseInsensitive() {
assertThat(PersonTypeClassifier.classify("firma auschrath")).isEqualTo(PersonType.INSTITUTION);
}
@Test
void classify_containsWord_findsSecondOccurrence() {
assertThat(PersonTypeClassifier.classify("Nachbareltern Eltern")).isEqualTo(PersonType.GROUP);
}
}