feat(timeline): add EventPill for derived + curated event pills
Centered axis pill: derived life-events (* Geburt / † Tod / ⚭ Heirat) and curated PERSONAL events (★, mint border) via getAccentConfig. Glyph wrapped aria-hidden + sr-only label (REQ-018). Edit affordance only for a curated event with eventId, never derived/null (REQ-008). REQ-007. Refs #779 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
59
frontend/src/lib/timeline/EventPill.svelte
Normal file
59
frontend/src/lib/timeline/EventPill.svelte
Normal file
@@ -0,0 +1,59 @@
|
|||||||
|
<script lang="ts">
|
||||||
|
import * as m from '$lib/paraglide/messages.js';
|
||||||
|
import { getAccentConfig } from './eventCardConfig';
|
||||||
|
import { timelineDateLabel } from './dateLabel';
|
||||||
|
import type { components } from '$lib/generated/api';
|
||||||
|
|
||||||
|
type TimelineEntryDTO = components['schemas']['TimelineEntryDTO'];
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Centered axis pill for a derived life-event or a curated PERSONAL event
|
||||||
|
* (REQ-007/008). The glyph is wrapped aria-hidden with an sr-only label sibling
|
||||||
|
* (REQ-018). An edit affordance shows only for a curated event with an eventId
|
||||||
|
* (never derived, never null — REQ-008).
|
||||||
|
*/
|
||||||
|
let { entry }: { entry: TimelineEntryDTO } = $props();
|
||||||
|
|
||||||
|
const config = $derived(getAccentConfig(entry));
|
||||||
|
const dateLabel = $derived(timelineDateLabel(entry.eventDate, entry.precision, entry.eventDateEnd));
|
||||||
|
const canEdit = $derived(!entry.derived && entry.eventId != null);
|
||||||
|
</script>
|
||||||
|
|
||||||
|
<div class="flex justify-center">
|
||||||
|
<div
|
||||||
|
class="inline-flex items-center gap-2 rounded-full bg-surface px-3 py-1 shadow-sm {config.accent ===
|
||||||
|
'curated'
|
||||||
|
? 'border-2 border-brand-mint'
|
||||||
|
: 'border border-brand-navy'}"
|
||||||
|
>
|
||||||
|
<span
|
||||||
|
class="flex h-7 w-7 shrink-0 items-center justify-center rounded-full {config.accent ===
|
||||||
|
'curated'
|
||||||
|
? 'bg-brand-mint text-brand-navy'
|
||||||
|
: 'bg-brand-navy text-brand-mint'}"
|
||||||
|
>
|
||||||
|
<span aria-hidden="true">{config.glyph}</span>
|
||||||
|
<span class="sr-only">{config.label}</span>
|
||||||
|
</span>
|
||||||
|
<span class="text-left">
|
||||||
|
{#if entry.title}
|
||||||
|
<span class="block font-serif text-sm font-bold whitespace-pre-line text-brand-navy"
|
||||||
|
>{entry.title}</span
|
||||||
|
>
|
||||||
|
{/if}
|
||||||
|
{#if dateLabel}
|
||||||
|
<span class="block font-sans text-xs text-ink-3">{dateLabel}</span>
|
||||||
|
{/if}
|
||||||
|
</span>
|
||||||
|
{#if canEdit}
|
||||||
|
<a
|
||||||
|
data-testid="event-edit"
|
||||||
|
href="/zeitstrahl/events/{entry.eventId}/edit"
|
||||||
|
class="ml-1 rounded-sm px-1 font-sans text-xs text-ink-3 hover:text-brand-navy focus:outline-none focus-visible:ring-2 focus-visible:ring-brand-navy"
|
||||||
|
>
|
||||||
|
<span aria-hidden="true">✎</span>
|
||||||
|
<span class="sr-only">{m.btn_edit()}</span>
|
||||||
|
</a>
|
||||||
|
{/if}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
90
frontend/src/lib/timeline/EventPill.svelte.spec.ts
Normal file
90
frontend/src/lib/timeline/EventPill.svelte.spec.ts
Normal file
@@ -0,0 +1,90 @@
|
|||||||
|
import { describe, it, expect, afterEach } from 'vitest';
|
||||||
|
import { cleanup, render } from 'vitest-browser-svelte';
|
||||||
|
import EventPill from './EventPill.svelte';
|
||||||
|
import { makeEntry } from './test-factories';
|
||||||
|
|
||||||
|
afterEach(() => cleanup());
|
||||||
|
|
||||||
|
const EVENT_ID = '33333333-3333-3333-3333-333333333333';
|
||||||
|
|
||||||
|
function derived(derivedType: 'BIRTH' | 'DEATH' | 'MARRIAGE', title: string) {
|
||||||
|
return makeEntry({
|
||||||
|
kind: 'EVENT',
|
||||||
|
derived: true,
|
||||||
|
derivedType,
|
||||||
|
title,
|
||||||
|
senderName: '',
|
||||||
|
receiverName: '',
|
||||||
|
precision: 'YEAR',
|
||||||
|
eventDate: '1914-01-01',
|
||||||
|
documentId: undefined
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('EventPill', () => {
|
||||||
|
it('renders a derived marriage as ⚭ + "Heirat" + title (REQ-007)', () => {
|
||||||
|
render(EventPill, { entry: derived('MARRIAGE', 'Heirat: Karl & Elfriede') });
|
||||||
|
expect(document.body.textContent).toContain('⚭');
|
||||||
|
expect(document.body.textContent).toContain('Heirat');
|
||||||
|
expect(document.body.textContent).toContain('Heirat: Karl & Elfriede');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders a derived birth as * + "Geburt" (REQ-007)', () => {
|
||||||
|
render(EventPill, { entry: derived('BIRTH', 'Geburt: Hans') });
|
||||||
|
expect(document.body.textContent).toContain('*');
|
||||||
|
expect(document.body.textContent).toContain('Geburt');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders a derived death as † + "Tod" (REQ-007)', () => {
|
||||||
|
render(EventPill, { entry: derived('DEATH', 'Tod: Karl') });
|
||||||
|
expect(document.body.textContent).toContain('†');
|
||||||
|
expect(document.body.textContent).toContain('Tod');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('wraps the glyph aria-hidden with an sr-only label sibling (REQ-018)', () => {
|
||||||
|
render(EventPill, { entry: derived('BIRTH', 'Geburt: Hans') });
|
||||||
|
const hidden = document.querySelector('[aria-hidden="true"]');
|
||||||
|
expect(hidden?.textContent).toBe('*');
|
||||||
|
const srOnly = document.querySelector('.sr-only');
|
||||||
|
expect(srOnly?.textContent).toBe('Geburt');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows an edit affordance for a curated PERSONAL event with an eventId (REQ-008)', () => {
|
||||||
|
render(EventPill, {
|
||||||
|
entry: makeEntry({
|
||||||
|
kind: 'EVENT',
|
||||||
|
derived: false,
|
||||||
|
type: 'PERSONAL',
|
||||||
|
eventId: EVENT_ID,
|
||||||
|
title: 'Auswanderung',
|
||||||
|
senderName: '',
|
||||||
|
receiverName: '',
|
||||||
|
documentId: undefined
|
||||||
|
})
|
||||||
|
});
|
||||||
|
const edit = document.querySelector('[data-testid="event-edit"]') as HTMLAnchorElement | null;
|
||||||
|
expect(edit).not.toBeNull();
|
||||||
|
expect(edit?.getAttribute('href')).toContain(EVENT_ID);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows no edit affordance when eventId is null (REQ-008)', () => {
|
||||||
|
render(EventPill, {
|
||||||
|
entry: makeEntry({
|
||||||
|
kind: 'EVENT',
|
||||||
|
derived: false,
|
||||||
|
type: 'PERSONAL',
|
||||||
|
eventId: undefined,
|
||||||
|
title: 'Auswanderung',
|
||||||
|
senderName: '',
|
||||||
|
receiverName: '',
|
||||||
|
documentId: undefined
|
||||||
|
})
|
||||||
|
});
|
||||||
|
expect(document.querySelector('[data-testid="event-edit"]')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows no edit affordance for a derived event (REQ-008)', () => {
|
||||||
|
render(EventPill, { entry: derived('MARRIAGE', 'Heirat') });
|
||||||
|
expect(document.querySelector('[data-testid="event-edit"]')).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in New Issue
Block a user