marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(a11y): view-all links meet 44px touch target

Browse Source 
WCAG 2.2 §2.5.8 (Target Size, Minimum). The Alle Personen → and Alle
Geschichten → text links were inline elements with no enforced minimum
height — small tap targets on mobile. inline-flex + min-h-[44px] keeps
the visual layout while guaranteeing the 44px hit area.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-05-08 12:48:06 +02:00
committed by marcel
parent f7eefb525f
commit b1c2132aa6
4 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/lib/shared/dashboard/ReaderPersonChips.svelte
View File

@@ -54,7 +54,7 @@ const { persons }: Props = $props();
</div> </div>
<a <a
href="/persons" href="/persons"
class="self-end rounded-sm font-sans text-sm text-brand-navy underline hover:text-brand-mint focus-visible:ring-2 focus-visible:ring-brand-navy focus-visible:ring-offset-2 focus-visible:outline-none" class="inline-flex min-h-[44px] items-center self-end rounded-sm font-sans text-sm text-brand-navy underline hover:text-brand-mint focus-visible:ring-2 focus-visible:ring-brand-navy focus-visible:ring-offset-2 focus-visible:outline-none"
>{m.dashboard_reader_all_persons()}</a >{m.dashboard_reader_all_persons()}</a
> >
</div> </div>

7
frontend/src/lib/shared/dashboard/ReaderPersonChips.svelte.spec.ts
View File

@@ -66,6 +66,13 @@ describe('ReaderPersonChips', () => {
expect(cls).toMatch(/focus-visible:ring-brand-navy/); expect(cls).toMatch(/focus-visible:ring-brand-navy/);
}); });
it('meets the 44px touch target on the "Alle Personen" link', async () => {
render(ReaderPersonChips, { persons: [person1] });
const allLink = page.getByRole('link', { name: /Alle Personen/i });
const cls = ((await allLink.element()) as HTMLElement).className;
expect(cls).toMatch(/min-h-\[44px\]/);
});
it('renders empty state without chips when persons array is empty', async () => { it('renders empty state without chips when persons array is empty', async () => {
render(ReaderPersonChips, { persons: [] }); render(ReaderPersonChips, { persons: [] });
const chips = page.getByRole('link', { name: /Müller|Schmidt/ }); const chips = page.getByRole('link', { name: /Müller|Schmidt/ });

2
frontend/src/lib/shared/dashboard/ReaderRecentStories.svelte
View File

@@ -48,7 +48,7 @@ function excerpt(body: string | undefined): string {
</ul> </ul>
<a <a
href="/geschichten" href="/geschichten"
class="mt-4 block rounded-sm font-sans text-sm text-brand-navy underline hover:text-brand-mint focus-visible:ring-2 focus-visible:ring-brand-navy focus-visible:ring-offset-2 focus-visible:outline-none" class="mt-4 inline-flex min-h-[44px] items-center rounded-sm font-sans text-sm text-brand-navy underline hover:text-brand-mint focus-visible:ring-2 focus-visible:ring-brand-navy focus-visible:ring-offset-2 focus-visible:outline-none"
> >
{m.dashboard_reader_all_stories()} {m.dashboard_reader_all_stories()}
</a> </a>

7
frontend/src/lib/shared/dashboard/ReaderRecentStories.svelte.spec.ts
View File

@@ -65,4 +65,11 @@ describe('ReaderRecentStories', () => {
expect(cls).toMatch(/focus-visible:ring-2/); expect(cls).toMatch(/focus-visible:ring-2/);
expect(cls).toMatch(/focus-visible:ring-brand-navy/); expect(cls).toMatch(/focus-visible:ring-brand-navy/);
}); });
it('meets the 44px touch target on the "Alle Geschichten" link', async () => {
render(ReaderRecentStories, { stories: [story1] });
const allLink = page.getByRole('link', { name: /Alle Geschichten/i });
const cls = ((await allLink.element()) as HTMLElement).className;
expect(cls).toMatch(/min-h-\[44px\]/);
});
}); });