chore: merge main into branch; resolve ChronikRow conflict
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 4m21s
CI / OCR Service Tests (pull_request) Successful in 42s
CI / Backend Unit Tests (pull_request) Failing after 3m36s
CI / Unit & Component Tests (push) Failing after 3m46s
CI / OCR Service Tests (push) Successful in 31s
CI / Backend Unit Tests (push) Failing after 3m17s
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 4m21s
CI / OCR Service Tests (pull_request) Successful in 42s
CI / Backend Unit Tests (pull_request) Failing after 3m36s
CI / Unit & Component Tests (push) Failing after 3m46s
CI / OCR Service Tests (push) Successful in 31s
CI / Backend Unit Tests (push) Failing after 3m17s
TODO/SECURITY placeholders from main are superseded by the #454 implementation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit was merged in pull request #475.
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import { describe, it, expect, vi, afterEach } from 'vitest';
|
||||
import { cleanup, render } from 'vitest-browser-svelte';
|
||||
import { page, userEvent } from 'vitest/browser';
|
||||
import { page } from 'vitest/browser';
|
||||
|
||||
import ChronikErrorCard from './ChronikErrorCard.svelte';
|
||||
|
||||
@@ -10,7 +10,7 @@ describe('ChronikErrorCard', () => {
|
||||
it('renders the default error message', async () => {
|
||||
render(ChronikErrorCard, { onRetry: vi.fn() });
|
||||
await expect
|
||||
.element(page.getByText('Die Chronik konnte nicht geladen werden.'))
|
||||
.element(page.getByText('Die Aktivitäten konnten nicht geladen werden.'))
|
||||
.toBeInTheDocument();
|
||||
});
|
||||
|
||||
@@ -27,7 +27,8 @@ describe('ChronikErrorCard', () => {
|
||||
it('calls onRetry when the retry button is clicked', async () => {
|
||||
const onRetry = vi.fn();
|
||||
render(ChronikErrorCard, { onRetry });
|
||||
await userEvent.click(page.getByText('Erneut versuchen'));
|
||||
const btn = (await page.getByText('Erneut versuchen').element()) as HTMLElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
expect(onRetry).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
|
||||
@@ -34,6 +34,6 @@ describe('BulkDropZone', () => {
|
||||
|
||||
it('shows drop hint text', async () => {
|
||||
render(BulkDropZone, { onFilesAdded: vi.fn() });
|
||||
await expect.element(page.getByText(/hier ablegen/i)).toBeInTheDocument();
|
||||
await expect.element(page.getByText(/Dateien ablegen/i)).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -116,8 +116,8 @@ describe('TranscriptionBlock — interactions', () => {
|
||||
it('calls onFocus when textarea is focused', async () => {
|
||||
const onFocus = vi.fn();
|
||||
renderBlock({ onFocus });
|
||||
const textarea = page.getByRole('textbox');
|
||||
await textarea.click();
|
||||
const textboxEl = (await page.getByRole('textbox').element()) as HTMLElement;
|
||||
textboxEl.dispatchEvent(new FocusEvent('focus', { bubbles: false }));
|
||||
expect(onFocus).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
@@ -152,16 +152,20 @@ describe('TranscriptionBlock — reorder controls', () => {
|
||||
it('calls onMoveUp when up arrow clicked', async () => {
|
||||
const onMoveUp = vi.fn();
|
||||
renderBlock({ onMoveUp, isFirst: false });
|
||||
const btn = page.getByRole('button', { name: 'Nach oben' });
|
||||
await btn.click();
|
||||
const btnEl = (await page
|
||||
.getByRole('button', { name: 'Nach oben' })
|
||||
.element()) as HTMLButtonElement;
|
||||
btnEl.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
expect(onMoveUp).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('calls onMoveDown when down arrow clicked', async () => {
|
||||
const onMoveDown = vi.fn();
|
||||
renderBlock({ onMoveDown, isLast: false });
|
||||
const btn = page.getByRole('button', { name: 'Nach unten' });
|
||||
await btn.click();
|
||||
const btnEl = (await page
|
||||
.getByRole('button', { name: 'Nach unten' })
|
||||
.element()) as HTMLButtonElement;
|
||||
btnEl.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
expect(onMoveDown).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -227,16 +231,17 @@ describe('TranscriptionBlock — delete confirmation', () => {
|
||||
describe('TranscriptionBlock — quote selection', () => {
|
||||
it('shows quote hint after text is selected in the editor', async () => {
|
||||
renderBlock({ text: 'Breslau, den 12. August' });
|
||||
await page.getByRole('textbox').click();
|
||||
// Select all text in the contenteditable via the native Selection API.
|
||||
// Tiptap fires selectionUpdate which the block forwards as onSelectionChange.
|
||||
const editorEl = document.querySelector('[role="textbox"]') as HTMLElement;
|
||||
// Native .focus() activates ProseMirror's DOMObserver so it listens for selectionchange.
|
||||
const editorEl = (await page.getByRole('textbox').element()) as HTMLElement;
|
||||
editorEl.focus();
|
||||
// Let ProseMirror's focus handler complete before we overwrite the selection.
|
||||
await new Promise((r) => setTimeout(r, 0));
|
||||
const range = document.createRange();
|
||||
range.selectNodeContents(editorEl);
|
||||
const selection = window.getSelection()!;
|
||||
selection.removeAllRanges();
|
||||
selection.addRange(range);
|
||||
editorEl.dispatchEvent(new Event('input', { bubbles: true }));
|
||||
const sel = window.getSelection()!;
|
||||
sel.removeAllRanges();
|
||||
sel.addRange(range);
|
||||
document.dispatchEvent(new Event('selectionchange'));
|
||||
await expect.element(page.getByText(/Zitat/)).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { describe, it, expect, vi, afterEach } from 'vitest';
|
||||
import { cleanup, render } from 'vitest-browser-svelte';
|
||||
import { page } from 'vitest/browser';
|
||||
import { page, userEvent } from 'vitest/browser';
|
||||
import TranscriptionEditView from './TranscriptionEditView.svelte';
|
||||
import { createConfirmService, CONFIRM_KEY } from '$lib/shared/services/confirm.svelte.js';
|
||||
|
||||
@@ -148,24 +148,28 @@ describe('TranscriptionEditView — auto-save debounce', () => {
|
||||
});
|
||||
|
||||
it('passes the block mentionedPersons array as the 3rd save argument', async () => {
|
||||
vi.useFakeTimers();
|
||||
const onSaveBlock = vi.fn().mockResolvedValue(undefined);
|
||||
const blockWithMention = {
|
||||
...block1,
|
||||
// text must contain the @displayName token so deserialize() creates a mention node;
|
||||
// fill() replaces the whole content with plain text and would destroy the node
|
||||
text: '@Auguste Raddatz',
|
||||
mentionedPersons: [{ personId: 'p-aug', displayName: 'Auguste Raddatz' }]
|
||||
};
|
||||
renderView({ blocks: [blockWithMention], onSaveBlock });
|
||||
|
||||
const textarea = page.getByRole('textbox').first();
|
||||
await textarea.fill('Hallo @Auguste Raddatz');
|
||||
// type() focuses the element (cursor at position 0) then inserts without replacing the
|
||||
// existing mention node. Fake timers interfere with keyboard CDP so use real timers
|
||||
// + vi.waitFor to catch the 1500 ms debounce.
|
||||
await userEvent.type(page.getByRole('textbox').first(), 'Hallo ');
|
||||
|
||||
vi.advanceTimersByTime(1500);
|
||||
await vi.runAllTimersAsync();
|
||||
|
||||
expect(onSaveBlock).toHaveBeenCalledWith('b1', 'Hallo @Auguste Raddatz', [
|
||||
{ personId: 'p-aug', displayName: 'Auguste Raddatz' }
|
||||
]);
|
||||
vi.useRealTimers();
|
||||
await vi.waitFor(
|
||||
() =>
|
||||
expect(onSaveBlock).toHaveBeenCalledWith('b1', 'Hallo @Auguste Raddatz', [
|
||||
{ personId: 'p-aug', displayName: 'Auguste Raddatz' }
|
||||
]),
|
||||
{ timeout: 3000 }
|
||||
);
|
||||
});
|
||||
|
||||
it('resets debounce timer on rapid successive changes', async () => {
|
||||
@@ -238,8 +242,9 @@ describe('TranscriptionEditView — flush on blur', () => {
|
||||
const textarea = page.getByRole('textbox').first();
|
||||
await textarea.fill('Blur text');
|
||||
|
||||
// Blur before 1500ms debounce fires — locator.blur() not available, use native DOM
|
||||
const el = document.querySelector('textarea') as HTMLTextAreaElement;
|
||||
// Blur before 1500ms debounce fires — locator.blur() not available, use native DOM.
|
||||
// PersonMentionEditor uses a contenteditable div (role=textbox), not a <textarea>.
|
||||
const el = document.querySelector('[role="textbox"]') as HTMLElement;
|
||||
el.dispatchEvent(new FocusEvent('blur', { bubbles: true }));
|
||||
|
||||
await vi.runAllTimersAsync();
|
||||
@@ -335,7 +340,12 @@ describe('TranscriptionEditView — mark all reviewed', () => {
|
||||
onMarkAllReviewed
|
||||
});
|
||||
|
||||
await page.getByRole('button', { name: /Alle als fertig markieren/ }).click();
|
||||
// userEvent.click() via Playwright CDP doesn't reliably trigger Svelte 5 onclick
|
||||
// handlers when a TipTap editor is mounted in the same component tree.
|
||||
const btn = (await page
|
||||
.getByRole('button', { name: /Alle als fertig markieren/ })
|
||||
.element()) as HTMLButtonElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
await vi.waitFor(() => expect(onMarkAllReviewed).toHaveBeenCalledTimes(1));
|
||||
});
|
||||
|
||||
@@ -349,9 +359,14 @@ describe('TranscriptionEditView — mark all reviewed', () => {
|
||||
onMarkAllReviewed
|
||||
});
|
||||
|
||||
const btn = page.getByRole('button', { name: /Alle als fertig markieren/ });
|
||||
await btn.click();
|
||||
await expect.element(btn).toBeDisabled();
|
||||
// Same CDP click workaround: dispatch from browser JS to reliably fire Svelte 5 onclick
|
||||
const btnEl = (await page
|
||||
.getByRole('button', { name: /Alle als fertig markieren/ })
|
||||
.element()) as HTMLButtonElement;
|
||||
btnEl.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
await expect
|
||||
.element(page.getByRole('button', { name: /Alle als fertig markieren/ }))
|
||||
.toBeDisabled();
|
||||
resolveMarkAll();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -53,7 +53,12 @@ describe('GeschichteEditor — title-required guard', () => {
|
||||
render(GeschichteEditor, { onSubmit });
|
||||
|
||||
await userEvent.click(page.getByPlaceholder('Titel der Geschichte'));
|
||||
await userEvent.tab(); // blur
|
||||
// userEvent.tab() / keyboard('{Tab}') do not reliably fire the blur event on
|
||||
// inputs inside Playwright's test iframe. .blur() is a no-op when the element
|
||||
// has lost focus to TipTap's onMount initialisation. Dispatching the FocusEvent
|
||||
// directly fires Svelte's onblur listener regardless of the current focus owner.
|
||||
const input = await page.getByPlaceholder('Titel der Geschichte').element();
|
||||
input.dispatchEvent(new FocusEvent('blur'));
|
||||
await expect.element(page.getByText('Bitte gib einen Titel ein.')).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
@@ -111,8 +116,23 @@ describe('GeschichteEditor — onSubmit payload', () => {
|
||||
const onSubmit = vi.fn().mockResolvedValue(undefined);
|
||||
render(GeschichteEditor, { onSubmit });
|
||||
|
||||
await userEvent.fill(page.getByPlaceholder('Titel der Geschichte'), ' My title ');
|
||||
await userEvent.click(page.getByRole('button', { name: 'Entwurf speichern' }));
|
||||
// userEvent.fill() with trailing whitespace does not fire the input event chain
|
||||
// that Svelte's bind:value requires (CDP limitation). Setting .value directly
|
||||
// and dispatching an input event works around this while preserving the trailing
|
||||
// space needed to verify the trim() contract.
|
||||
const input = (await page
|
||||
.getByPlaceholder('Titel der Geschichte')
|
||||
.element()) as HTMLInputElement;
|
||||
input.value = 'My title ';
|
||||
input.dispatchEvent(new Event('input', { bubbles: true }));
|
||||
|
||||
// userEvent.click() via Playwright CDP does not reliably trigger Svelte 5 onclick
|
||||
// handlers when a TipTap editor is mounted in the same component. Dispatching
|
||||
// the MouseEvent directly from the browser JS context bypasses this issue.
|
||||
const btn = (await page
|
||||
.getByRole('button', { name: 'Entwurf speichern' })
|
||||
.element()) as HTMLButtonElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
const payload = onSubmit.mock.calls[0][0];
|
||||
@@ -125,7 +145,10 @@ describe('GeschichteEditor — onSubmit payload', () => {
|
||||
render(GeschichteEditor, { onSubmit });
|
||||
|
||||
await userEvent.fill(page.getByPlaceholder('Titel der Geschichte'), 'Story');
|
||||
await userEvent.click(page.getByRole('button', { name: 'Veröffentlichen' }));
|
||||
const btn = (await page
|
||||
.getByRole('button', { name: 'Veröffentlichen' })
|
||||
.element()) as HTMLButtonElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
expect(onSubmit.mock.calls[0][0].status).toBe('PUBLISHED');
|
||||
@@ -140,7 +163,10 @@ describe('GeschichteEditor — onSubmit payload', () => {
|
||||
});
|
||||
|
||||
await userEvent.fill(page.getByPlaceholder('Titel der Geschichte'), 'Story');
|
||||
await userEvent.click(page.getByRole('button', { name: 'Entwurf speichern' }));
|
||||
const btn = (await page
|
||||
.getByRole('button', { name: 'Entwurf speichern' })
|
||||
.element()) as HTMLButtonElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
|
||||
expect(onSubmit).toHaveBeenCalledTimes(1);
|
||||
const payload = onSubmit.mock.calls[0][0];
|
||||
|
||||
@@ -143,7 +143,7 @@ describe('PersonMultiSelect – selecting persons', () => {
|
||||
const input = page.getByRole('textbox');
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
await page.getByText('Max Mustermann').click();
|
||||
((await page.getByRole('button', { name: 'Max Mustermann' }).element()) as HTMLElement).click();
|
||||
await expect.element(page.getByText('Max Mustermann')).toBeInTheDocument();
|
||||
await expect.element(input).toHaveValue('');
|
||||
await page.screenshot({
|
||||
@@ -158,11 +158,13 @@ describe('PersonMultiSelect – selecting persons', () => {
|
||||
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
await page.getByText('Max Mustermann').click();
|
||||
((await page.getByRole('button', { name: 'Max Mustermann' }).element()) as HTMLElement).click();
|
||||
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
await page.getByText('Anna Musterfrau').click();
|
||||
(
|
||||
(await page.getByRole('button', { name: 'Anna Musterfrau' }).element()) as HTMLElement
|
||||
).click();
|
||||
|
||||
await expect.element(page.getByText('Max Mustermann')).toBeInTheDocument();
|
||||
await expect.element(page.getByText('Anna Musterfrau')).toBeInTheDocument();
|
||||
@@ -210,7 +212,13 @@ describe('PersonMultiSelect – selecting persons', () => {
|
||||
const input = page.getByRole('textbox');
|
||||
await input.fill('Ma');
|
||||
await waitForDebounce();
|
||||
await page.getByText('Max Mustermann').click();
|
||||
const resultEl = (await page
|
||||
.getByRole('button', { name: 'Max Mustermann' })
|
||||
.element()) as HTMLElement;
|
||||
resultEl.dispatchEvent(
|
||||
new KeyboardEvent('keydown', { key: 'Enter', bubbles: true, cancelable: true })
|
||||
);
|
||||
await tick();
|
||||
await expect.element(page.getByText('Max Mustermann')).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
@@ -240,8 +248,11 @@ describe('PersonMultiSelect – removing persons', () => {
|
||||
]
|
||||
});
|
||||
// Buttons have aria-label="Entfernen"
|
||||
const removeButtons = page.getByRole('button', { name: 'Entfernen' });
|
||||
await removeButtons.first().click();
|
||||
const removeBtn = (await page
|
||||
.getByRole('button', { name: 'Entfernen' })
|
||||
.first()
|
||||
.element()) as HTMLElement;
|
||||
removeBtn.click();
|
||||
await expect.element(page.getByText('Max Mustermann')).not.toBeInTheDocument();
|
||||
await expect.element(page.getByText('Anna Musterfrau')).toBeInTheDocument();
|
||||
});
|
||||
@@ -267,7 +278,9 @@ describe('PersonMultiSelect – removing persons', () => {
|
||||
}
|
||||
]
|
||||
});
|
||||
await page.getByRole('button', { name: 'Entfernen' }).first().click();
|
||||
(
|
||||
(await page.getByRole('button', { name: 'Entfernen' }).first().element()) as HTMLElement
|
||||
).click();
|
||||
await tick();
|
||||
const inputs = receiverInputs();
|
||||
expect(inputs).toHaveLength(1);
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { describe, expect, it, vi, afterEach } from 'vitest';
|
||||
import { cleanup, render } from 'vitest-browser-svelte';
|
||||
import { page, userEvent } from 'vitest/browser';
|
||||
import { page } from 'vitest/browser';
|
||||
import PersonTypeahead from './PersonTypeahead.svelte';
|
||||
|
||||
const waitForDebounce = () => new Promise((r) => setTimeout(r, 350));
|
||||
@@ -346,6 +346,14 @@ describe('PersonTypeahead – ARIA roles', () => {
|
||||
|
||||
// ─── Keyboard navigation ──────────────────────────────────────────────────────
|
||||
|
||||
// CDP-based userEvent.keyboard does not reliably trigger Svelte 5 onkeydown
|
||||
// handlers. Dispatch native KeyboardEvent directly on the DOM element instead.
|
||||
async function pressKey(input: ReturnType<typeof page.getByPlaceholder>, key: string) {
|
||||
const el = (await input.element()) as HTMLInputElement;
|
||||
el.dispatchEvent(new KeyboardEvent('keydown', { key, bubbles: true, cancelable: true }));
|
||||
await tick();
|
||||
}
|
||||
|
||||
describe('PersonTypeahead – keyboard navigation', () => {
|
||||
it('ArrowDown moves highlight to the first option', async () => {
|
||||
mockFetchWithPersons();
|
||||
@@ -354,9 +362,7 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}');
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown');
|
||||
|
||||
// First option should be highlighted (aria-selected="true")
|
||||
const firstOption = page.getByRole('option', { name: 'Max Mustermann' });
|
||||
@@ -370,11 +376,8 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}');
|
||||
await tick();
|
||||
await userEvent.keyboard('{ArrowDown}');
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown');
|
||||
await pressKey(input, 'ArrowDown');
|
||||
|
||||
const secondOption = page.getByRole('option', { name: 'Anna Musterfrau' });
|
||||
await expect.element(secondOption).toHaveAttribute('aria-selected', 'true');
|
||||
@@ -387,11 +390,8 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}'); // highlight first
|
||||
await tick();
|
||||
await userEvent.keyboard('{ArrowUp}'); // wrap to last
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown'); // highlight first
|
||||
await pressKey(input, 'ArrowUp'); // wrap to last
|
||||
|
||||
const lastOption = page.getByRole('option', { name: 'Anna Musterfrau' });
|
||||
await expect.element(lastOption).toHaveAttribute('aria-selected', 'true');
|
||||
@@ -404,13 +404,9 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await input.fill('Mu');
|
||||
await waitForDebounce();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}'); // highlight first (index 0)
|
||||
await tick();
|
||||
await userEvent.keyboard('{ArrowDown}'); // highlight second (index 1 = last)
|
||||
await tick();
|
||||
await userEvent.keyboard('{ArrowDown}'); // wrap to first (index 0)
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown'); // highlight first (index 0)
|
||||
await pressKey(input, 'ArrowDown'); // highlight second (index 1 = last)
|
||||
await pressKey(input, 'ArrowDown'); // wrap to first (index 0)
|
||||
|
||||
const firstOption = page.getByRole('option', { name: 'Max Mustermann' });
|
||||
await expect.element(firstOption).toHaveAttribute('aria-selected', 'true');
|
||||
@@ -431,11 +427,8 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await input.fill('Ma');
|
||||
await waitForDebounce();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}');
|
||||
await tick();
|
||||
await userEvent.keyboard('{Enter}');
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown');
|
||||
await pressKey(input, 'Enter');
|
||||
|
||||
await expect.element(input).toHaveValue('Max Mustermann');
|
||||
await expect.element(page.getByRole('listbox')).not.toBeInTheDocument();
|
||||
@@ -449,9 +442,8 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
await waitForDebounce();
|
||||
await expect.element(page.getByRole('listbox')).toBeInTheDocument();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{Escape}');
|
||||
await tick();
|
||||
await pressKey(input, 'Escape');
|
||||
|
||||
await expect.element(page.getByRole('listbox')).not.toBeInTheDocument();
|
||||
// Value unchanged — nothing was selected
|
||||
await expect.element(input).toHaveValue('Mu');
|
||||
@@ -468,9 +460,7 @@ describe('PersonTypeahead – keyboard navigation', () => {
|
||||
const beforeNav = await input.element().getAttribute('aria-activedescendant');
|
||||
expect(beforeNav).toBeFalsy();
|
||||
|
||||
await input.click();
|
||||
await userEvent.keyboard('{ArrowDown}');
|
||||
await tick();
|
||||
await pressKey(input, 'ArrowDown');
|
||||
|
||||
const afterNav = await input.element().getAttribute('aria-activedescendant');
|
||||
expect(afterNav).toBeTruthy();
|
||||
|
||||
@@ -174,7 +174,14 @@ describe('PersonMentionEditor — AC-1: typed text as displayName', () => {
|
||||
await expect.element(page.getByRole('option', { name: /Auguste Raddatz/ })).toBeVisible();
|
||||
});
|
||||
|
||||
await userEvent.click(page.getByRole('option', { name: /Auguste Raddatz/ }));
|
||||
// MentionDropdown handles selection via onmousedown (not onclick) to prevent
|
||||
// blurring the editor before the selection fires. userEvent.click() via CDP
|
||||
// does not reliably trigger Svelte 5's onmousedown handler when TipTap is
|
||||
// mounted — dispatch the MouseEvent directly from browser JS instead.
|
||||
const option = (await page
|
||||
.getByRole('option', { name: /Auguste Raddatz/ })
|
||||
.element()) as HTMLElement;
|
||||
option.dispatchEvent(new MouseEvent('mousedown', { bubbles: true, cancelable: true }));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(host.snapshot.mentionedPersons).toHaveLength(1);
|
||||
@@ -212,7 +219,10 @@ describe('PersonMentionEditor — AC-1: typed text as displayName', () => {
|
||||
await expect.element(page.getByRole('option', { name: /Auguste Raddatz/ })).toBeVisible();
|
||||
});
|
||||
|
||||
await userEvent.click(page.getByRole('option', { name: /Auguste Raddatz/ }));
|
||||
const option = (await page
|
||||
.getByRole('option', { name: /Auguste Raddatz/ })
|
||||
.element()) as HTMLElement;
|
||||
option.dispatchEvent(new MouseEvent('mousedown', { bubbles: true, cancelable: true }));
|
||||
|
||||
await vi.waitFor(() => {
|
||||
expect(host.snapshot.mentionedPersons).toEqual([{ personId: 'p-aug', displayName: 'Aug' }]);
|
||||
|
||||
@@ -9,6 +9,8 @@ const defaultProps = {
|
||||
icon: '✍',
|
||||
title: 'Unleserliche Wörter',
|
||||
body: 'Schreiben Sie [unleserlich].',
|
||||
// beispielInput is required for the → arrow to render (component: {#if beispielInput !== undefined})
|
||||
beispielInput: '[Original]',
|
||||
beispielOutput: '[unleserlich]'
|
||||
};
|
||||
|
||||
@@ -34,9 +36,12 @@ describe('RichtlinienRuleCard', () => {
|
||||
|
||||
it('renders beispielOutput in monospace with → arrow', async () => {
|
||||
render(RichtlinienRuleCard, { props: defaultProps });
|
||||
const mono = document.querySelector('code, [class*="font-mono"]');
|
||||
expect(mono).not.toBeNull();
|
||||
expect(mono!.textContent).toContain('[unleserlich]');
|
||||
// With both beispielInput and beispielOutput, the component renders two code elements:
|
||||
// [Input] → [Output]. querySelectorAll gets both; last one is the output.
|
||||
const codes = document.querySelectorAll('code, [class*="font-mono"]');
|
||||
expect(codes.length).toBeGreaterThanOrEqual(1);
|
||||
const outputCode = codes[codes.length - 1];
|
||||
expect(outputCode.textContent).toContain('[unleserlich]');
|
||||
await expect.element(page.getByText(/→/)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
|
||||
@@ -369,8 +369,7 @@ describe('TagInput – onTextInput callback', () => {
|
||||
const input = page.getByRole('textbox');
|
||||
await input.fill('Ka');
|
||||
await waitForFetch();
|
||||
const option = page.getByRole('option', { name: 'Kaufvertrag' });
|
||||
await option.click();
|
||||
((await page.getByRole('option', { name: 'Kaufvertrag' }).element()) as HTMLElement).click();
|
||||
await expect.poll(() => onTextInput.mock.calls.at(-1)).toEqual(['']);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -13,12 +13,14 @@ let {
|
||||
items,
|
||||
canWrite,
|
||||
error,
|
||||
total = 0,
|
||||
q = '',
|
||||
sort = 'DATE'
|
||||
}: {
|
||||
items: DocumentSearchItem[];
|
||||
canWrite: boolean;
|
||||
error?: string | null;
|
||||
total?: number;
|
||||
q?: string;
|
||||
sort?: SortMode;
|
||||
} = $props();
|
||||
@@ -77,6 +79,10 @@ function groupByReceiver(docItems: DocumentSearchItem[]) {
|
||||
</div>
|
||||
</div>
|
||||
{:else if items.length > 0}
|
||||
<!-- RESULT COUNT -->
|
||||
{#if total > 0}
|
||||
<p class="mb-2 text-sm text-ink-2">{total} Dokumente</p>
|
||||
{/if}
|
||||
<!-- GROUP CARDS -->
|
||||
{#each groups as group (group.label)}
|
||||
<div
|
||||
|
||||
@@ -26,8 +26,7 @@ export async function load({ fetch, locals }) {
|
||||
const api = createApiClient(fetch);
|
||||
const canManageUsers = hasPerm(user, 'ADMIN_USER');
|
||||
|
||||
// TODO: replace with a dedicated /api/admin/stats endpoint that returns counts only,
|
||||
// so the System page does not load full entity lists it does not render.
|
||||
// TODO(#453): replace with dedicated /api/admin/stats endpoint returning counts only
|
||||
const [usersResult, groupsResult, tagsResult] = await Promise.all([
|
||||
api.GET('/api/users'),
|
||||
api.GET('/api/groups'),
|
||||
|
||||
@@ -134,7 +134,13 @@ describe('EntityNavSection — flyout variant', () => {
|
||||
called = true;
|
||||
}
|
||||
});
|
||||
document.querySelector<HTMLAnchorElement>('a[href="/admin/users"]')!.click();
|
||||
const link = document.querySelector<HTMLAnchorElement>('a[href="/admin/users"]')!;
|
||||
// Prevent the browser from navigating the test iframe to /admin/users (which
|
||||
// would redirect to /login and kill the iframe connection). preventDefault()
|
||||
// on the capture phase suppresses navigation while still letting the Svelte
|
||||
// onclick handler (onFlyoutClick) run on the bubbling phase.
|
||||
link.addEventListener('click', (e) => e.preventDefault(), { capture: true, once: true });
|
||||
link.click();
|
||||
expect(called).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -76,7 +76,13 @@ describe('EntityNav — flyout', () => {
|
||||
document.querySelector<HTMLButtonElement>('[data-flyout-trigger]')!.click();
|
||||
await expect.element(page.getByRole('dialog')).toBeInTheDocument();
|
||||
const dialog = document.querySelector('[role="dialog"]')!;
|
||||
dialog.querySelector<HTMLAnchorElement>('a[href^="/admin/"]')!.click();
|
||||
const link = dialog.querySelector<HTMLAnchorElement>('a[href^="/admin/"]')!;
|
||||
// Prevent the browser from navigating the test iframe to /admin/... (which
|
||||
// would redirect to /login and kill the iframe connection). preventDefault()
|
||||
// on the capture phase suppresses navigation while still letting the Svelte
|
||||
// onclick handler (closeFlyout) run on the bubbling phase.
|
||||
link.addEventListener('click', (e) => e.preventDefault(), { capture: true, once: true });
|
||||
link.click();
|
||||
await expect.element(page.getByRole('dialog')).not.toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -4,7 +4,10 @@ import { page } from 'vitest/browser';
|
||||
import Page from './+page.svelte';
|
||||
|
||||
afterEach(cleanup);
|
||||
afterEach(() => vi.restoreAllMocks());
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks();
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
describe('Admin system page', () => {
|
||||
it('renders the backfill versions heading', async () => {
|
||||
@@ -52,7 +55,9 @@ describe('Admin system page — mass import card', () => {
|
||||
|
||||
it('renders the mass import heading', async () => {
|
||||
render(Page, {});
|
||||
await expect.element(page.getByText(/Massenimport/i)).toBeInTheDocument();
|
||||
// getByText(/Massenimport/i) would match both the H2 heading AND the thumbnail
|
||||
// description paragraph that mentions "Massenimport" — use heading role instead.
|
||||
await expect.element(page.getByRole('heading', { name: /Massenimport/i })).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it('renders the start import button when idle', async () => {
|
||||
@@ -66,9 +71,11 @@ describe('Admin system page — mass import card', () => {
|
||||
});
|
||||
|
||||
it('disables the start button and shows running state after click', async () => {
|
||||
// $effect calls fetchImportStatus() then fetchThumbnailStatus() on mount —
|
||||
// the mock must cover both before the POST trigger call.
|
||||
const fetchMock = vi
|
||||
.fn()
|
||||
// initial status fetch → IDLE
|
||||
// call 1: fetchImportStatus() on mount → IDLE
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
@@ -78,7 +85,20 @@ describe('Admin system page — mass import card', () => {
|
||||
startedAt: null
|
||||
})
|
||||
})
|
||||
// trigger POST → returns RUNNING immediately
|
||||
// call 2: fetchThumbnailStatus() on mount → IDLE (prevent thumbnail polling)
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'IDLE',
|
||||
message: '',
|
||||
total: 0,
|
||||
processed: 0,
|
||||
skipped: 0,
|
||||
failed: 0,
|
||||
startedAt: null
|
||||
})
|
||||
})
|
||||
// call 3: trigger POST → returns RUNNING
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
@@ -99,17 +119,33 @@ describe('Admin system page — mass import card', () => {
|
||||
});
|
||||
|
||||
it('shows done status and retry button after successful import', async () => {
|
||||
// Use mockResolvedValueOnce per call so thumbnail gets IDLE, not DONE.
|
||||
// Both cards in DONE state would render two "Erneut starten" buttons → strict mode.
|
||||
vi.stubGlobal(
|
||||
'fetch',
|
||||
vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'DONE',
|
||||
message: 'Import abgeschlossen.',
|
||||
processed: 42,
|
||||
startedAt: '2026-01-01T10:00:00'
|
||||
vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'DONE',
|
||||
message: 'Import abgeschlossen.',
|
||||
processed: 42,
|
||||
startedAt: '2026-01-01T10:00:00'
|
||||
})
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'IDLE',
|
||||
message: '',
|
||||
total: 0,
|
||||
processed: 0,
|
||||
skipped: 0,
|
||||
failed: 0,
|
||||
startedAt: null
|
||||
})
|
||||
})
|
||||
})
|
||||
);
|
||||
render(Page, {});
|
||||
await expect.element(page.getByText(/42 Dokumente/i)).toBeInTheDocument();
|
||||
@@ -117,17 +153,33 @@ describe('Admin system page — mass import card', () => {
|
||||
});
|
||||
|
||||
it('shows failed status and retry button on error', async () => {
|
||||
// Use mockResolvedValueOnce so thumbnail gets IDLE, not FAILED.
|
||||
// Both cards in FAILED state would render two identical error messages → strict mode.
|
||||
vi.stubGlobal(
|
||||
'fetch',
|
||||
vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'FAILED',
|
||||
message: 'Datei nicht gefunden.',
|
||||
processed: 0,
|
||||
startedAt: '2026-01-01T10:00:00'
|
||||
vi
|
||||
.fn()
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'FAILED',
|
||||
message: 'Datei nicht gefunden.',
|
||||
processed: 0,
|
||||
startedAt: '2026-01-01T10:00:00'
|
||||
})
|
||||
})
|
||||
.mockResolvedValueOnce({
|
||||
ok: true,
|
||||
json: async () => ({
|
||||
state: 'IDLE',
|
||||
message: '',
|
||||
total: 0,
|
||||
processed: 0,
|
||||
skipped: 0,
|
||||
failed: 0,
|
||||
startedAt: null
|
||||
})
|
||||
})
|
||||
})
|
||||
);
|
||||
render(Page, {});
|
||||
await expect.element(page.getByText(/Datei nicht gefunden/i)).toBeInTheDocument();
|
||||
|
||||
@@ -24,7 +24,8 @@ describe('CorrespondenzHero — headline and cross-link', () => {
|
||||
|
||||
it('renders a person typeahead input', async () => {
|
||||
render(CorrespondenzHero, { onSelectPerson: noop });
|
||||
await expect.element(page.getByTestId('conv-hero').getByRole('textbox')).toBeInTheDocument();
|
||||
// PersonTypeahead renders <input role="combobox">, not role="textbox"
|
||||
await expect.element(page.getByTestId('conv-hero').getByRole('combobox')).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -1,7 +1,12 @@
|
||||
import { vi, describe, it, expect, afterEach } from 'vitest';
|
||||
import { cleanup, render } from 'vitest-browser-svelte';
|
||||
import { page } from 'vitest/browser';
|
||||
import { createConfirmService, CONFIRM_KEY } from '$lib/shared/services/confirm.svelte.js';
|
||||
import {
|
||||
createConfirmService,
|
||||
CONFIRM_KEY,
|
||||
type ConfirmOptions,
|
||||
type ConfirmService
|
||||
} from '$lib/shared/services/confirm.svelte.js';
|
||||
import EditPage from './+page.svelte';
|
||||
|
||||
afterEach(cleanup);
|
||||
@@ -32,17 +37,40 @@ describe('Edit page — delete button', () => {
|
||||
});
|
||||
|
||||
it('opens a confirm dialog when the delete button is clicked', async () => {
|
||||
const service = createConfirmService();
|
||||
// vi.spyOn on a Svelte 5 compiled service object does not reliably track calls in
|
||||
// vitest-browser mode (signal scoping), so we use a plain mock object instead.
|
||||
let capturedOptions: ConfirmOptions | null = null;
|
||||
let settleRef: ((value: boolean) => void) | null = null;
|
||||
const mockService: ConfirmService = {
|
||||
confirm(opts) {
|
||||
capturedOptions = opts;
|
||||
return new Promise<boolean>((resolve) => {
|
||||
settleRef = resolve;
|
||||
});
|
||||
},
|
||||
get options(): ConfirmOptions | null {
|
||||
return null;
|
||||
},
|
||||
settle(value) {
|
||||
settleRef?.(value);
|
||||
}
|
||||
};
|
||||
|
||||
render(EditPage, {
|
||||
props: { data: { document: makeDocument() }, form: null },
|
||||
context: new Map([[CONFIRM_KEY, service]])
|
||||
context: new Map([[CONFIRM_KEY, mockService]])
|
||||
});
|
||||
|
||||
await page.getByRole('button', { name: /löschen/i }).click();
|
||||
// The confirm service should have received an options object (dialog is open)
|
||||
expect(service.options).not.toBeNull();
|
||||
expect(service.options?.destructive).toBe(true);
|
||||
service.settle(false);
|
||||
// Playwright CDP click has latency that can exceed vi.waitFor's 1000ms deadline.
|
||||
// Dispatching the MouseEvent directly from browser-JS context is synchronous and
|
||||
// reliably triggers Svelte 5 onclick — same pattern as GeschichteEditor.svelte.spec.ts.
|
||||
const btn = (await page
|
||||
.getByRole('button', { name: /löschen/i })
|
||||
.element()) as HTMLButtonElement;
|
||||
btn.dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true }));
|
||||
expect(capturedOptions).not.toBeNull();
|
||||
expect(capturedOptions).toMatchObject({ destructive: true });
|
||||
settleRef?.(false);
|
||||
});
|
||||
|
||||
it('submits the delete form when the user confirms', async () => {
|
||||
|
||||
@@ -25,9 +25,9 @@ describe('Richtlinien page — structure', () => {
|
||||
await expect.element(wikiLink).toHaveAttribute('target', '_blank');
|
||||
await expect.element(wikiLink).toHaveAttribute('rel', 'noopener noreferrer');
|
||||
await expect.element(wikiLink).toHaveAttribute('referrerpolicy', 'no-referrer');
|
||||
// visible annotation (not sr-only)
|
||||
// icon communicates "opens new tab" visually; aria-label carries the text for a11y
|
||||
const link = document.querySelector('a[href*="wikipedia"]') as HTMLAnchorElement;
|
||||
expect(link.textContent).toContain('öffnet in neuem Tab');
|
||||
expect(link.getAttribute('aria-label')).toContain('öffnet in neuem Tab');
|
||||
});
|
||||
|
||||
it('renders Regeln h2 section', async () => {
|
||||
|
||||
@@ -1,11 +1,31 @@
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { cleanup, render } from 'vitest-browser-svelte';
|
||||
import { page, userEvent } from 'vitest/browser';
|
||||
import { createRawSnippet } from 'svelte';
|
||||
|
||||
vi.mock('$env/static/public', () => ({ PUBLIC_NOTIFICATION_POLL_MS: '60000' }));
|
||||
|
||||
afterEach(cleanup);
|
||||
// NotificationBell calls notificationStore.init() on mount, which creates an
|
||||
// EventSource and immediately fetches the unread count. In the test environment
|
||||
// the SSE connection fails (no backend), triggering onerror → another fetch.
|
||||
// If that fetch returns 401, notifications.svelte.ts calls
|
||||
// window.location.href = '/login', navigating the test iframe and breaking the
|
||||
// Playwright connection. Stubbing fetch to return 200 keeps it in-check.
|
||||
beforeEach(() => {
|
||||
vi.stubGlobal(
|
||||
'fetch',
|
||||
vi.fn().mockResolvedValue({
|
||||
ok: true,
|
||||
status: 200,
|
||||
json: vi.fn().mockResolvedValue({ count: 0, content: [] })
|
||||
})
|
||||
);
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
cleanup();
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
const emptySnippet = createRawSnippet(() => ({ render: () => '<span></span>' }));
|
||||
import Layout from './+layout.svelte';
|
||||
|
||||
Reference in New Issue
Block a user