marcel/familienarchiv
1
0
Fork 0
Code Issues 121 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

refactor(geschichte): use formatPublishedAt() in GeschichteListRow — remove DRY violation
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 3m2s
Details
CI / OCR Service Tests (pull_request) Successful in 23s
Details
CI / Backend Unit Tests (pull_request) Successful in 3m59s
Details
CI / fail2ban Regex (pull_request) Successful in 46s
Details
CI / Semgrep Security Scan (pull_request) Successful in 23s
Details
CI / Compose Bucket Idempotency (pull_request) Successful in 1m6s
Details

Browse Source 
The inline publishedAt $derived.by() duplicated the exact logic that
formatPublishedAt() in utils.ts encapsulates. Replace it with the
shared helper and drop the now-unused formatDate import.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-06-09 09:09:53 +02:00
parent f004b1f2a6
commit c50f04bafa
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/lib/geschichte/GeschichteListRow.svelte
View File

@@ -1,8 +1,7 @@
<script lang="ts"> <script lang="ts">
import { m } from '$lib/paraglide/messages.js'; import { m } from '$lib/paraglide/messages.js';
import { plainExcerpt } from '$lib/shared/utils/extractText'; import { plainExcerpt } from '$lib/shared/utils/extractText';
import { formatDate } from '$lib/shared/utils/date'; import { formatAuthorName, formatPublishedAt } from './utils';
import { formatAuthorName } from './utils';
import type { components } from '$lib/generated/api'; import type { components } from '$lib/generated/api';
type GeschichteRow = Pick< type GeschichteRow = Pick<
@@ -14,10 +13,7 @@ let { geschichte }: { geschichte: GeschichteRow } = $props();
const isJourney = $derived(geschichte.type === 'JOURNEY'); const isJourney = $derived(geschichte.type === 'JOURNEY');
const publishedAt = $derived.by(() => { const publishedAt = $derived(formatPublishedAt(geschichte.publishedAt, 'short'));
if (!geschichte.publishedAt) return null;
return formatDate(geschichte.publishedAt.slice(0, 10), 'short');
});
const authorName = $derived(formatAuthorName(geschichte.author)); const authorName = $derived(formatAuthorName(geschichte.author));
</script> </script>