From cb61e63b0202178bbdaea9acb33c412a09504c47 Mon Sep 17 00:00:00 2001 From: Marcel Date: Mon, 1 Jun 2026 21:15:03 +0200 Subject: [PATCH] =?UTF-8?q?fix(document):=20polish=20PDF=20error=20state?= =?UTF-8?q?=20=E2=80=94=20warning=20icon,=2044px=20target,=20warmer=20copy?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address the remaining UI/UX polish: add a warning-triangle icon so the failure is signalled by shape, not colour alone (WCAG 1.4.1); give the recovery download link a full 44px tap/focus target (inline-flex min-h-[44px]); and soften the message copy in de/en/es. Addresses re-review: Leonie (colour-only, undersized link, copy warmth). Refs #708 Co-Authored-By: Claude Opus 4.8 --- frontend/messages/de.json | 2 +- frontend/messages/en.json | 2 +- frontend/messages/es.json | 2 +- .../src/lib/document/viewer/PdfViewer.svelte | 17 ++++++++++++++++- 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/frontend/messages/de.json b/frontend/messages/de.json index 73bcbfdf..21fc48aa 100644 --- a/frontend/messages/de.json +++ b/frontend/messages/de.json @@ -126,7 +126,7 @@ "doc_label_summary": "Zusammenfassung", "doc_loading": "Lade Dokument...", "doc_download_link": "Direkter Download versuchen", - "doc_render_failed": "Dieser Scan konnte nicht angezeigt werden.", + "doc_render_failed": "Dieser Scan ließ sich hier leider nicht anzeigen.", "doc_no_scan": "Kein Scan vorhanden", "persons_heading": "Personenverzeichnis", "persons_subtitle": "Durchsuchen Sie den Index aller erfassten Personen im Familienarchiv.", diff --git a/frontend/messages/en.json b/frontend/messages/en.json index 05623f84..55b12b51 100644 --- a/frontend/messages/en.json +++ b/frontend/messages/en.json @@ -126,7 +126,7 @@ "doc_label_summary": "Summary", "doc_loading": "Loading document...", "doc_download_link": "Try direct download", - "doc_render_failed": "This scan could not be displayed.", + "doc_render_failed": "This scan couldn’t be displayed here.", "doc_no_scan": "No scan available", "persons_heading": "Person directory", "persons_subtitle": "Browse the index of all recorded persons in the family archive.", diff --git a/frontend/messages/es.json b/frontend/messages/es.json index 59d7da06..cdebf5db 100644 --- a/frontend/messages/es.json +++ b/frontend/messages/es.json @@ -126,7 +126,7 @@ "doc_label_summary": "Resumen", "doc_loading": "Cargando documento...", "doc_download_link": "Intentar descarga directa", - "doc_render_failed": "No se pudo mostrar este escaneo.", + "doc_render_failed": "No se pudo mostrar este escaneo aquí.", "doc_no_scan": "No hay escaneo disponible", "persons_heading": "Directorio de personas", "persons_subtitle": "Explore el índice de todas las personas registradas en el archivo familiar.", diff --git a/frontend/src/lib/document/viewer/PdfViewer.svelte b/frontend/src/lib/document/viewer/PdfViewer.svelte index c93a31e6..5164178d 100644 --- a/frontend/src/lib/document/viewer/PdfViewer.svelte +++ b/frontend/src/lib/document/viewer/PdfViewer.svelte @@ -178,12 +178,27 @@ function handleAnnotationClick(id: string) { role="alert" class="flex h-full w-full flex-col items-center justify-center gap-3 bg-pdf-bg px-4 text-center text-ink-3" > + +

{m.doc_render_failed()}

{m.doc_download_link()}