fix(frontend): enforce lint locally and in CI, fix all pre-existing violations

## Pre-commit hook - Add .husky/pre-commit at repo root: runs `cd frontend && npm run lint` - Update prepare script in package.json to auto-configure git hooks path on npm install (git -C .. config core.hooksPath .husky) - Add lint step to CI unit-tests job so it catches issues before tests run - Add generated dirs to .prettierignore (paraglide_bak*, test-results, .auth) - Add src/lib/paraglide_bak* to .gitignore so ESLint can ignore them ## ESLint fixes (all pre-existing) - Disable svelte/no-navigation-without-resolve: false positive in SvelteKit (rule targets Svelte 5 standalone routing, not SvelteKit <a href>) - Fix svelte/require-each-key: add (item.id)/(item) keys to all {#each} blocks across 10 files — improves Svelte reconciliation performance - Fix svelte/prefer-writable-derived in PersonTypeahead: $state+$effect → $derived - Fix svelte/prefer-svelte-reactivity: URLSearchParams → SvelteURLSearchParams, Map → SvelteMap (enables Svelte reactive tracking) - Fix @typescript-eslint/no-unused-vars: remove dead imports/variables ## Prettier - Run npm run format to bring all source files in line with .prettierrc Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-20 15:55:42 +01:00
parent 28dea45cc3
commit db2fc33e99
53 changed files with 2522 additions and 2061 deletions
--- a/frontend/src/routes/persons/+page.server.ts
+++ b/frontend/src/routes/persons/+page.server.ts
@@ -3,16 +3,16 @@ import { createApiClient } from '$lib/api.server';
 import { getErrorMessage } from '$lib/errors';

 export async function load({ url, fetch }) {
-    const q = url.searchParams.get('q') || '';
-    const api = createApiClient(fetch);
+	const q = url.searchParams.get('q') || '';
+	const api = createApiClient(fetch);

-    const result = await api.GET('/api/persons', {
-        params: { query: { q: q || undefined } }
-    });
+	const result = await api.GET('/api/persons', {
+		params: { query: { q: q || undefined } }
+	});

-    if (!result.response.ok) {
-        throw error(result.response.status, getErrorMessage(undefined));
-    }
+	if (!result.response.ok) {
+		throw error(result.response.status, getErrorMessage(undefined));
+	}

-    return { persons: result.data!, q };
+	return { persons: result.data!, q };
 }
--- a/frontend/src/routes/persons/+page.svelte
+++ b/frontend/src/routes/persons/+page.svelte
@@ -26,13 +26,18 @@ function handleSearch(e: Event) {
 				{m.persons_subtitle()}
 			</p>
 			{#if data.canWrite}
-			<a
-				href="/persons/new"
-				class="mt-3 inline-flex items-center gap-1 text-sm font-medium text-brand-navy/60 transition-colors hover:text-brand-navy"
-			>
-				<img src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Add/Add-General-MD.svg" alt="" aria-hidden="true" class="h-4 w-4" />
-				{m.persons_btn_new()}
-			</a>
+				<a
+					href="/persons/new"
+					class="mt-3 inline-flex items-center gap-1 text-sm font-medium text-brand-navy/60 transition-colors hover:text-brand-navy"
+				>
+					<img
+						src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Add/Add-General-MD.svg"
+						alt=""
+						aria-hidden="true"
+						class="h-4 w-4"
+					/>
+					{m.persons_btn_new()}
+				</a>
 			{/if}
 		</div>

@@ -51,7 +56,12 @@ function handleSearch(e: Event) {
 				<div
 					class="pointer-events-none absolute inset-y-0 right-0 flex items-center pr-3 text-gray-400"
 				>
-					<img src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Mag-Glass-MD.svg" alt="" aria-hidden="true" class="h-4 w-4 opacity-40" />
+					<img
+						src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Mag-Glass-MD.svg"
+						alt=""
+						aria-hidden="true"
+						class="h-4 w-4 opacity-40"
+					/>
 				</div>
 			</div>
 		</div>
@@ -64,14 +74,19 @@ function handleSearch(e: Event) {
 			<div
 				class="mb-3 flex h-12 w-12 items-center justify-center rounded-full bg-brand-sand/30 text-brand-navy"
 			>
-				<img src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Account-MD.svg" alt="" aria-hidden="true" class="h-6 w-6" />
+				<img
+					src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Account-MD.svg"
+					alt=""
+					aria-hidden="true"
+					class="h-6 w-6"
+				/>
 			</div>
 			<p class="font-serif text-lg text-brand-navy">{m.persons_empty_heading()}</p>
 			<p class="mt-1 font-sans text-sm text-gray-500">{m.persons_empty_text()}</p>
 		</div>
 	{:else}
 		<div class="grid grid-cols-1 gap-6 sm:grid-cols-2 md:grid-cols-3 lg:grid-cols-4">
-			{#each data.persons as person}
+			{#each data.persons as person (person.id)}
 				<a href="/persons/{person.id}" class="group block h-full">
 					<div
 						class="relative flex h-full items-center gap-4 overflow-hidden rounded border border-brand-sand bg-white p-6 shadow-sm transition-all duration-200 hover:border-brand-navy hover:shadow-md"
--- a/frontend/src/routes/persons/[id]/+page.server.ts
+++ b/frontend/src/routes/persons/[id]/+page.server.ts
@@ -3,78 +3,79 @@ import { createApiClient } from '$lib/api.server';
 import { getErrorMessage } from '$lib/errors';

 export async function load({ params, fetch }) {
-    const { id } = params;
-    const api = createApiClient(fetch);
+	const { id } = params;
+	const api = createApiClient(fetch);

-    const [personResult, sentDocsResult, receivedDocsResult] = await Promise.all([
-        api.GET('/api/persons/{id}', { params: { path: { id } } }),
-        api.GET('/api/persons/{id}/documents', { params: { path: { id } } }),
-        api.GET('/api/persons/{id}/received-documents', { params: { path: { id } } })
-    ]);
+	const [personResult, sentDocsResult, receivedDocsResult] = await Promise.all([
+		api.GET('/api/persons/{id}', { params: { path: { id } } }),
+		api.GET('/api/persons/{id}/documents', { params: { path: { id } } }),
+		api.GET('/api/persons/{id}/received-documents', { params: { path: { id } } })
+	]);

-    if (!personResult.response.ok) {
-        const code = (personResult.error as unknown as { code?: string })?.code;
-        throw error(personResult.response.status, getErrorMessage(code));
-    }
+	if (!personResult.response.ok) {
+		const code = (personResult.error as unknown as { code?: string })?.code;
+		throw error(personResult.response.status, getErrorMessage(code));
+	}

-    return {
-        person: personResult.data!,
-        sentDocuments: sentDocsResult.data ?? [],
-        receivedDocuments: receivedDocsResult.data ?? []
-    };
+	return {
+		person: personResult.data!,
+		sentDocuments: sentDocsResult.data ?? [],
+		receivedDocuments: receivedDocsResult.data ?? []
+	};
 }

 export const actions = {
-    update: async ({ request, params, fetch }) => {
-        const formData = await request.formData();
-        const firstName = formData.get('firstName')?.toString().trim();
-        const lastName = formData.get('lastName')?.toString().trim();
-        const alias = formData.get('alias')?.toString().trim() || undefined;
-        const notes = formData.get('notes')?.toString().trim() || undefined;
-        const birthYear = formData.get('birthYear')?.toString().trim() || undefined;
-        const deathYear = formData.get('deathYear')?.toString().trim() || undefined;
+	update: async ({ request, params, fetch }) => {
+		const formData = await request.formData();
+		const firstName = formData.get('firstName')?.toString().trim();
+		const lastName = formData.get('lastName')?.toString().trim();
+		const alias = formData.get('alias')?.toString().trim() || undefined;
+		const notes = formData.get('notes')?.toString().trim() || undefined;
+		const birthYear = formData.get('birthYear')?.toString().trim() || undefined;
+		const deathYear = formData.get('deathYear')?.toString().trim() || undefined;

-        if (!firstName || !lastName) {
-            return fail(400, { updateError: 'Vor- und Nachname sind Pflichtfelder.' });
-        }
+		if (!firstName || !lastName) {
+			return fail(400, { updateError: 'Vor- und Nachname sind Pflichtfelder.' });
+		}

-        const api = createApiClient(fetch);
-        const { error: apiError } = await api.PUT('/api/persons/{id}', {
-            params: { path: { id: params.id } },
-            body: {
-                firstName, lastName,
-                ...(alias ? { alias } : {}),
-                ...(notes ? { notes } : {}),
-                ...(birthYear ? { birthYear } : {}),
-                ...(deathYear ? { deathYear } : {})
-            }
-        });
+		const api = createApiClient(fetch);
+		const { error: apiError } = await api.PUT('/api/persons/{id}', {
+			params: { path: { id: params.id } },
+			body: {
+				firstName,
+				lastName,
+				...(alias ? { alias } : {}),
+				...(notes ? { notes } : {}),
+				...(birthYear ? { birthYear } : {}),
+				...(deathYear ? { deathYear } : {})
+			}
+		});

-        if (apiError) {
-            return fail(400, { updateError: 'Speichern fehlgeschlagen.' });
-        }
+		if (apiError) {
+			return fail(400, { updateError: 'Speichern fehlgeschlagen.' });
+		}

-        return { updated: true };
-    },
+		return { updated: true };
+	},

-    merge: async ({ request, params, fetch }) => {
-        const formData = await request.formData();
-        const targetPersonId = formData.get('targetPersonId')?.toString();
+	merge: async ({ request, params, fetch }) => {
+		const formData = await request.formData();
+		const targetPersonId = formData.get('targetPersonId')?.toString();

-        if (!targetPersonId) {
-            return fail(400, { mergeError: 'Bitte eine Zielperson auswählen.' });
-        }
+		if (!targetPersonId) {
+			return fail(400, { mergeError: 'Bitte eine Zielperson auswählen.' });
+		}

-        const api = createApiClient(fetch);
-        const { error: apiError } = await api.POST('/api/persons/{id}/merge', {
-            params: { path: { id: params.id } },
-            body: { targetPersonId }
-        });
+		const api = createApiClient(fetch);
+		const { error: apiError } = await api.POST('/api/persons/{id}/merge', {
+			params: { path: { id: params.id } },
+			body: { targetPersonId }
+		});

-        if (apiError) {
-            return fail(400, { mergeError: 'Zusammenführen fehlgeschlagen.' });
-        }
+		if (apiError) {
+			return fail(400, { mergeError: 'Zusammenführen fehlgeschlagen.' });
+		}

-        throw redirect(303, `/persons/${targetPersonId}`);
-    }
+		throw redirect(303, `/persons/${targetPersonId}`);
+	}
 };
--- a/frontend/src/routes/persons/[id]/+page.svelte
+++ b/frontend/src/routes/persons/[id]/+page.svelte
--- a/frontend/src/routes/persons/new/+page.server.ts
+++ b/frontend/src/routes/persons/new/+page.server.ts
@@ -2,8 +2,11 @@ import { error, fail, redirect } from '@sveltejs/kit';
 import { createApiClient } from '$lib/api.server';

 export async function load({ locals }: { locals: App.Locals }) {
-    const canWrite = locals.user?.groups?.some((g: { permissions: string[] }) => g.permissions.includes('WRITE_ALL')) ?? false;
-    if (!canWrite) throw error(403, 'Forbidden');
+	const canWrite =
+		locals.user?.groups?.some((g: { permissions: string[] }) =>
+			g.permissions.includes('WRITE_ALL')
+		) ?? false;
+	if (!canWrite) throw error(403, 'Forbidden');
 }

 export const actions = {