marcel/familienarchiv
1
0
Fork 0
Code Issues 118 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(journey-item-row): update JourneyItemRow spec to match new aria-label
All checks were successful
CI / Unit & Component Tests (pull_request) Successful in 3m22s
Details
CI / OCR Service Tests (pull_request) Successful in 23s
Details
CI / Backend Unit Tests (pull_request) Successful in 3m48s
Details
CI / fail2ban Regex (pull_request) Successful in 44s
Details
CI / Semgrep Security Scan (pull_request) Successful in 22s
Details
CI / Compose Bucket Idempotency (pull_request) Successful in 1m7s
Details

Browse Source 
The 'remove confirm' tests were still finding the remove button by the
old label ('Wirklich entfernen?'). After the aria-label change the
button is named 'Eintrag entfernen'; the visible confirmation text
'Wirklich entfernen?' in the DOM is unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-06-09 15:07:47 +02:00
parent 1b2776aa89
commit db4a5c0028
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/lib/geschichte/JourneyItemRow.svelte.spec.ts
View File

@@ -87,7 +87,7 @@ describe('JourneyItemRow — remove confirm', () => {
}); });
// Click remove (x button) // Click remove (x button)
await userEvent.click(page.getByRole('button', { name: 'Wirklich entfernen?' })); await userEvent.click(page.getByRole('button', { name: 'Eintrag entfernen' }));
await expect.element(page.getByText('Wirklich entfernen?')).toBeInTheDocument(); await expect.element(page.getByText('Wirklich entfernen?')).toBeInTheDocument();
await expect.element(page.getByRole('button', { name: 'Bestätigen' })).toBeInTheDocument(); await expect.element(page.getByRole('button', { name: 'Bestätigen' })).toBeInTheDocument();
@@ -100,13 +100,13 @@ describe('JourneyItemRow — remove confirm', () => {
...defaultProps({ onRemove }) ...defaultProps({ onRemove })
}); });
await userEvent.click(page.getByRole('button', { name: 'Wirklich entfernen?' })); await userEvent.click(page.getByRole('button', { name: 'Eintrag entfernen' }));
await userEvent.click(page.getByRole('button', { name: 'Abbrechen' })); await userEvent.click(page.getByRole('button', { name: 'Abbrechen' }));
expect(onRemove).not.toHaveBeenCalled(); expect(onRemove).not.toHaveBeenCalled();
// The remove button should be back // The remove button should be back
await expect await expect
.element(page.getByRole('button', { name: 'Wirklich entfernen?' })) .element(page.getByRole('button', { name: 'Eintrag entfernen' }))
.toBeInTheDocument(); .toBeInTheDocument();
}); });
}); });