From dbf7f0bc1613e43c7123837a6ffc2844353a914c Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Wed, 15 Apr 2026 13:13:21 +0200
Subject: [PATCH] fix(fileloader): revoke blob URLs before re-assignment and on
 destroy

Calling loadFile a second time previously leaked the previous object URL.
Add URL.revokeObjectURL(fileUrl) before creating a new one and in
onDestroy so all URLs are freed. Revoke behavior will be covered by the
useFileLoader hook tests in the next commit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 frontend/src/routes/documents/[id]/+page.svelte | 7 ++++++-
 frontend/src/routes/enrich/[id]/+page.svelte    | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/frontend/src/routes/documents/[id]/+page.svelte b/frontend/src/routes/documents/[id]/+page.svelte
index 49a5cd4b..4df5a87b 100644
--- a/frontend/src/routes/documents/[id]/+page.svelte
+++ b/frontend/src/routes/documents/[id]/+page.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-import { onMount } from 'svelte';
+import { onMount, onDestroy } from 'svelte';
 import { m } from '$lib/paraglide/messages.js';
 import DocumentTopBar from '$lib/components/DocumentTopBar.svelte';
 import DocumentViewer from '$lib/components/DocumentViewer.svelte';
@@ -31,6 +31,7 @@ $effect(() => {
 async function loadFile(id: string) {
 	isLoading = true;
 	fileError = '';
+	if (fileUrl) URL.revokeObjectURL(fileUrl);
 	fileUrl = '';
 
 	try {
@@ -51,6 +52,10 @@ async function loadFile(id: string) {
 	}
 }
 
+onDestroy(() => {
+	if (fileUrl) URL.revokeObjectURL(fileUrl);
+});
+
 // ── Mode state ───────────────────────────────────────────────────────────────
 
 let transcribeMode = $state(false);
diff --git a/frontend/src/routes/enrich/[id]/+page.svelte b/frontend/src/routes/enrich/[id]/+page.svelte
index 02a147c3..f27f8266 100644
--- a/frontend/src/routes/enrich/[id]/+page.svelte
+++ b/frontend/src/routes/enrich/[id]/+page.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 import { enhance } from '$app/forms';
-import { onMount, untrack } from 'svelte';
+import { onMount, onDestroy, untrack } from 'svelte';
 import { m } from '$lib/paraglide/messages.js';
 import DocumentViewer from '$lib/components/DocumentViewer.svelte';
 import WhoWhenSection from '$lib/components/document/WhoWhenSection.svelte';
@@ -34,6 +34,7 @@ $effect(() => {
 async function loadFile(id: string) {
 	isLoading = true;
 	fileError = '';
+	if (fileUrl) URL.revokeObjectURL(fileUrl);
 	fileUrl = '';
 	try {
 		const response = await fetch(`/api/documents/${id}/file`);
@@ -47,6 +48,10 @@ async function loadFile(id: string) {
 	}
 }
 
+onDestroy(() => {
+	if (fileUrl) URL.revokeObjectURL(fileUrl);
+});
+
 // Form state
 let tags = $state(untrack(() => doc.tags?.map((t: { name: string }) => t.name) ?? []));
 let senderId = $state(untrack(() => doc.sender?.id ?? ''));