From dc366ed403a6001c1a9f3242ae146beeda0e05a0 Mon Sep 17 00:00:00 2001
From: Marcel <marcel@familienarchiv>
Date: Sun, 7 Jun 2026 00:58:03 +0200
Subject: [PATCH] docs(search): add detached-entity safety comment in
 resolveTags

Addresses @Markus review: tags fetched by findByNameContaining live outside
any transaction; Hibernate's dirty-check never fires on them. The comment
removes the ambiguity for cold readers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .../org/raddatz/familienarchiv/search/NlQueryParserService.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/backend/src/main/java/org/raddatz/familienarchiv/search/NlQueryParserService.java b/backend/src/main/java/org/raddatz/familienarchiv/search/NlQueryParserService.java
index 41d3dbd2..35e52994 100644
--- a/backend/src/main/java/org/raddatz/familienarchiv/search/NlQueryParserService.java
+++ b/backend/src/main/java/org/raddatz/familienarchiv/search/NlQueryParserService.java
@@ -161,6 +161,7 @@ public class NlQueryParserService {
                 ? new ArrayList<>(seen).subList(0, MAX_RESOLVED_TAGS)
                 : new ArrayList<>(seen);
 
+        // safe: entities are detached here; mutation is for DTO projection only, no dirty-check fires
         tagService.resolveEffectiveColors(capped);
 
         List<TagHint> hints = capped.stream()