marcel/familienarchiv
1
0
Fork 0
Code Issues 119 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

docs(search): add detached-entity safety comment in resolveTags

Browse Source 
Addresses @Markus review: tags fetched by findByNameContaining live outside
any transaction; Hibernate's dirty-check never fires on them. The comment
removes the ambiguity for cold readers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-06-07 00:58:03 +02:00
parent 64b7b2315d
commit dc366ed403
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
backend/src/main/java/org/raddatz/familienarchiv/search/NlQueryParserService.java
View File

@@ -161,6 +161,7 @@ public class NlQueryParserService {
? new ArrayList<>(seen).subList(0, MAX_RESOLVED_TAGS) ? new ArrayList<>(seen).subList(0, MAX_RESOLVED_TAGS)
: new ArrayList<>(seen); : new ArrayList<>(seen);
// safe: entities are detached here; mutation is for DTO projection only, no dirty-check fires
tagService.resolveEffectiveColors(capped); tagService.resolveEffectiveColors(capped);
List<TagHint> hints = capped.stream() List<TagHint> hints = capped.stream()