marcel/familienarchiv
1
0
Fork 0
Code Issues 105 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(person-mention): WCAG 1.4.11 contrast for mention pill and dropdown ring

Browse Source 
Two non-text-contrast failures, both flagged by Leonie #5621:

1. PersonMentionEditor mention pill: decoration-brand-mint (#A6DAD8) on
   white is ≈1.7:1 — fails the 3:1 minimum for meaningful UI indicators.
   Switch to decoration-ink/50, which matches the read-mode .person-mention
   rule (≈6.4:1) and keeps a unified underline language across modes.

2. MentionDropdown highlighted-row ring: ring-brand-mint on bg-brand-mint/20
   is ≈2.5:1 — same failure class. Switch to ring-brand-navy (≈14.5:1
   against the highlight background) so keyboard-driven selection has a
   clearly visible indicator.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-29 16:19:34 +02:00
parent ba88febc77
commit f1932fd5f6
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/lib/components/MentionDropdown.svelte
View File

@@ -127,7 +127,10 @@ function selectItem(item: Person) {
<div <div
class={[ class={[
'flex min-h-[44px] cursor-pointer flex-col gap-1 px-3 py-2.5 text-left hover:bg-canvas', 'flex min-h-[44px] cursor-pointer flex-col gap-1 px-3 py-2.5 text-left hover:bg-canvas',
i === highlightedIndex && 'bg-brand-mint/20 ring-2 ring-brand-mint ring-inset' // brand-mint ring (≈2.5:1 on white) fails WCAG 1.4.11 Non-Text
// Contrast for a meaningful keyboard-highlight indicator. brand-navy
// gives ~14.5:1 against the bg-brand-mint/20 row. Leonie #5621.
i === highlightedIndex && 'bg-brand-mint/20 ring-2 ring-brand-navy ring-inset'
]} ]}
role="option" role="option"
aria-selected={i === highlightedIndex} aria-selected={i === highlightedIndex}

5
frontend/src/lib/components/PersonMentionEditor.svelte
View File

@@ -103,6 +103,9 @@ onMount(() => {
}), }),
CustomMention.configure({ CustomMention.configure({
renderHTML({ node }) { renderHTML({ node }) {
// Underline color matches the read-mode .person-mention rule
// (ink at ~50% alpha) — brand-mint on white fails WCAG 1.4.11
// Non-Text Contrast (≈1.7:1, needs 3:1). Leonie #5621.
return [ return [
'span', 'span',
{ {
@@ -110,7 +113,7 @@ onMount(() => {
'data-person-id': node.attrs.personId, 'data-person-id': node.attrs.personId,
'data-display-name': node.attrs.displayName, 'data-display-name': node.attrs.displayName,
class: class:
'mention-token underline decoration-brand-mint underline-offset-2 text-brand-navy font-medium' 'mention-token underline decoration-ink/50 underline-offset-2 text-brand-navy font-medium'
}, },
`@${node.attrs.displayName}` `@${node.attrs.displayName}`
]; ];