From feadf372a07bb57465e50ddf575159148cb1b6e6 Mon Sep 17 00:00:00 2001 From: Marcel Date: Wed, 13 May 2026 08:02:26 +0200 Subject: [PATCH] refactor(confirm-service): normalise import spelling to no-extension form MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Production code referenced $lib/shared/services/confirm.svelte under two spellings — 4 files with the .js extension and one without. Standardise on the no-extension form to match Svelte 5 rune-module convention and the source file basename (confirm.svelte.ts). Why this matters: vitest browser mode's @vitest/browser-playwright resolves both spellings to the same module URL but registers a separate Playwright route per spelling. The route-cleanup logic only unregisters the latest, leaving an orphan that crashes the next session with "[birpc] rpc is closed, cannot call resolveManualMock". Fixed upstream in vitest PR #10267 (merged, not yet released). Normalising the spelling removes the trigger from our side. Refs: #553. Companion test-file changes follow in the next commit. Co-Authored-By: Claude Opus 4.7 (1M context) --- frontend/src/routes/+layout.svelte | 2 +- frontend/src/routes/admin/tags/[id]/TagDeleteGuard.svelte | 2 +- frontend/src/routes/documents/[id]/+page.svelte | 2 +- .../src/routes/persons/[id]/edit/NameHistoryEditCard.svelte | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/routes/+layout.svelte b/frontend/src/routes/+layout.svelte index 0984c941..2703ff9c 100644 --- a/frontend/src/routes/+layout.svelte +++ b/frontend/src/routes/+layout.svelte @@ -9,7 +9,7 @@ import NotificationBell from '$lib/notification/NotificationBell.svelte'; import AppNav from './AppNav.svelte'; import UserMenu from './UserMenu.svelte'; import ConfirmDialog from '$lib/shared/primitives/ConfirmDialog.svelte'; -import { provideConfirmService } from '$lib/shared/services/confirm.svelte.js'; +import { provideConfirmService } from '$lib/shared/services/confirm.svelte'; import { bulkSelectionStore } from '$lib/document/bulkSelection.svelte'; let { children, data } = $props(); diff --git a/frontend/src/routes/admin/tags/[id]/TagDeleteGuard.svelte b/frontend/src/routes/admin/tags/[id]/TagDeleteGuard.svelte index 84c64fef..1b65388e 100644 --- a/frontend/src/routes/admin/tags/[id]/TagDeleteGuard.svelte +++ b/frontend/src/routes/admin/tags/[id]/TagDeleteGuard.svelte @@ -1,7 +1,7 @@