marcel/familienarchiv
1
0
Fork 0
Code Issues 111 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(persons): createPerson(DTO) rejects SKIP with INVALID_PERSON_TYPE

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-25 20:57:15 +02:00
parent 6c117611b8
commit fef021bf51
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
backend/src/main/java/org/raddatz/familienarchiv/service/PersonService.java
View File

@@ -109,6 +109,9 @@ public class PersonService {
@Transactional @Transactional
public Person createPerson(PersonUpdateDTO dto) { public Person createPerson(PersonUpdateDTO dto) {
if (dto.getPersonType() == PersonType.SKIP) {
throw DomainException.badRequest(ErrorCode.INVALID_PERSON_TYPE, "SKIP is not a valid person type for manual creation");
}
validateYears(dto.getBirthYear(), dto.getDeathYear()); validateYears(dto.getBirthYear(), dto.getDeathYear());
Person person = Person.builder() Person person = Person.builder()
.personType(dto.getPersonType()) .personType(dto.getPersonType())

11
backend/src/test/java/org/raddatz/familienarchiv/service/PersonServiceTest.java
View File

@@ -128,6 +128,17 @@ class PersonServiceTest {
assertThat(result.getPersonType()).isEqualTo(PersonType.INSTITUTION); assertThat(result.getPersonType()).isEqualTo(PersonType.INSTITUTION);
} }
@Test
void createPerson_dto_throwsInvalidPersonType_whenSkip() {
PersonUpdateDTO dto = new PersonUpdateDTO();
dto.setFirstName("Anna"); dto.setLastName("Test"); dto.setPersonType(PersonType.SKIP);
assertThatThrownBy(() -> personService.createPerson(dto))
.isInstanceOf(DomainException.class)
.extracting(e -> ((DomainException) e).getStatus().value())
.isEqualTo(400);
}
@Test @Test
void createPerson_dto_persistsTitle() { void createPerson_dto_persistsTitle() {
when(personRepository.save(any())).thenAnswer(inv -> inv.getArgument(0)); when(personRepository.save(any())).thenAnswer(inv -> inv.getArgument(0));