marcel/familienarchiv
1
0
Fork 0
Code Issues 112 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(autosave): rename flushViaBeacon → flushOnUnload; add void to fire-and-forget fetch

Browse Source 
The sendBeacon name was misleading after switching to keepalive fetch.
Also adds a test to confirm flush is a no-op when pendingTexts is empty.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Marcel
2026-04-22 16:46:58 +02:00
committed by marcel
parent c9dd3f8e78
commit ff0bb89297
3 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
frontend/src/lib/hooks/__tests__/useBlockAutoSave.svelte.test.ts
View File

@@ -83,7 +83,7 @@ describe('createBlockAutoSave', () => {
});
});
describe('flushViaBeacon', () => {
describe('flushOnUnload', () => {
let mockFetch: Mock;
beforeEach(() => {
@@ -103,7 +103,7 @@ describe('flushViaBeacon', () => {
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
as.handleTextChange('block-1', 'hello');
as.handleTextChange('block-2', 'world');
as.flushViaBeacon();
as.flushOnUnload();
expect(mockFetch).toHaveBeenCalledTimes(2);
expect(mockFetch).toHaveBeenCalledWith(
@@ -128,14 +128,14 @@ describe('flushViaBeacon', () => {
const sendBeaconSpy = vi.spyOn(navigator, 'sendBeacon').mockReturnValue(true);
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
as.handleTextChange('block-1', 'text');
as.flushViaBeacon();
as.flushOnUnload();
expect(sendBeaconSpy).not.toHaveBeenCalled();
});
it('does nothing when there are no pending edits', () => {
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
as.flushViaBeacon();
as.flushOnUnload();
expect(mockFetch).not.toHaveBeenCalled();
});
@@ -143,9 +143,21 @@ describe('flushViaBeacon', () => {
it('cancels the debounce timer so saveFn is not also called', async () => {
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
as.handleTextChange('block-1', 'text');
as.flushViaBeacon();
as.flushOnUnload();
await vi.advanceTimersByTimeAsync(2000);
expect(mockSaveFn).not.toHaveBeenCalled();
});
it('does not send fetch if debounce already fired and pendingTexts is empty', async () => {
const as = createBlockAutoSave({ saveFn: mockSaveFn, documentId: 'doc-1' });
as.handleTextChange('block-1', 'text');
await vi.advanceTimersByTimeAsync(1500);
// debounce has fired; pendingTexts should be empty now
mockFetch.mockClear();
as.flushOnUnload();
expect(mockFetch).not.toHaveBeenCalled();
});
});