test(persons): assert error code in createPerson_returns400_whenPersonTypeIsSkip

Adds jsonPath("$.code").value("INVALID_PERSON_TYPE") to verify the full
error response shape, not just the HTTP status.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

backend/src/test/java/org/raddatz/familienarchiv/controller/PersonControllerTest.java

@@ -272,7 +272,8 @@ class PersonControllerTest {
         mockMvc.perform(post("/api/persons")
                         .contentType(MediaType.APPLICATION_JSON)
                         .content("{\"lastName\":\"Müller\",\"personType\":\"SKIP\"}"))
-                .andExpect(status().isBadRequest());
+                .andExpect(status().isBadRequest())
+                .andExpect(jsonPath("$.code").value("INVALID_PERSON_TYPE"));
     }
 
     // ─── PUT /api/persons/{id} ────────────────────────────────────────────────

frontend/messages/de.json

@@ -540,6 +540,8 @@
 	"person_alias_btn_delete": "Entfernen",
 	"error_alias_not_found": "Der Namensalias wurde nicht gefunden.",
 	"error_invalid_person_type": "Der angegebene Personentyp ist ungültig.",
+	"validation_last_name_required": "Nachname ist Pflichtfeld.",
+	"validation_first_name_required": "Vorname ist Pflichtfeld.",
 	"error_ocr_service_unavailable": "Der OCR-Dienst ist nicht verfügbar.",
 	"error_ocr_job_not_found": "Der OCR-Auftrag wurde nicht gefunden.",
 	"error_ocr_document_not_uploaded": "Das Dokument hat keine Datei — OCR ist nicht möglich.",

frontend/messages/en.json

@@ -540,6 +540,8 @@
 	"person_alias_btn_delete": "Remove",
 	"error_alias_not_found": "The name alias was not found.",
 	"error_invalid_person_type": "The specified person type is not valid.",
+	"validation_last_name_required": "Last name is required.",
+	"validation_first_name_required": "First name is required.",
 	"error_ocr_service_unavailable": "The OCR service is not available.",
 	"error_ocr_job_not_found": "The OCR job was not found.",
 	"error_ocr_document_not_uploaded": "The document has no file — OCR is not possible.",

frontend/messages/es.json

@@ -540,6 +540,8 @@
 	"person_alias_btn_delete": "Eliminar",
 	"error_alias_not_found": "No se encontro el alias de nombre.",
 	"error_invalid_person_type": "El tipo de persona especificado no es válido.",
+	"validation_last_name_required": "El apellido es obligatorio.",
+	"validation_first_name_required": "El nombre es obligatorio.",
 	"error_ocr_service_unavailable": "El servicio OCR no está disponible.",
 	"error_ocr_job_not_found": "No se encontró el trabajo OCR.",
 	"error_ocr_document_not_uploaded": "El documento no tiene archivo — OCR no es posible.",

frontend/src/lib/actions/radioGroupNav.ts

@@ -1,4 +1,9 @@
-export function radioGroupNav(node: HTMLElement): { destroy: () => void } {
+export function radioGroupNav(
+	node: HTMLElement,
+	onChange?: (value: string) => void
+): { destroy: () => void; update: (onChange?: (value: string) => void) => void } {
+	let onChangeFn = onChange;
+
 	function getRadios(): HTMLElement[] {
 		return Array.from(node.querySelectorAll<HTMLElement>('[role="radio"]'));
 	}
@@ -16,11 +21,15 @@ export function radioGroupNav(node: HTMLElement): { destroy: () => void } {
 		radios[current].setAttribute('aria-checked', 'false');
 		radios[next].setAttribute('aria-checked', 'true');
 		radios[next].focus();
+		onChangeFn?.(radios[next].getAttribute('value') ?? '');
 	}
 
 	node.addEventListener('keydown', handleKeydown);
 
 	return {
+		update(newOnChange) {
+			onChangeFn = newOnChange;
+		},
 		destroy() {
 			node.removeEventListener('keydown', handleKeydown);
 		}

frontend/src/lib/components/PersonTypeSelector.svelte

@@ -2,9 +2,7 @@
 import { untrack } from 'svelte';
 import { radioGroupNav } from '$lib/actions/radioGroupNav';
 import { m } from '$lib/paraglide/messages.js';
-
-const TYPES = ['PERSON', 'INSTITUTION', 'GROUP', 'UNKNOWN'] as const;
-type PersonType = (typeof TYPES)[number];
+import { PERSON_TYPES as TYPES, type PersonType } from '$lib/person-validation';
 
 let {
 	value = 'PERSON',
@@ -16,6 +14,8 @@ let selected = $state<PersonType>(
 	untrack(() => (TYPES.includes(value as PersonType) ? (value as PersonType) : 'PERSON'))
 );
 
+let announcement = $state('');
+
 const labels: Record<PersonType, () => string> = {
 	PERSON: m.person_type_PERSON,
 	INSTITUTION: m.person_type_INSTITUTION,
@@ -25,15 +25,21 @@ const labels: Record<PersonType, () => string> = {
 
 function select(type: PersonType) {
 	selected = type;
+	announcement = m.a11y_type_changed({ type: labels[type]() });
 	onchange?.(type);
 }
 </script>
 
-<div role="radiogroup" class="grid grid-cols-2 gap-2 sm:grid-cols-4" use:radioGroupNav>
+<div
+	role="radiogroup"
+	class="grid grid-cols-2 gap-2 sm:grid-cols-4"
+	use:radioGroupNav={(v) => { if (TYPES.includes(v as PersonType)) select(v as PersonType); }}
+>
 	{#each TYPES as type (type)}
 		<button
 			type="button"
 			role="radio"
+			value={type}
 			aria-checked={selected === type}
 			tabindex={selected === type ? 0 : -1}
 			onclick={() => select(type)}
@@ -48,6 +54,4 @@ function select(type: PersonType) {
 
 <input type="hidden" name={name} value={selected} />
 
-<div class="sr-only" aria-live="polite">
-	{m.a11y_type_changed({ type: labels[selected]() })}
-</div>
+<div class="sr-only" aria-live="polite" aria-atomic="true">{announcement}</div>

frontend/src/lib/components/PersonTypeSelector.svelte.spec.ts

@@ -1,11 +1,23 @@
 import { describe, it, expect, afterEach } from 'vitest';
 import { cleanup, render } from 'vitest-browser-svelte';
+import { userEvent } from 'vitest/browser';
 
 import PersonTypeSelector from './PersonTypeSelector.svelte';
 
 afterEach(() => cleanup());
 
 describe('PersonTypeSelector', () => {
+	it('hidden input value updates when user navigates with ArrowRight', async () => {
+		const { container } = render(PersonTypeSelector, { value: 'PERSON' });
+		const hiddenInput = container.querySelector('input[type="hidden"]') as HTMLInputElement;
+		expect(hiddenInput.value).toBe('PERSON');
+
+		const personButton = container.querySelector('[aria-checked="true"]') as HTMLElement;
+		personButton.focus();
+		await userEvent.keyboard('{ArrowRight}');
+
+		expect(hiddenInput.value).toBe('INSTITUTION');
+	});
 	it('selected button uses semantic bg-primary and text-primary-fg classes', () => {
 		const { container } = render(PersonTypeSelector, { value: 'PERSON' });
 		const buttons = container.querySelectorAll('[role="radio"]');

frontend/src/lib/person-validation.test.ts

@@ -6,22 +6,24 @@ describe('validatePersonFields', () => {
 		expect(validatePersonFields('PERSON', 'Hans', 'Müller')).toBeNull();
 	});
 
-	it('returns lastName error when lastName is missing', () => {
-		expect(validatePersonFields('PERSON', 'Hans', '')).toBe('Nachname ist Pflichtfeld.');
+	it('returns lastName error key when lastName is missing', () => {
+		expect(validatePersonFields('PERSON', 'Hans', '')).toBe('validation_last_name_required');
 	});
 
-	it('returns lastName error when lastName is undefined', () => {
+	it('returns lastName error key when lastName is undefined', () => {
 		expect(validatePersonFields('INSTITUTION', undefined, undefined)).toBe(
-			'Nachname ist Pflichtfeld.'
+			'validation_last_name_required'
 		);
 	});
 
-	it('returns firstName error when type is PERSON and firstName is missing', () => {
-		expect(validatePersonFields('PERSON', '', 'Müller')).toBe('Vorname ist Pflichtfeld.');
+	it('returns firstName error key when type is PERSON and firstName is missing', () => {
+		expect(validatePersonFields('PERSON', '', 'Müller')).toBe('validation_first_name_required');
 	});
 
-	it('returns firstName error when type is PERSON and firstName is undefined', () => {
-		expect(validatePersonFields('PERSON', undefined, 'Müller')).toBe('Vorname ist Pflichtfeld.');
+	it('returns firstName error key when type is PERSON and firstName is undefined', () => {
+		expect(validatePersonFields('PERSON', undefined, 'Müller')).toBe(
+			'validation_first_name_required'
+		);
 	});
 
 	it('returns null for INSTITUTION without firstName', () => {

frontend/src/lib/person-validation.ts

@@ -1,9 +1,28 @@
+import { m } from '$lib/paraglide/messages.js';
+
+export const PERSON_TYPES = ['PERSON', 'INSTITUTION', 'GROUP', 'UNKNOWN'] as const;
+export type PersonType = (typeof PERSON_TYPES)[number];
+
+export function normalizePersonType(raw: string | undefined | null): PersonType {
+	return raw === 'SKIP' ? 'UNKNOWN' : ((raw ?? 'PERSON') as PersonType);
+}
+
+export type PersonValidationKey =
+	| 'validation_last_name_required'
+	| 'validation_first_name_required';
+
+export function resolveValidationMessage(key: PersonValidationKey): string {
+	return key === 'validation_last_name_required'
+		? m.validation_last_name_required()
+		: m.validation_first_name_required();
+}
+
 export function validatePersonFields(
 	personType: string,
 	firstName: string | undefined | null,
 	lastName: string | undefined | null
-): string | null {
-	if (!lastName) return 'Nachname ist Pflichtfeld.';
-	if (personType === 'PERSON' && !firstName) return 'Vorname ist Pflichtfeld.';
+): PersonValidationKey | null {
+	if (!lastName) return 'validation_last_name_required';
+	if (personType === 'PERSON' && !firstName) return 'validation_first_name_required';
 	return null;
 }

frontend/src/routes/persons/[id]/PersonCard.svelte

@@ -67,7 +67,6 @@ let {
 			</div>
 		</div>
 
-		<!-- Title (academic/honorific) — PERSON type only -->
 		{#if person.personType === 'PERSON' && person.title}
 			<p
 				class="mb-0.5 text-center font-sans text-xs tracking-widest text-ink-3 [font-variant:small-caps]"

frontend/src/routes/persons/[id]/edit/+page.server.ts

@@ -1,13 +1,11 @@
 import { error, fail, redirect } from '@sveltejs/kit';
 import { createApiClient } from '$lib/api.server';
 import { getErrorMessage } from '$lib/errors';
-import { validatePersonFields } from '$lib/person-validation';
-
-type PersonType = 'PERSON' | 'INSTITUTION' | 'GROUP' | 'UNKNOWN' | 'SKIP';
-
-export function normalizePersonType(raw: string | undefined | null): Exclude<PersonType, 'SKIP'> {
-	return raw === 'SKIP' ? 'UNKNOWN' : ((raw ?? 'PERSON') as Exclude<PersonType, 'SKIP'>);
-}
+import {
+	normalizePersonType,
+	validatePersonFields,
+	resolveValidationMessage
+} from '$lib/person-validation';
 
 export async function load({ params, fetch, locals }) {
 	const canWrite =
@@ -37,11 +35,7 @@ export async function load({ params, fetch, locals }) {
 export const actions = {
 	update: async ({ request, params, fetch }) => {
 		const formData = await request.formData();
-		const personType = (formData.get('personType')?.toString() ?? 'PERSON') as
-			| 'PERSON'
-			| 'INSTITUTION'
-			| 'GROUP'
-			| 'UNKNOWN';
+		const personType = normalizePersonType(formData.get('personType')?.toString());
 		const title = formData.get('title')?.toString().trim() || undefined;
 		const firstName = formData.get('firstName')?.toString().trim();
 		const lastName = formData.get('lastName')?.toString().trim();
@@ -52,9 +46,9 @@ export const actions = {
 		const birthYear = birthYearStr ? parseInt(birthYearStr, 10) : undefined;
 		const deathYear = deathYearStr ? parseInt(deathYearStr, 10) : undefined;
 
-		const validationError = validatePersonFields(personType, firstName, lastName);
-		if (validationError) {
-			return fail(400, { updateError: validationError });
+		const validationKey = validatePersonFields(personType, firstName, lastName);
+		if (validationKey) {
+			return fail(400, { updateError: resolveValidationMessage(validationKey) });
 		}
 
 		const api = createApiClient(fetch);

frontend/src/routes/persons/[id]/edit/PersonEditForm.svelte

@@ -2,8 +2,7 @@
 import { untrack } from 'svelte';
 import { m } from '$lib/paraglide/messages.js';
 import PersonTypeSelector from '$lib/components/PersonTypeSelector.svelte';
-
-type PersonType = 'PERSON' | 'INSTITUTION' | 'GROUP' | 'UNKNOWN';
+import { PERSON_TYPES as TYPES, type PersonType } from '$lib/person-validation';
 
 let {
 	person
@@ -20,7 +19,6 @@ let {
 	};
 } = $props();
 
-const TYPES = ['PERSON', 'INSTITUTION', 'GROUP', 'UNKNOWN'] as const;
 let selectedType = $state<PersonType>(
 	untrack(() =>
 		TYPES.includes(person.personType as PersonType) ? (person.personType as PersonType) : 'PERSON'

frontend/src/routes/persons/[id]/edit/page.server.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { normalizePersonType } from './+page.server';
+import { normalizePersonType } from '$lib/person-validation';
 
 describe('edit load — SKIP → UNKNOWN normalization', () => {
 	it('maps SKIP to UNKNOWN', () => {

frontend/src/routes/persons/new/+page.server.ts

@@ -1,7 +1,11 @@
 import { error, fail, redirect } from '@sveltejs/kit';
 import { createApiClient } from '$lib/api.server';
 import { getErrorMessage } from '$lib/errors';
-import { validatePersonFields } from '$lib/person-validation';
+import {
+	normalizePersonType,
+	validatePersonFields,
+	resolveValidationMessage
+} from '$lib/person-validation';
 
 export async function load({ locals }: { locals: App.Locals }) {
 	const canWrite =
@@ -14,11 +18,7 @@ export async function load({ locals }: { locals: App.Locals }) {
 export const actions = {
 	default: async ({ request, fetch }) => {
 		const formData = await request.formData();
-		const personType = (formData.get('personType')?.toString() ?? 'PERSON') as
-			| 'PERSON'
-			| 'INSTITUTION'
-			| 'GROUP'
-			| 'UNKNOWN';
+		const personType = normalizePersonType(formData.get('personType')?.toString());
 		const title = formData.get('title')?.toString().trim() || undefined;
 		const firstName = formData.get('firstName')?.toString().trim();
 		const lastName = formData.get('lastName')?.toString().trim();
@@ -27,10 +27,10 @@ export const actions = {
 		const deathYearStr = formData.get('deathYear')?.toString().trim();
 		const notes = formData.get('notes')?.toString().trim() || undefined;
 
-		const validationError = validatePersonFields(personType, firstName, lastName);
-		if (validationError) {
+		const validationKey = validatePersonFields(personType, firstName, lastName);
+		if (validationKey) {
 			return fail(400, {
-				error: validationError,
+				error: resolveValidationMessage(validationKey),
 				personType,
 				title,
 				firstName: firstName ?? '',

frontend/src/routes/persons/new/+page.svelte

@@ -3,9 +3,7 @@ import { untrack } from 'svelte';
 import { m } from '$lib/paraglide/messages.js';
 import BackButton from '$lib/components/BackButton.svelte';
 import PersonTypeSelector from '$lib/components/PersonTypeSelector.svelte';
-
-type PersonType = 'PERSON' | 'INSTITUTION' | 'GROUP' | 'UNKNOWN';
-const TYPES = ['PERSON', 'INSTITUTION', 'GROUP', 'UNKNOWN'] as const;
+import { PERSON_TYPES as TYPES, type PersonType } from '$lib/person-validation';
 
 let { form } = $props();