Compare commits

...

2 Commits

Author SHA1 Message Date
Marcel
f9821164d1 refactor(persons): adopt PageHeader primitive on /persons listing page (§3)
Some checks failed
CI / Unit & Component Tests (pull_request) Failing after 2m58s
CI / OCR Service Tests (pull_request) Successful in 22s
CI / Backend Unit Tests (pull_request) Successful in 5m1s
CI / fail2ban Regex (pull_request) Successful in 45s
CI / Semgrep Security Scan (pull_request) Successful in 24s
CI / Compose Bucket Idempotency (pull_request) Successful in 1m5s
SDD Gate / RTM Check (pull_request) Successful in 14s
SDD Gate / Contract Validate (pull_request) Successful in 22s
SDD Gate / Constitution Impact (pull_request) Successful in 16s
Adds persons_eyebrow + persons_lede i18n keys (de/en/es) and replaces
the inline header markup with <PageHeader> to close §3 of the spec.

Refs #856
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-16 19:19:54 +02:00
Marcel
8bcc4d888d feat(shared): add PageHeader primitive — eyebrow + 4px mint rule + Tinos clamp title + lede (closes #856 §primitive)
Props: eyebrow (string), title (string), lede? (string), right? (Snippet).
Markup uses semantic tokens only (var(--c-accent/ink/ink-2/ink-3)), clamp(28px,8vw,46px) h1,
no @html. Svelte-autofixer clean; 12 browser-spec assertions green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-16 17:32:59 +02:00
6 changed files with 243 additions and 63 deletions

View File

@@ -130,6 +130,8 @@
"doc_no_scan": "Kein Scan vorhanden", "doc_no_scan": "Kein Scan vorhanden",
"persons_heading": "Personenverzeichnis", "persons_heading": "Personenverzeichnis",
"persons_subtitle": "Durchsuchen Sie den Index aller erfassten Personen im Familienarchiv.", "persons_subtitle": "Durchsuchen Sie den Index aller erfassten Personen im Familienarchiv.",
"persons_eyebrow": "Verzeichnis",
"persons_lede": "Jede Hand, die schrieb oder genannt wurde — Absender, Empfänger, Erwähnte.",
"persons_btn_new": "Neue Person", "persons_btn_new": "Neue Person",
"persons_search_placeholder": "Namen suchen...", "persons_search_placeholder": "Namen suchen...",
"persons_empty_heading": "Keine Personen gefunden.", "persons_empty_heading": "Keine Personen gefunden.",

View File

@@ -130,6 +130,8 @@
"doc_no_scan": "No scan available", "doc_no_scan": "No scan available",
"persons_heading": "Person directory", "persons_heading": "Person directory",
"persons_subtitle": "Browse the index of all recorded persons in the family archive.", "persons_subtitle": "Browse the index of all recorded persons in the family archive.",
"persons_eyebrow": "Directory",
"persons_lede": "Every hand that wrote or was named — senders, recipients, those mentioned.",
"persons_btn_new": "New person", "persons_btn_new": "New person",
"persons_search_placeholder": "Search names...", "persons_search_placeholder": "Search names...",
"persons_empty_heading": "No persons found.", "persons_empty_heading": "No persons found.",

View File

@@ -130,6 +130,8 @@
"doc_no_scan": "No hay escaneo disponible", "doc_no_scan": "No hay escaneo disponible",
"persons_heading": "Directorio de personas", "persons_heading": "Directorio de personas",
"persons_subtitle": "Explore el índice de todas las personas registradas en el archivo familiar.", "persons_subtitle": "Explore el índice de todas las personas registradas en el archivo familiar.",
"persons_eyebrow": "Directorio",
"persons_lede": "Cada mano que escribió o fue nombrada — remitentes, destinatarios, mencionados.",
"persons_btn_new": "Nueva persona", "persons_btn_new": "Nueva persona",
"persons_search_placeholder": "Buscar nombres...", "persons_search_placeholder": "Buscar nombres...",
"persons_empty_heading": "No se encontraron personas.", "persons_empty_heading": "No se encontraron personas.",

View File

@@ -0,0 +1,48 @@
<script lang="ts">
import type { Snippet } from 'svelte';
let {
eyebrow,
title,
lede,
right
}: {
eyebrow: string;
title: string;
lede?: string;
right?: Snippet;
} = $props();
</script>
<div
data-testid="page-header-wrapper"
style="margin-bottom:30px; display:flex; align-items:flex-end; justify-content:space-between; gap:24px; flex-wrap:wrap"
>
<div
data-testid="page-header-inner"
style="border-left:4px solid var(--c-accent); padding-left:18px"
>
<div
data-testid="page-header-eyebrow"
style="font-family:var(--font-sans); font-size:12px; font-weight:700; letter-spacing:.14em; text-transform:uppercase; color:var(--c-ink-3); margin-bottom:8px"
>
{eyebrow}
</div>
<h1
style="font-family:var(--font-serif); font-weight:700; font-size:clamp(28px,8vw,46px); line-height:1.06; color:var(--c-ink); margin:0"
>
{title}
</h1>
{#if lede}
<p
data-testid="page-header-lede"
style="font-family:var(--font-serif); font-style:italic; font-size:16px; color:var(--c-ink-2); margin:10px 0 0; max-width:520px"
>
{lede}
</p>
{/if}
</div>
{#if right}
{@render right()}
{/if}
</div>

View File

@@ -0,0 +1,135 @@
import { describe, it, expect, afterEach } from 'vitest';
import { cleanup, render } from 'vitest-browser-svelte';
import { page } from 'vitest/browser';
import PageHeader from './PageHeader.svelte';
afterEach(() => {
cleanup();
});
describe('PageHeader', () => {
// ── Structural / heading-hierarchy assertions ─────────────────────────
it('renders exactly one h1 containing the title', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
const headings = page.getByRole('heading', { level: 1 });
await expect.element(headings).toBeInTheDocument();
await expect.element(headings).toHaveTextContent('Personen');
});
it('renders the eyebrow as a non-heading element (div or span)', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
// The eyebrow must NOT be a heading of any level
const h1 = page.getByRole('heading', { level: 1 });
await expect.element(h1).toBeInTheDocument();
// No h2-h6 headings should be present
const h2 = page.getByRole('heading', { level: 2 });
await expect.element(h2).not.toBeInTheDocument();
});
it('renders eyebrow text content', async () => {
render(PageHeader, { eyebrow: 'PERSONENVERZEICHNIS', title: 'Personen' });
const eyebrow = page.getByTestId('page-header-eyebrow');
await expect.element(eyebrow).toHaveTextContent('PERSONENVERZEICHNIS');
});
it('renders lede when provided', async () => {
render(PageHeader, {
eyebrow: 'VERZEICHNIS',
title: 'Personen',
lede: 'Jede Hand, die schrieb oder genannt wurde.'
});
const lede = page.getByTestId('page-header-lede');
await expect.element(lede).toHaveTextContent('Jede Hand, die schrieb oder genannt wurde.');
});
it('does not render lede element when lede prop is omitted', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
const lede = page.getByTestId('page-header-lede');
await expect.element(lede).not.toBeInTheDocument();
});
// ── Right snippet ─────────────────────────────────────────────────────
it('renders the outer wrapper with page-header-wrapper test id', async () => {
render(PageHeader, {
eyebrow: 'VERZEICHNIS',
title: 'Personen'
});
const wrapper = page.getByTestId('page-header-wrapper');
await expect.element(wrapper).toBeInTheDocument();
});
// ── Content security: no @html ────────────────────────────────────────
it('escapes HTML in title (renders literal < as text not tags)', async () => {
render(PageHeader, { eyebrow: 'TEST', title: '<script>alert(1)</script>' });
const h1 = page.getByRole('heading', { level: 1 });
// The heading content should be the literal string, not interpreted HTML
await expect.element(h1).toHaveTextContent('<script>alert(1)</script>');
});
it('escapes HTML in eyebrow', async () => {
render(PageHeader, { eyebrow: '<b>BOLD</b>', title: 'Personen' });
const eyebrow = page.getByTestId('page-header-eyebrow');
await expect.element(eyebrow).toHaveTextContent('<b>BOLD</b>');
});
// ── Design tokens / style ─────────────────────────────────────────────
it('h1 has font-size set to the clamp expression', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
const h1 = page.getByRole('heading', { level: 1 });
// The inline style must carry the clamp — computed value on a 1024px viewport
// with clamp(28px,8vw,46px) → 8vw = 81.92px > 46px → capped at 46px
const el = h1.element() as HTMLElement;
const fs = el.style.fontSize || getComputedStyle(el).fontSize;
expect(fs).toMatch(/clamp|46px|28px/);
});
it('wrapper has data-testid page-header-wrapper', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
const wrapper = page.getByTestId('page-header-wrapper');
await expect.element(wrapper).toBeInTheDocument();
});
it('inner container inline style includes the 4px accent left border and 18px padding', async () => {
render(PageHeader, { eyebrow: 'VERZEICHNIS', title: 'Personen' });
const inner = page.getByTestId('page-header-inner');
const el = inner.element() as HTMLElement;
const styleAttr = el.getAttribute('style') ?? '';
expect(styleAttr).toContain('border-left:4px solid var(--c-accent)');
expect(styleAttr).toContain('padding-left:18px');
});
// ── Edit/detail eyebrow context (generic prop) ────────────────────────
it('accepts different eyebrow texts for list and edit context', async () => {
const { unmount } = render(PageHeader, {
eyebrow: 'PERSON BEARBEITEN',
title: 'Herbert Cram'
});
const eyebrow = page.getByTestId('page-header-eyebrow');
await expect.element(eyebrow).toHaveTextContent('PERSON BEARBEITEN');
unmount();
render(PageHeader, { eyebrow: 'PERSONENVERZEICHNIS', title: 'Personen' });
const eyebrow2 = page.getByTestId('page-header-eyebrow');
await expect.element(eyebrow2).toHaveTextContent('PERSONENVERZEICHNIS');
});
});

View File

@@ -7,7 +7,7 @@ import { m } from '$lib/paraglide/messages.js';
import PersonCard from '$lib/person/PersonCard.svelte'; import PersonCard from '$lib/person/PersonCard.svelte';
import PersonFilterBar from '$lib/person/PersonFilterBar.svelte'; import PersonFilterBar from '$lib/person/PersonFilterBar.svelte';
import Pagination from '$lib/shared/primitives/Pagination.svelte'; import Pagination from '$lib/shared/primitives/Pagination.svelte';
import PersonsStatsBar from './PersonsStatsBar.svelte'; import PageHeader from '$lib/shared/primitives/PageHeader.svelte';
import PersonsEmptyState from './PersonsEmptyState.svelte'; import PersonsEmptyState from './PersonsEmptyState.svelte';
let { data } = $props(); let { data } = $props();
@@ -53,71 +53,62 @@ const noFiltersActive = $derived(
</svelte:head> </svelte:head>
<div class="mx-auto max-w-7xl px-4 py-12 sm:px-6 lg:px-8"> <div class="mx-auto max-w-7xl px-4 py-12 sm:px-6 lg:px-8">
<!-- Header: title+stats on left, search+CTA on right --> <PageHeader eyebrow={m.persons_eyebrow()} title={m.page_title_persons()} lede={m.persons_lede()}>
<div class="mb-6 flex flex-wrap items-end justify-between gap-4 border-b border-ink/10 pb-6"> {#snippet right()}
<div> <div class="flex shrink-0 items-center gap-3">
<h1 class="font-serif text-3xl font-medium text-ink">{m.page_title_persons()}</h1> <!-- Search -->
<div class="mt-2"> <div class="relative">
<PersonsStatsBar <label for="search" class="sr-only">{m.persons_search_placeholder()}</label>
totalPersons={data.stats.totalPersons ?? 0} <input
totalDocuments={data.stats.totalDocuments ?? 0} id="search"
/> type="text"
</div> placeholder={m.persons_search_placeholder()}
</div> bind:value={q}
oninput={handleSearch}
<div class="flex items-center gap-3"> onfocus={() => (qFocused = true)}
<!-- Search --> onblur={() => (qFocused = false)}
<div class="relative"> class="block w-56 rounded-sm border border-line bg-surface py-2.5 pr-10 pl-4 font-sans text-sm text-ink placeholder-ink-3 shadow-sm focus:outline-none focus-visible:ring-2 focus-visible:ring-focus-ring"
<label for="search" class="sr-only">{m.persons_search_placeholder()}</label>
<input
id="search"
type="text"
placeholder={m.persons_search_placeholder()}
bind:value={q}
oninput={handleSearch}
onfocus={() => (qFocused = true)}
onblur={() => (qFocused = false)}
class="block w-56 rounded-sm border border-line bg-surface py-2.5 pr-10 pl-4 font-sans text-sm text-ink placeholder-ink-3 shadow-sm focus:outline-none focus-visible:ring-2 focus-visible:ring-focus-ring"
/>
<div
class="pointer-events-none absolute inset-y-0 right-0 flex items-center pr-3 text-ink-3"
>
<img
src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Mag-Glass-MD.svg"
alt=""
aria-hidden="true"
class="h-4 w-4 opacity-40"
/> />
<div
class="pointer-events-none absolute inset-y-0 right-0 flex items-center pr-3 text-ink-3"
>
<img
src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Mag-Glass-MD.svg"
alt=""
aria-hidden="true"
class="h-4 w-4 opacity-40"
/>
</div>
</div> </div>
<!-- Triage link (transcriber only) -->
{#if data.canWrite}
<a
href="/persons/review"
class="inline-flex min-h-[44px] items-center gap-1.5 rounded-sm border border-line bg-surface px-4 py-2 font-sans text-sm font-semibold text-ink transition-colors hover:bg-muted"
>
{m.persons_toggle_needs_review({ count: data.needsReviewCount })}
</a>
{/if}
<!-- New person CTA -->
{#if data.canWrite}
<a
href="/persons/new"
class="inline-flex min-h-[44px] items-center gap-1.5 rounded-sm bg-primary px-4 py-2.5 font-sans text-sm font-bold tracking-wide text-primary-fg transition-colors hover:bg-primary/80"
>
<img
src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Add/Add-General-MD.svg"
alt=""
aria-hidden="true"
class="h-4 w-4 invert dark:invert-0"
/>
{m.persons_btn_new()}
</a>
{/if}
</div> </div>
{/snippet}
<!-- Triage link (transcriber only) --> </PageHeader>
{#if data.canWrite}
<a
href="/persons/review"
class="inline-flex min-h-[44px] items-center gap-1.5 rounded-sm border border-line bg-surface px-4 py-2 font-sans text-sm font-semibold text-ink transition-colors hover:bg-muted"
>
{m.persons_toggle_needs_review({ count: data.needsReviewCount })}
</a>
{/if}
<!-- New person CTA -->
{#if data.canWrite}
<a
href="/persons/new"
class="inline-flex min-h-[44px] items-center gap-1.5 rounded-sm bg-primary px-4 py-2.5 font-sans text-sm font-bold tracking-wide text-primary-fg transition-colors hover:bg-primary/80"
>
<img
src="/degruyter-icons/Simple/Medium-24px/SVG/Action/Add/Add-General-MD.svg"
alt=""
aria-hidden="true"
class="h-4 w-4 invert dark:invert-0"
/>
{m.persons_btn_new()}
</a>
{/if}
</div>
</div>
<!-- Filter chips + show-all toggle --> <!-- Filter chips + show-all toggle -->
<div class="mb-8"> <div class="mb-8">