test: improve backend branch coverage (currently 46%) #148

New Issue

marcel · 2026-03-28T18:05:08+01:00

marcel commented

2026-03-28 18:05:08 +01:00

Summary

The JaCoCo branch coverage gate added in #120 is set to 42% minimum. Current measured coverage is 46% — only 4 percentage points of headroom. This issue tracks improving test coverage in the weakest areas.

Current coverage by package (last `mvnw verify` run)

Package	Branches covered	%
`security`	11 / 14	78% ✅
`service`	241 / 478	50% ⚠️
`controller`	13 / 50	26% ❌
`repository`	0 / 24	0% ❌
Overall	265 / 566	46%

Priority areas

`repository` — 0% (0/24 branches)

Zero coverage. The @DataJpaTest tests added in #119 cover DocumentRepository and PersonRepository, but these 24 repository branches likely come from custom JPQL/derived query methods that need assertion-level tests, not just happy-path saves.

`controller` — 26% (13/50 branches)

Controllers have many if-blocks for permission checks, null guards, and error paths. These are not covered by unit tests and would benefit from @WebMvcTest slice tests or MockMvc integration tests.

`service` — 50% (241/478 branches)

The largest package. Many error branches in DocumentService, MassImportService, and UserService are untested. Consider targeted unit tests with mocked repositories for error paths.

Gate

The current minimum is 42%. Any PR that drops coverage below this will fail mvnw verify. Aim to raise the gate as coverage improves — suggested milestones: 50% → 60% → 70%.

## Summary The JaCoCo branch coverage gate added in #120 is set to **42%** minimum. Current measured coverage is **46%** — only 4 percentage points of headroom. This issue tracks improving test coverage in the weakest areas. ## Current coverage by package (last `mvnw verify` run) | Package | Branches covered | % | |---|---|---| | `security` | 11 / 14 | **78%** ✅ | | `service` | 241 / 478 | **50%** ⚠️ | | `controller` | 13 / 50 | **26%** ❌ | | `repository` | 0 / 24 | **0%** ❌ | | **Overall** | **265 / 566** | **46%** | ## Priority areas ### `repository` — 0% (0/24 branches) Zero coverage. The `@DataJpaTest` tests added in #119 cover `DocumentRepository` and `PersonRepository`, but these 24 repository branches likely come from custom JPQL/derived query methods that need assertion-level tests, not just happy-path saves. ### `controller` — 26% (13/50 branches) Controllers have many `if`-blocks for permission checks, null guards, and error paths. These are not covered by unit tests and would benefit from `@WebMvcTest` slice tests or MockMvc integration tests. ### `service` — 50% (241/478 branches) The largest package. Many error branches in `DocumentService`, `MassImportService`, and `UserService` are untested. Consider targeted unit tests with mocked repositories for error paths. ## Gate The current minimum is 42%. Any PR that drops coverage below this will fail `mvnw verify`. Aim to raise the gate as coverage improves — suggested milestones: 50% → 60% → 70%.

marcel added the test label 2026-03-28 18:05:19 +01:00

marcel referenced this issue from a commit

2026-03-28 20:07:28 +01:00

test(#148): add PersonController, DocumentSpecifications, and PersonRepository tests

marcel referenced this issue from a commit

2026-03-28 20:14:14 +01:00

fix(#148): flush entity manager after @Modifying queries in PersonRepositoryTest

marcel referenced this issue from a commit

2026-03-28 21:42:48 +01:00

test(#148): add service unit tests reaching 90.2% branch coverage

marcel referenced this issue

2026-03-28 21:44:42 +01:00