refactor: extract sort/filter/count row from CorrespondenzPersonBar #188

Open
opened 2026-04-07 09:06:52 +02:00 by marcel · 0 comments
Owner

Context

CorrespondenzPersonBar is at 183 lines after the Briefwechsel redesign (PR #186). It now handles person inputs, swap button, sort button, filter toggle, document count, and correspondent suggestions dropdown.

It's still one visual region (the search card's top section), but if more controls are added later it should be split.

Proposed change

Extract the sort/filter/count row (Row 2) into a dedicated CorrespondenzToolbar.svelte component. The person bar keeps Row 1 (person inputs + swap). The toolbar receives sortDir, showAdvanced, documentCount, and the toggle callbacks as props.

When to do this

Only when the next feature adds controls to this area. Not needed now — tracking to avoid forgetting.

Origin

Flagged by @felixbrandt during PR #186 review.

## Context `CorrespondenzPersonBar` is at 183 lines after the Briefwechsel redesign (PR #186). It now handles person inputs, swap button, sort button, filter toggle, document count, and correspondent suggestions dropdown. It's still one visual region (the search card's top section), but if more controls are added later it should be split. ## Proposed change Extract the sort/filter/count row (Row 2) into a dedicated `CorrespondenzToolbar.svelte` component. The person bar keeps Row 1 (person inputs + swap). The toolbar receives `sortDir`, `showAdvanced`, `documentCount`, and the toggle callbacks as props. ## When to do this Only when the next feature adds controls to this area. Not needed now — tracking to avoid forgetting. ## Origin Flagged by @felixbrandt during PR #186 review.
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#188