marcel/familienarchiv
1
0
Fork 0
Code Issues 117 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test: add auto-focus test for Briefwechsel hero typeahead #189

New Issue
Open
opened 2026-04-07 09:06:58 +02:00 by marcel · 0 comments
marcel commented 2026-04-07 09:06:58 +02:00
Owner
Copy Link

Context

The CorrespondenzHero component auto-focuses the PersonTypeahead input on mount via onMount + tick() + element.focus(). This is a key UX requirement from #179 (users shouldn't have to click).

Currently there's no automated test for this behaviour — it was deferred during PR #186 because document.activeElement assertions are unreliable in headless Playwright with vitest-browser-svelte.

Proposed change

Investigate whether a reliable focus test can be written, e.g.:

  • await expect(document.activeElement?.id).toBe('senderId-search') after render
  • Or a Playwright E2E test that checks focus state after navigation to /briefwechsel

If it remains flaky, document the manual verification step in the test file as a comment.

Origin

Flagged by @saraholt during PR #186 review.

## Context The `CorrespondenzHero` component auto-focuses the PersonTypeahead input on mount via `onMount` + `tick()` + `element.focus()`. This is a key UX requirement from #179 (users shouldn't have to click). Currently there's no automated test for this behaviour — it was deferred during PR #186 because `document.activeElement` assertions are unreliable in headless Playwright with `vitest-browser-svelte`. ## Proposed change Investigate whether a reliable focus test can be written, e.g.: - `await expect(document.activeElement?.id).toBe('senderId-search')` after render - Or a Playwright E2E test that checks focus state after navigation to `/briefwechsel` If it remains flaky, document the manual verification step in the test file as a comment. ## Origin Flagged by @saraholt during PR #186 review.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0-critical
Blocks a core user journey, causes data loss, or is a security/accessibility barrier. Work on this before P1+.
 P1-high
Significant friction on a main user journey; workaround exists but is non-obvious. Next up after P0.
 P2-medium
Noticeable improvement; doesn't block anything; schedule opportunistically.
 P3-later
Cosmetic or parking-lot work; fine to stay open indefinitely.
 audit
Read-only audit / assessment work; produces a report rather than changing code
 bug
Something isn't working
 cleanup
Removal of dead code, vague comments, naming violations, and scratch artifacts
 collaboration
We want to extend the family archive to have more collaboration tools
 conversation
descoped
We will do that later
 devops
documentation
README, ARCHITECTURE, GLOSSARY, CONTRIBUTING, per-domain docs
 epic
Marker for epic-level issues that group multiple child issues
 feature
file-upload
legibility
Codebase Legibility Refactor — preparing the codebase for human evaluation and bus-factor reduction
 notification
person
phase-1: security
Security hygiene — must be done first
 phase-2: container-images
Production-ready multi-stage Docker images
 phase-3: prod-compose
Production compose overlay + Caddy reverse proxy
 phase-4: spring-prod-profile
Spring Boot production configuration profile
 phase-5: backups
Database and object storage backup strategy
 phase-6: deployment-docs
.env.example, DEPLOYMENT.md, runbook
 phase-7: monitoring
Prometheus, Loki, Grafana, Alertmanager
 refactor
Code restructuring without behaviour change
 security
test
ui
UI/UX and accessibility issues
 user
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Jens marcel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#189
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?