fix(ocr): regenerate TypeScript types so TriggerSenderTrainingDTO.personId is non-optional #266

New Issue

marcel · 2026-04-18T09:26:11+02:00

marcel commented

2026-04-18 09:26:11 +02:00

Background

Deferred during PR #265 review cycle 2.

Concern

The generated TypeScript type for TriggerSenderTrainingDTO shows personId?: string (optional) even though the Java record has @Schema(requiredMode = REQUIRED) and @NotNull. The running Docker backend is an older image without the feature branch code, so regenerating types was not possible during the PR review cycle.

Reviewer @Nora (security): "The personId field in TriggerSenderTrainingDTO is @NotNull on the backend but shows as optional (personId?: string) in the generated TypeScript — fix by regenerating types once the feature branch is merged."

Why deferred

Regenerating types requires:

Building the feature branch JAR (./mvnw clean package -DskipTests)
Starting it with --spring.profiles.active=dev — conflicts with the running Docker backend on port 8080
Running npm run generate:api in frontend/

This is safe to do after the feature branch merges to main.

Steps

Merge PR #265 to main
Build backend: cd backend && ./mvnw clean package -DskipTests
Stop docker backend: docker-compose stop backend
Run: java -jar target/*.jar --spring.profiles.active=dev
cd frontend && npm run generate:api
Verify TriggerSenderTrainingDTO.personId is now personId: string (required)
Commit the updated generated types

Reference

PR: http://heim-nas:3005/marcel/familienarchiv/pulls/265

## Background Deferred during PR #265 review cycle 2. ## Concern The generated TypeScript type for `TriggerSenderTrainingDTO` shows `personId?: string` (optional) even though the Java record has `@Schema(requiredMode = REQUIRED)` and `@NotNull`. The running Docker backend is an older image without the feature branch code, so regenerating types was not possible during the PR review cycle. Reviewer @Nora (security): "The `personId` field in `TriggerSenderTrainingDTO` is `@NotNull` on the backend but shows as optional (`personId?: string`) in the generated TypeScript — fix by regenerating types once the feature branch is merged." ## Why deferred Regenerating types requires: 1. Building the feature branch JAR (`./mvnw clean package -DskipTests`) 2. Starting it with `--spring.profiles.active=dev` — conflicts with the running Docker backend on port 8080 3. Running `npm run generate:api` in `frontend/` This is safe to do after the feature branch merges to main. ## Steps 1. Merge PR #265 to main 2. Build backend: `cd backend && ./mvnw clean package -DskipTests` 3. Stop docker backend: `docker-compose stop backend` 4. Run: `java -jar target/*.jar --spring.profiles.active=dev` 5. `cd frontend && npm run generate:api` 6. Verify `TriggerSenderTrainingDTO.personId` is now `personId: string` (required) 7. Commit the updated generated types ## Reference PR: http://heim-nas:3005/marcel/familienarchiv/pulls/265

marcel referenced this issue

2026-04-18 09:26:21 +02:00

feat(admin): OCR admin pages — overview & model detail #265

marcel referenced this issue

2026-04-18 09:29:11 +02:00

feat(admin): OCR admin pages — overview & model detail #265

marcel referenced this issue

2026-04-18 10:02:42 +02:00

feat(admin): OCR admin pages — overview & model detail #264

marcel closed this issue

2026-04-28 11:19:02 +02:00

Sign in to join this conversation.