chore(transcription): track handleAnnotationDeleteRequest wiring from PR #352 #357

Open
opened 2026-04-27 08:12:52 +02:00 by marcel · 0 comments
Owner

Context

PR #352 (bulk "Alle als fertig markieren") included an unrelated change to frontend/src/routes/documents/[id]/+page.svelte: the wiring of handleAnnotationDeleteRequest / onDeleteAnnotationRequest.

This change is correct and was accepted in PR #352 (merged into the branch), but it was not scoped to issue #345 and has no linked issue or acceptance criteria.

Raised by Markus (Architect), Felix (Developer), and Elicit (Requirements) in the PR #352 Decision Queue (Item 2).

What was changed

In +page.svelte, a handleAnnotationDeleteRequest function was added (or wired) to handle the annotation delete confirmation flow — including a confirm() dialog before deleting, and a fallback path to DELETE /api/documents/{id}/annotations/{annotationId} when the annotation has no linked transcription block.

Acceptance criteria

  • Verify the annotation delete confirmation flow is fully spec'd and working as intended
  • If additional UI or behavior is needed (e.g. toast on error, undo), create a child issue
  • No further code changes required if the existing behavior is correct (this is a tracking issue)
  • Unrelated change was included in: PR #352
  • Bulk-review feature: #345
## Context PR #352 (bulk "Alle als fertig markieren") included an unrelated change to `frontend/src/routes/documents/[id]/+page.svelte`: the wiring of `handleAnnotationDeleteRequest` / `onDeleteAnnotationRequest`. This change is correct and was accepted in PR #352 (merged into the branch), but it was not scoped to issue #345 and has no linked issue or acceptance criteria. Raised by Markus (Architect), Felix (Developer), and Elicit (Requirements) in the PR #352 Decision Queue (Item 2). ## What was changed In `+page.svelte`, a `handleAnnotationDeleteRequest` function was added (or wired) to handle the annotation delete confirmation flow — including a `confirm()` dialog before deleting, and a fallback path to `DELETE /api/documents/{id}/annotations/{annotationId}` when the annotation has no linked transcription block. ## Acceptance criteria - [ ] Verify the annotation delete confirmation flow is fully spec'd and working as intended - [ ] If additional UI or behavior is needed (e.g. toast on error, undo), create a child issue - [ ] No further code changes required if the existing behavior is correct (this is a tracking issue) ## Links - Unrelated change was included in: PR #352 - Bulk-review feature: #345
marcel added the P3-later label 2026-04-27 08:12:58 +02:00
Sign in to join this conversation.
No Label P3-later
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: marcel/familienarchiv#357